From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C0D4C4332F for ; Wed, 12 Oct 2022 10:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gNdavtlxuf6P3hF8bTAzfjbp3qwGf8nPg8ec7DQ3kUA=; b=LZMXa12Z+6cQHM juEcSYiuMjuGnmQ0kv2Ojl1PZzsmeMWuHY7NLSyDFzseh9q7xMidP/arxosU2ioDCNA2FJe8FKmxV mOYYtSBihhKto90P/POQi7PYkFYwz4FZpxy+McpgxF1sdTkcfc7JYAg4ns7FL2fNy+JCNXrKQvDR7 o4hS64tTyiudj1ppjaAV4AhujjbyeAHjRacYmbQQq732/ac+jrxZVq5V6lQoiKJaEeryUrWX4KNT+ Hsd8l27V6qVO39eG9bYqwErsu3jhsCptWdi3AErSgXdb9HpHPC4Bt/CwEQTSOH8L/F4hnoEzorDIE FtMv3SIvT7m5EjUUf1Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiYz8-007fmb-Ci; Wed, 12 Oct 2022 10:29:10 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiYz5-007fkh-At for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 10:29:08 +0000 Received: by mail-wr1-x431.google.com with SMTP id u10so25592173wrq.2 for ; Wed, 12 Oct 2022 03:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cMt1aL/E1BmzA/95rCNVdItc5Kfhg0GFqfGel3e+zbE=; b=bHfVRBUuRXOtzm5qHBRADP8cD7GTOZXxO80RTmHUCSkO5IAW3rFX1sWl2055ma4y+h Njw1FT0LA9lH8iTi3jBdIyj6iNlKqkQyKlP+tBIEWw/NlwJ9Mxsky/FTvDm9ZPzP22HV 7dN7zO3lCWKRCaa/7xE178mNydWYGmFTY3Itxith055fTzksOBVyhVYocjWDm9n0zUw+ ylwylW7QzAkyPOg38jl8vo60Nq2k3rye/izFSh1zF/iggo6xtDAWk6SfjtjHYeqDojhr BD8TznS3Ylqe3FoOMuDc6pQ7o37w/PMNxne5mzhtu5XjEtQagSErN7U+IFMq+jKJmSn9 lDQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cMt1aL/E1BmzA/95rCNVdItc5Kfhg0GFqfGel3e+zbE=; b=joeAnJbUg8zJjZsbUUn+LcyBzELMOybleysEiWTEU+PLIeKiHTxAe7aHMnImAIV41u 49nfc5+o+eTs/7uNkQ5cTwsGXvpXy4Is24/Fn5QsVDaN8fuE74KpEvrGDQeO0NpKkT9U DQIkUk1nvl8A4b5+oYPSDBURwnzdmBr5TDv0dlGG06Uq10QqJhXvAOkcEiXhqgZhRdH7 XiAykDfmTsocUxCS2BYgANKGrtp4nqrqDPxapFQT+VU8UQUck1QOhaTOo5z7TfWaMts/ JZyfV1SWtufIPi4Nadh2PRpOlP8H8Nt4fRrChCcn8YqBS4zBRBzfZjTxa8EsqEVPJzzk MMBA== X-Gm-Message-State: ACrzQf0Dw/nc8LlYDE4hizHGBJzOtfYzthrgPQ6WZzCrIPEtifv8of0c LnLpyEqlQSe07+vHbR8PYR/c0w== X-Google-Smtp-Source: AMsMyM6aleo8xLLLDII4VdjsqTh4bJE28lsCUuyzn3j+VQwOmEWm/XTqLD9AyPCLE57sGU8ie7I5rg== X-Received: by 2002:a5d:5d89:0:b0:226:e5ca:4bc2 with SMTP id ci9-20020a5d5d89000000b00226e5ca4bc2mr17755457wrb.310.1665570544589; Wed, 12 Oct 2022 03:29:04 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id c188-20020a1c35c5000000b003b4a68645e9sm1430138wma.34.2022.10.12.03.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 03:29:04 -0700 (PDT) Date: Wed, 12 Oct 2022 11:29:02 +0100 From: Daniel Thompson To: Dmitry Torokhov Cc: Linus Walleij , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 4/7] gpiolib: of: add a quirk for reset line for Marvell NFC controller Message-ID: References: <20221011-gpiolib-quirks-v1-0-e01d9d3e7b29@gmail.com> <20221011-gpiolib-quirks-v1-4-e01d9d3e7b29@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221011-gpiolib-quirks-v1-4-e01d9d3e7b29@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_032907_383496_E1FD4CF7 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 11, 2022 at 03:19:32PM -0700, Dmitry Torokhov wrote: > The controller is using non-standard "reset-n-io" name for its reset > gpio property, whereas gpiod API expects "-gpios". Add a quirk > so that gpiod API will still work on unmodified DTSes. > > Signed-off-by: Dmitry Torokhov How/when has/will the DT bindings documentation for this hardware be updated to describe the new bindings? Delivering the quirks ahead of driver updates is great for avoiding merge conflicts but it also conceals the rename from reviewers so risks neglecting to update the bindings. Other than that: Reviewed-by: Daniel Thompson Daniel. > --- > drivers/gpio/gpiolib-of.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index 576f2f0c3432..7d4193fe36e5 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -383,6 +383,16 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np, > #if IS_ENABLED(CONFIG_MFD_ARIZONA) > { "wlf,reset", NULL, NULL }, > #endif > + > +#if IS_ENABLED(CONFIG_NFC_MRVL_I2C) > + { "reset", "reset-n-io", "marvell,nfc-i2c" }, > +#endif > +#if IS_ENABLED(CONFIG_NFC_MRVL_SPI) > + { "reset", "reset-n-io", "marvell,nfc-spi" }, > +#endif > +#if IS_ENABLED(CONFIG_NFC_MRVL_UART) > + { "reset", "reset-n-io", "marvell,nfc-uart" }, > +#endif > #if !IS_ENABLED(CONFIG_PCI_LANTIQ) > /* MIPS Lantiq PCI */ > { "reset", "gpios-reset", "lantiq,pci-xway" }, > > -- > b4 0.11.0-dev-5166b _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel