From: Kent Gibson <warthog618@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-actions@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
linux-rpi-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s)
Date: Wed, 12 Oct 2022 21:54:39 +0800 [thread overview]
Message-ID: <Y0bHH06cbngWk4mH@sol> (raw)
In-Reply-To: <Y0bBXSHyxpdTGxoU@smile.fi.intel.com>
On Wed, Oct 12, 2022 at 04:30:05PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 11, 2022 at 08:01:27AM +0800, Kent Gibson wrote:
> > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > > -#include <linux/gpio.h>
> > > #include <linux/gpio/driver.h>
> > > +#include <linux/gpio.h>
>
> > But moving the gpio subsystem header after the gpio/driver is not
> > alphabetical ('.' precedes '/') and it read better and made more sense
> > to me the way it was.
>
> Okay, I will move it back.
>
> ...
>
> > > +#include <linux/seq_file.h>
> >
> > I wasn't aware that we use anything from seq_file.
> > What am I missing?
>
>
> Eventually I can answer to your question: the commit 0ae3109a8391
> ("gpiolib: cdev: add fdinfo output for line request file descriptors")
> is what you are missing.
>
> That said, we need this patch.
>
Ah, yes - totally forgot that one is in flight.
That makes sense then.
With the gpio headers retaining their original order:
Rewiewed-by: Kent Gibson <warthog618@gmail.com>
> --
> With Best Regards,
> Andy Shevchenko
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-12 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221010201453.77401-1-andriy.shevchenko@linux.intel.com>
[not found] ` <20221010201453.77401-3-andriy.shevchenko@linux.intel.com>
[not found] ` <Y0SyVwjDl7NGfTPn@sol>
[not found] ` <CAHp75Vf4oS8g0zxgismtLrzsJ7AE-bdMEq+GAzx2=Mwnhuk3UA@mail.gmail.com>
2022-10-11 13:48 ` [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) Andy Shevchenko
2022-10-11 14:13 ` Kent Gibson
2022-10-11 14:28 ` Andy Shevchenko
2022-10-11 14:39 ` Geert Uytterhoeven
2022-10-11 15:19 ` Andy Shevchenko
2022-10-11 15:44 ` Andy Shevchenko
2022-10-12 13:30 ` Andy Shevchenko
2022-10-12 13:54 ` Kent Gibson [this message]
[not found] ` <0684f480-2092-d520-2c8e-bd9a2dca47e3@gmail.com>
[not found] ` <CAHp75VdDjyUAZBTaoPOe5oA3f_5xRznAooq08=Eff4F1AZyVOQ@mail.gmail.com>
2022-10-14 15:11 ` [rft, PATCH v2 00/36] pinctrl: Clean up and add missed headers Andy Shevchenko
[not found] ` <CACRpkdZ1M3ckw+jFgvMqG4jvR-t_44GPoZ6ZDXszwZCJr-cDpg@mail.gmail.com>
2022-10-17 9:27 ` Andy Shevchenko
2022-10-17 9:58 ` Linus Walleij
2022-10-17 12:18 ` Andy Shevchenko
[not found] ` <20221010201453.77401-37-andriy.shevchenko@linux.intel.com>
[not found] ` <d63088d7-202b-a550-01e5-345a22de5f7d@amd.com>
[not found] ` <CAMuHMdUfdQnisexfs4yLjeKs-LUPY1HjChrgeNjNL1qSErir9Q@mail.gmail.com>
[not found] ` <Y0UyOWALxSFai2w6@smile.fi.intel.com>
[not found] ` <CAMuHMdVU-cTBMzgBrbzA9+ZYybVS8kdYaA9spU9oDfqrLMvCuA@mail.gmail.com>
2022-10-18 13:07 ` [PATCH v2 36/36] pinctrl: Clean up headers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0bHH06cbngWk4mH@sol \
--to=warthog618@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).