From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0066EC433FE for ; Wed, 12 Oct 2022 16:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hxjTLQA+D4wY4gqUzTFleu5a4U190RLPQ0bLBPpRoSs=; b=b2hZX//iNk54cG Qb2EoFPQlZu4qOqCOCxi/1fOEMWteGNVUq9cGXCU9TxYujWy/yC+qQx1ijrvhH6NOZO1MNu6rXdSw ROJPuiZG55i062cov7rCKdr31u3JU9cXum8VbeqA5whUWn/Va4Rr7usMFBxQBJKn3Fn0bhlNO0ZQ3 tV5CznIsC9YvWgF6p7JoWDXGVWR+mZmz6KABNn/XOPFUGiv470cj3XnoI41zLuJ3NbfWGyVXlN8gU dCncgMmNwpmdXoCIaABvELDg3gEM13TjQ6XYjCMYgXAmRX1C/SIE90upPlEqdyc0VMqV9hF8nn1qj 1fkpYabqufRnLxjk37MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiexg-008lD4-5Y; Wed, 12 Oct 2022 16:52:04 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiexc-008lBK-Ay for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 16:52:02 +0000 Received: by mail-ed1-x52d.google.com with SMTP id m16so2214145edc.4 for ; Wed, 12 Oct 2022 09:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/eHg9l9Spros3WG/ZoZz0uKFq6WrSdE+qNQJXriOHqA=; b=c/1n3aEQ9AR831fFKEu+GD/Z48ZlJ4p4BzvRu3U8YijRH1RIoa4IqS7Ou0TAkS/Zvy mpF9Pze1sLPLi4aQvrr+rp86WQUDyL3oAOfi+Bz5aKZyPzG7Fw/OUuVOg1zUh1ePFTE9 mD7YN3DeKK93NhqCCvoa1otU0ULGVlkeMZOry2oCHnV1QkZV+l1intUptitH5zxcE6r6 6v49skDRKGiIZbQFWrPJlmsYkRoCNIW04TBaLC3ti4LxKEBsaP8z1h5xd3JluzNo+tcX MpyAOPIKO1WcWkwglAmv6BJAfM5yNeEM6BlpWcOyn7Pcd6Mk18RIpZR3aUeGTz/3L5mF 3oaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/eHg9l9Spros3WG/ZoZz0uKFq6WrSdE+qNQJXriOHqA=; b=VOG0Be1ZBxNUhEWUlnTCXEcgnanaDBjAiek2rXLIkZMBS7GMIXljP32ZNd/FEu4+hD ytRbWtC5aF9powhMJb6p4ff1v9AF6wziOwE1FSm4YqtzWBz+IY+nBiN1XuaLnZLNP4UV sxbYMXRe2jGq2eaxOPiQGMgsJz6ioGdOkOtOLrkJmmw3bo/RGjOOZ2nkT02ZzY9aGeux 2M3FcowK/mFR9ysaMl93Kz44D8xPrw7SHhSMYYl1BHZKE6WLD1+Zu8roCiLj0e9HLXlt 19CGr7McwX0ZrCm8iTChnk4eXNmiqaJivJ0Hyg4+IXMGl2bz8LDcYN5tHEmIzpa0fI4q emuw== X-Gm-Message-State: ACrzQf22l61Nrpz1fmZpt/CLb7VwRW9olamsdml1k1qIHnN7Qh5aKMYA hu9szqfQ0iw+2jK24T75AVi35w== X-Google-Smtp-Source: AMsMyM5G52U+lKCyotcswU3vFbTXFMyAFRfXefx3vsVFvJjPIBcrqn865PhADCDanoZOofnJnAbtjA== X-Received: by 2002:a05:6402:430a:b0:459:a049:76da with SMTP id m10-20020a056402430a00b00459a04976damr27455131edc.272.1665593516318; Wed, 12 Oct 2022 09:51:56 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id u18-20020a1709061db200b00782fbb7f5f7sm1530624ejh.113.2022.10.12.09.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 09:51:55 -0700 (PDT) Date: Wed, 12 Oct 2022 18:51:55 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Vadim Fedorenko Subject: Re: [RFC PATCH v3 1/6] dpll: Add DPLL framework base functions Message-ID: References: <20221010011804.23716-1-vfedorenko@novek.ru> <20221010011804.23716-2-vfedorenko@novek.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221010011804.23716-2-vfedorenko@novek.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_095200_618227_4B5E0FAA X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mon, Oct 10, 2022 at 03:17:59AM CEST, vfedorenko@novek.ru wrote: >From: Vadim Fedorenko > >DPLL framework is used to represent and configure DPLL devices >in systems. Each device that has DPLL and can configure sources >and outputs can use this framework. > >Signed-off-by: Vadim Fedorenko >Co-developed-by: Jakub Kicinski >Co-developed-by: Arkadiusz Kubalewski >--- [..] >+enum dpll_genl_status { >+ DPLL_STATUS_NONE, >+ DPLL_STATUS_CALIBRATING, >+ DPLL_STATUS_LOCKED, >+ >+ __DPLL_STATUS_MAX, >+}; >+#define DPLL_STATUS_MAX (__DPLL_STATUS_MAX - 1) >+ [..] >+ >+/* DPLL lock status provides information of source used to lock the device */ >+enum dpll_genl_lock_status { >+ DPLL_LOCK_STATUS_UNLOCKED, >+ DPLL_LOCK_STATUS_EXT_1PPS, >+ DPLL_LOCK_STATUS_EXT_10MHZ, >+ DPLL_LOCK_STATUS_SYNCE, >+ DPLL_LOCK_STATUS_INT_OSCILLATOR, >+ DPLL_LOCK_STATUS_GNSS, >+ >+ __DPLL_LOCK_STATUS_MAX, >+}; >+#define DPLL_LOCK_STATUS_MAX (__DPLL_LOCK_STATUS_MAX - 1) In addition to what I wrote in the previous reply where I suggested to have lock status independent on type or source, I think we should merge "status" and "lock status" to one attr/enum. Or any reason to have these separate? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel