From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98354C433FE for ; Sat, 15 Oct 2022 05:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KOeei1jbrWUN90MAtZx+EuLyBmM7bZe9eWTsKD3LpKM=; b=mY2CYPjz7yY9vv Yr0X2KleEQiEVmNT2h2BEbe1+Uy9oo0eXIz08Kdvum9YBo1S0VG9mKrfSaqPLv/KtOvZINE+5Oe+g QZQ461ZMXSRih4uxTJb8KlrUP6QkGVKcGFbb7L5lKFo2kW9A2OqDwqiUQvCc4uQGFgbebabCm1qYy i+cgGV+NlSAye34/RPiP/8FIRj5XnDRYg0neI8hGDQP8QYXOi+nM3dZKtwhBDSpIIgYicADLn5dIP OkvO/e61DwkYgGSR07wvCwzHMGhsQ2wMcyF6omXYpMgGTW8By3RZgjELR/9iW2xv2FBSrKqzSMenB 7sl4XdOXosuZYMBEMCfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojZJZ-00GS9c-A9; Sat, 15 Oct 2022 05:02:25 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojZJV-00GS8t-Mv; Sat, 15 Oct 2022 05:02:23 +0000 Received: by mail-ed1-x534.google.com with SMTP id m16so9331173edc.4; Fri, 14 Oct 2022 22:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wl1CNvTcx9C1NQyxDr1FjFvdKECNGo52b0NkbSv8Mmc=; b=eeEFSLmnT9lXGWLDZPg3qEuKFzVzewXktLASJcGO1yeOQa6W468Eyao+PTciOZro0O 2kkS6pAT9/AVx77VvqNTvHE5FGO3Ma4X2eB8v0Djy2ysj+mM7EcHDJjLfkX5SX4IB5f1 JSwiKxv7Q3KOuhfimSjLrcH25x3Xx243vfq0RyGeRF+rKjWi2Ex6/5rNx2cdkTAE/FGJ UEsFTLBMT59CeTFv2N3lO5vcT2QBDIHo6L1nfqEVgDGZXNSat69+Ytg29rd6VQkQIYwv UGBNL/0ewVnuAutYiUWuL04qQfK2isRdP6RfVwgIliEr+cb8XboD7YQDKbToOe03X+WN VSEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wl1CNvTcx9C1NQyxDr1FjFvdKECNGo52b0NkbSv8Mmc=; b=qE2uBSMoY76J7PRVnxF4+IK6JoNQKxbJQo9ixRbWxcUb0VBHhhZUtaStzncmdx6Kof 703pa3ZohBWZOBR0RtX5pMGEC607pGQ1G47mFkbLK5hBNm0dnHhSbdFRQkFFz1q4BNgJ 28b71WP5UQxqpCqZn3n7B3ViK3mlHRc+qxPL6T9C/zv9Du4DVCvYVoCG9iQlhBGSJkVj DAOduNq8wRCCiQZiEL54vpQsLIuiYegUmHumrRfBaE6wUoTo1dfhwPehx6/4e/pJSEIk TJ7bHgU/IUXQcmjG8JvLEmpgMFs4Oax6+zLaECkVMAKnJ3L7HLpJ1YzI9iKwAQEGpYyb bzAA== X-Gm-Message-State: ACrzQf04LfP+/Ucy7dFBj71gQ/rYFQlZRaYeM3/espyQG0pMVC7e0b2W GshmMbNB0XfMIhwEExKkTEY= X-Google-Smtp-Source: AMsMyM54Lfi2ufHuB3MBb1iQmFpjDzYeJlaCPnd3NnEocdemnj5EaHumfDM1UvRGifRen6uZM5nTKQ== X-Received: by 2002:aa7:c314:0:b0:458:dc90:467a with SMTP id l20-20020aa7c314000000b00458dc90467amr907854edq.284.1665810137987; Fri, 14 Oct 2022 22:02:17 -0700 (PDT) Received: from penguin ([57.190.1.13]) by smtp.gmail.com with ESMTPSA id q3-20020aa7da83000000b00458a243df3esm2999482eds.65.2022.10.14.22.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 22:02:17 -0700 (PDT) Date: Fri, 14 Oct 2022 22:01:53 -0700 From: Dmitry Torokhov To: Bartosz Golaszewski , Linus Walleij Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Alexander Stein , linux-kernel@vger.kernel.org, Daniel Thompson , Andy Shevchenko , linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 5/9] gpiolib: of: add a quirk for reset line for Marvell NFC controller Message-ID: References: <20221011-gpiolib-quirks-v2-0-73cb7176fd94@gmail.com> <20221011-gpiolib-quirks-v2-5-73cb7176fd94@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221011-gpiolib-quirks-v2-5-73cb7176fd94@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221014_220221_805057_F1D14D2B X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 14, 2022 at 10:54:29AM -0700, Dmitry Torokhov wrote: > The controller is using non-standard "reset-n-io" name for its reset > gpio property, whereas gpiod API expects "-gpios". Add a quirk > so that gpiod API will still work on unmodified DTSes. > > Reviewed-by: Daniel Thompson > Signed-off-by: Dmitry Torokhov > --- > drivers/gpio/gpiolib-of.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index 2b5d1b3095c7..5c11ee7638d1 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -390,6 +390,16 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np, > #if IS_ENABLED(CONFIG_MFD_ARIZONA) > { "wlf,reset", NULL, NULL }, > #endif > + > +#if IS_ENABLED(CONFIG_NFC_MRVL_I2C) > + { "reset", "reset-n-io", "marvell,nfc-i2c" }, > +#endif > +#if IS_ENABLED(CONFIG_NFC_MRVL_SPI) > + { "reset", "reset-n-io", "marvell,nfc-spi" }, > +#endif > +#if IS_ENABLED(CONFIG_NFC_MRVL_UART) > + { "reset", "reset-n-io", "marvell,nfc-uart" }, I just noticed that there is another compatible (not documented, so I assume it is a legacy one): "mrvl,nfc-uart", so I will be adding it and sending another version. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel