From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D969EC43217 for ; Sat, 15 Oct 2022 13:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=engnHV1SIFTTuK2TY3lVMoiyPbWhg7dAK4vHvuVpE24=; b=JMU tT970zHHYglT+YfwBmWg833/FWXilfYgcEExuUzp9dfYogcung5ldyL3irNS+U4Zv6/zCeoo99lo5 Clv+w0H+Cih3kGYTRBMmTyzH/9bRtRyGLlwmM3XceWEoBKX1rk5Kmv8HZ8DbHmRvZCHkFQsNxunvB lNNacfZp7arQAIFXMNVlfEYgm3x8ZYat4F62lgy5E080J7mKRrb4SgNmrEuIuyEd60SjWK1r2Yxqj tzlIHYzsJ/7N45uE9Xj1oibgr0M+W0V6Gg0AUvtZ33Mvq4EnSe5Wj7ZZGSFdnT5mbzBDIAEKj68yw hkXwhgSVUW0KuVbG6/o6v0o7orxupcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojhaf-00GzxT-Bs; Sat, 15 Oct 2022 13:52:37 +0000 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojhab-00Gzwy-Oz for linux-arm-kernel@lists.infradead.org; Sat, 15 Oct 2022 13:52:35 +0000 Received: by mail-qv1-xf2a.google.com with SMTP id i12so4963783qvs.2 for ; Sat, 15 Oct 2022 06:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=IhZYzWVwR6ANl8TItLFCTVvc5l7VLrZkeg3Uh0Vbwyk=; b=gsjfNn+p6OnKCF8XLHUC8jZQIRjKKFC+ezopPuukFVENvDNMRrxNaqyL87rpJtxuiA wQlRQ/1FivQJHBZuF45/PUxNnkLU5a3WR6eTF24bPjiroRN7naT0mq+V8y2hwSC9TOI6 Xd3m5b6uIiVgmVXCy/stFocisGqd9d1s/x10fK5KtVhJ73s9cbt1hH2+FeDl6eU/ngd0 iSE9WUwtXrOLvYiw5nYSMt4fJ1hg+oZdI4ldQ6VqQ0ita1Ql8KOwMScHt1kzoWnQ6/1l EFXYczKrEpDNGkoGf2Ul4Rex4AXF0ys2Be/sHZLFatIVN9b9/kkMSv6p2KjNlZGrW6Pu c91w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IhZYzWVwR6ANl8TItLFCTVvc5l7VLrZkeg3Uh0Vbwyk=; b=HJcDfyKnaSn0eLJIaVbb3OpDc6LVh/VTokzBXtbzM/LGjoQ70kPtzCHGxYQLHZaBbi PHRoxCAdW0OnW5/Sa6prDKjO/7cXj7stu8oKMd7YQnU/xjBJ3TUkbUjlgwtH0MMTLBrx BDzlEofTmzLsUN23PWMSIfa6PDp0v+sjTc1jl5O0l1L5z3B6ek6tJkDuYdRMoTU99aT4 miNe1pwXARLp1QGKH33QnWqW5d2dGOsZqdYoD3+CHqqA/k435heBVH9bzO5Xdn7ns6UR 1gPCpBIw1EJnX6w9Y9dUd1HxlvRbHaLBwuUEI9x6xH7Yvzu7qO6WrlkPadhQFkYvgQ4W x6ug== X-Gm-Message-State: ACrzQf0bFj/4FNS9kXN8yWerpl+tJp7V/MDep8AscwPdtTWiPtI3z9yh RBL2ecP7Hw7VA60fVEryp9RI+A== X-Google-Smtp-Source: AMsMyM6hxxmI7Q4/FtTi2vQ9QmdL87HBnnKD4IAULJIaLwwAHWL55GATer7qvk5v0YyLJ5LTiRdF+w== X-Received: by 2002:a05:6214:ac4:b0:4af:b60f:5c7a with SMTP id g4-20020a0562140ac400b004afb60f5c7amr1950407qvi.60.1665841951523; Sat, 15 Oct 2022 06:52:31 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id v6-20020ac87286000000b0038b684a1642sm4002250qto.32.2022.10.15.06.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Oct 2022 06:52:30 -0700 (PDT) Date: Sat, 15 Oct 2022 09:52:27 -0400 From: William Breathitt Gray To: kamel.bouhara@bootlin.com Cc: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org Subject: Handling Signal1 in microchip-tcb-capture Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221015_065233_852690_206A29EF X-CRM114-Status: UNSURE ( 9.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1400264604201322269==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1400264604201322269== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xdpWHHg+Grftu4HJ" Content-Disposition: inline --xdpWHHg+Grftu4HJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello Kamel, I was looking over the microchip-tcb-capture driver recently and noticed that the code doesn't seem to account for Signal1. In particular, it appears that mchp_tc_count_signal_read() and mchp_tc_count_action_read() don't check the Signal id at all and just assume they are handling Signal0. This creates a situation where the information returned for the Signal1 sysfs attributes are just duplicated reports of Signal0. What exactly is the relationship of Signal0 ("Channel A") and Signal1 ("Channel B"); is SignalB only relevant when the counter device is configured for quadrature mode? Sincerely, William Breathitt Gray --xdpWHHg+Grftu4HJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY0q7GwAKCRC1SFbKvhIj K5XSAP91pKrMRiRL0thwmoh+oTH7pTvGzSAMJwnNfp4R1z64ngD/f0L02GHAQ8Py KCXvfa2xmxmNEZpahfOaZwm82LdozQU= =EAuO -----END PGP SIGNATURE----- --xdpWHHg+Grftu4HJ-- --===============1400264604201322269== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1400264604201322269==--