linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
	broonie@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: entry: Fix typo
Date: Sat, 29 Oct 2022 20:35:49 +0700	[thread overview]
Message-ID: <Y10sNSE6/B2p95+I@debian.me> (raw)
In-Reply-To: <1667027268-1255-1-git-send-email-quic_mojha@quicinc.com>


[-- Attachment #1.1: Type: text/plain, Size: 4329 bytes --]

On Sat, Oct 29, 2022 at 12:37:48PM +0530, Mukesh Ojha wrote:
> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
> index 9173fad..b694d8f 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -30,7 +30,7 @@
>  /*
>   * Handle IRQ/context state management when entering from kernel mode.
>   * Before this function is called it is not safe to call regular kernel code,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   *
>   * This is intended to match the logic in irqentry_enter(), handling the kernel
>   * mode transitions only.
> @@ -63,7 +63,7 @@ static void noinstr enter_from_kernel_mode(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when exiting to kernel mode.
>   * After this function returns it is not safe to call regular kernel code,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   *
>   * This is intended to match the logic in irqentry_exit(), handling the kernel
>   * mode transitions only, and with preemption handled elsewhere.
> @@ -97,7 +97,7 @@ static void noinstr exit_to_kernel_mode(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when entering from user mode.
>   * Before this function is called it is not safe to call regular kernel code,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   */
>  static __always_inline void __enter_from_user_mode(void)
>  {
> @@ -116,7 +116,7 @@ static __always_inline void enter_from_user_mode(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when exiting to user mode.
>   * After this function returns it is not safe to call regular kernel code,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   */
>  static __always_inline void __exit_to_user_mode(void)
>  {
> @@ -152,7 +152,7 @@ asmlinkage void noinstr asm_exit_to_user_mode(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when entering an NMI from user/kernel
>   * mode. Before this function is called it is not safe to call regular kernel
> - * code, intrumentable code, or any code which may trigger an exception.
> + * code, instrumentable code, or any code which may trigger an exception.
>   */
>  static void noinstr arm64_enter_nmi(struct pt_regs *regs)
>  {
> @@ -170,7 +170,7 @@ static void noinstr arm64_enter_nmi(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when exiting an NMI from user/kernel
>   * mode. After this function returns it is not safe to call regular kernel
> - * code, intrumentable code, or any code which may trigger an exception.
> + * code, instrumentable code, or any code which may trigger an exception.
>   */
>  static void noinstr arm64_exit_nmi(struct pt_regs *regs)
>  {
> @@ -192,7 +192,7 @@ static void noinstr arm64_exit_nmi(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when entering a debug exception from
>   * kernel mode. Before this function is called it is not safe to call regular
> - * kernel code, intrumentable code, or any code which may trigger an exception.
> + * kernel code, instrumentable code, or any code which may trigger an exception.
>   */
>  static void noinstr arm64_enter_el1_dbg(struct pt_regs *regs)
>  {
> @@ -207,7 +207,7 @@ static void noinstr arm64_enter_el1_dbg(struct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when exiting a debug exception from
>   * kernel mode. After this function returns it is not safe to call regular
> - * kernel code, intrumentable code, or any code which may trigger an exception.
> + * kernel code, instrumentable code, or any code which may trigger an exception.
>   */
>  static void noinstr arm64_exit_el1_dbg(struct pt_regs *regs)
>  {

What about "... it is unsafe to call regular kernel, instrumentable, or
any other code ..." instead?

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-29 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29  7:07 [PATCH] arm64: entry: Fix typo Mukesh Ojha
2022-10-29 13:35 ` Bagas Sanjaya [this message]
2022-10-31 11:50   ` Mark Rutland
2022-10-31 11:48 ` Mark Rutland
2022-11-08 17:38 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y10sNSE6/B2p95+I@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=quic_mojha@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).