From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 819A3C38A02 for ; Sun, 30 Oct 2022 09:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ourMYzfOIZvz6W1XS86taPQT31k0WtJ+OBguqfs5vXE=; b=pZyWOZCjrmZse6 a/pZARB834NRjXIJqNZFLvP4RfeweptDFbZrCYQFqNZeyWK/cIMmkEuEw/YUH9+HL6ZrLb8q1LKF+ IxaMwHQ2C3QrqV4QEWU2Ih5yZTVn2kOcRLzmEBQOpE8AbDkfCumLQKkniKxRRtFLVd/iDbrRB4l5F acrwCh9b8a1Rz+tGSP4bJVJa8hfui71jYP2Cmrc/skuRrv0asAp7mlNDFws3k3oMyOOGzxlX2vNO6 tobnqIoxvhi+VUr3Znifne/a04z1BAAV3JQJ9cMzzEPCd3nLXTZf1SRPnbzc7nt71mhgPQzq8PWWv O7GCKAHmhLHzcOjjaJmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1op4Ck-00EXnr-P6; Sun, 30 Oct 2022 09:02:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1op4Cf-00EXj6-TW for linux-arm-kernel@lists.infradead.org; Sun, 30 Oct 2022 09:02:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 511DD60E95; Sun, 30 Oct 2022 09:01:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30DA7C433C1; Sun, 30 Oct 2022 09:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667120517; bh=sas7Li8v8Fy8iS/StTY7RBsjDeKY9mn9FYsPpc0Ypyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xxud9PzOQ2g3QEKoQyGgd189RK9wsEM9nTW272qdtcSux+Hf4uwwYkRXXfWdYj0O5 Z1k4UWQKpVVkTL/2/B/s9eDUwziWDqa4uxIZsF5c5F3Zxh5p5HadVqgOSHXjhf4+L1 ENhUECTHvE+yTG4OVaRvbpnnRISMbVS0wMK0wJYk= Date: Sun, 30 Oct 2022 10:02:53 +0100 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Catalin Marinas , Linus Torvalds , Arnd Bergmann , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Isaac Manjarres , Saravana Kannan , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] treewide: Add the __GFP_PACKED flag to several non-DMA kmalloc() allocations Message-ID: References: <20221025205247.3264568-1-catalin.marinas@arm.com> <20221025205247.3264568-3-catalin.marinas@arm.com> <20221030084718.GC5278@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221030084718.GC5278@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221030_020202_024544_491A5EC2 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 30, 2022 at 09:47:18AM +0100, Christoph Hellwig wrote: > On Fri, Oct 28, 2022 at 11:37:52AM +0200, Greg Kroah-Hartman wrote: > > And here's actually the patch... > > How is this supposed to work? noderef means any dereference of it will > now make sparse complain. And the whole point of the DMA is to get > data into and out of the system, so except for corner cases like direct > DMA to userspace (which won't use kmalloc) we absolutely do want to > derference it to generate or consume the information. Ah, my fault, sorry, you are right. Is there a sparse tag that just means "enforce this void * type?" I guess we could do that with something like: typedef void *dmaptr; but that feels icky. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel