From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86C3DC433FE for ; Wed, 19 Oct 2022 16:03:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JqphXXzghv6yA+BNYuQ7PCKhS6iCabDIJolauNEAzSs=; b=0CMUhyZcsNgwIU ppjAocVeIIC8NEk11y4JHtRc7FCElDFOqGlPxQU9z2VxsZQrJQE2U78jeRx5a5vFYhyRaWdUb4Xav 5PCR7VY/aw88pKpQq+oZ6Vjv1VRsPkF4Bl8devB7xrsD9+9dwwWU6YIRvwU4fus/hqgrKMhCHeynL LR/iscqtGDNAjfCkJ235S88yJkEizerwX8Y4U85qdxrg60kDTX8BR4G53hwKJG/KJfKyEizDDEQEA 5j1PSx9M3/DKic4vCLtglZ/hxhcCpDqHL/wR00W5Vo30vW4EotbbFhlamHbDYD5FmSptffc1jqtqV Tup5IMiY75mr96SeDwKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olBWd-003eaq-Pa; Wed, 19 Oct 2022 16:02:36 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olBHM-003Sq8-KF for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 15:46:49 +0000 Received: by mail-ed1-x529.google.com with SMTP id s30so25898012eds.1 for ; Wed, 19 Oct 2022 08:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9QpxLQA9XPUewEHX/45h//HdR2yIq/tEj/1YezYLDX0=; b=OWfE59Lm25mCNlUki8tYQIpUSzerqalC7O2lwMJbqbJNcMshIS0djoedpTUK3TZSk5 vjtbeWT1tsd30RniseB4tzfWIOdzRkhXri/Wn8EkdKlObaRi32pCsC5okls3TNRRZ6AY D6TjFM3rivU1wrjwvfpg5wwk1aJoE0AR5fKN+FZsbFhQgBiGqBfZcPVGw3ATORhJPFKo KmTOY9vsP8q1F3KG1iaxKlnX086MmeaF/+96jCElljjEUU8MZ2Wn0thjnPKz/d3+Lytd SQkcVPoAXkb0N0WsnuXEtW7sar/4IfozdyR1MBF3TUR2WoXft7UPyzke5wzbYTuvrbtV cwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9QpxLQA9XPUewEHX/45h//HdR2yIq/tEj/1YezYLDX0=; b=IjsMNLvaCFOKXWZcAs8zq5WHsybLSzyM0/m6TYs9NtSYDuLV3VgffzhcR23srDyarz deb0O93NqY5UKL2jAPVSH48QqbKISdDEvTBztbZ7S+lStNOfQL0qIrgjw46i4JhitC9S XOy97GvzvuhPVNpFQoFmkXhsyit022+FeyAFb1yX5XHjMHkaTTWlxt/EO1lXfZeh1dm+ dtwBrB8Bad4qSYYAqWODlvF1lSkIFnzcxqCCv84jumf2KivHAkd0HHuheJZKdvX7LcsX iPa+5b6eP3xyTRcQW6n2w8yMiJzuD+Lu/UGeQ/nvbhgKRjLLzinRbHuBdteSWPLdjdfG g6mg== X-Gm-Message-State: ACrzQf1ZzwHUB3JILMQH8tyxTK0q82yKo5Br4rpwYq85Klusrt7sWXb4 Ft0rbSIgDnvX9Flogunzojx7FA== X-Google-Smtp-Source: AMsMyM6AYcdOgw2iQ49E1qfbw3hHt9myuk+HR8W4QyF6ds15StyGev6O3Li7L6vCvN9o9x7j74tUgg== X-Received: by 2002:a05:6402:2989:b0:44e:90d0:b9ff with SMTP id eq9-20020a056402298900b0044e90d0b9ffmr8039042edb.110.1666194401367; Wed, 19 Oct 2022 08:46:41 -0700 (PDT) Received: from google.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id p5-20020a170906498500b0078b83968ad4sm9075070eju.24.2022.10.19.08.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:46:40 -0700 (PDT) Date: Wed, 19 Oct 2022 15:46:37 +0000 From: Quentin Perret To: Will Deacon Cc: kvmarm@lists.linux.dev, Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , James Morse , Chao Peng , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 13/25] KVM: arm64: Instantiate pKVM hypervisor VM and vCPU structures from EL1 Message-ID: References: <20221017115209.2099-1-will@kernel.org> <20221017115209.2099-14-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221017115209.2099-14-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_084648_700061_506BA4C8 X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 17 Oct 2022 at 12:51:57 (+0100), Will Deacon wrote: > +struct kvm_protected_vm { > + pkvm_handle_t handle; > + struct mutex vm_lock; > + > + struct { > + void *pgd; > + void *vm; > + void *vcpus[KVM_MAX_VCPUS]; That's memory that's 'wasted' for everyone :/ > + } hyp_donations; > +}; > + > struct kvm_arch { > struct kvm_s2_mmu mmu; > > @@ -170,10 +181,10 @@ struct kvm_arch { > struct kvm_smccc_features smccc_feat; > > /* > - * For an untrusted host VM, 'pkvm_handle' is used to lookup > + * For an untrusted host VM, 'pkvm.handle' is used to lookup > * the associated pKVM instance in the hypervisor. > */ > - pkvm_handle_t pkvm_handle; > + struct kvm_protected_vm pkvm; Maybe make this a pointer that will be !NULL only when pKVM is enabled? > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel