From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DA19C4332F for ; Wed, 19 Oct 2022 21:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IxyvAGkwIgt+GbIwuflilo+Ua3a1q8Bysat/NnZf6Ew=; b=fSd1HszLtpZchR 18hHquRcG3sAYHw/6+EKggNZtNgyRuHjkAhU7F9Odj35GwG/AWeZLECEe0U/g/nIxSQ/hd5iQ4OUk IvZ2tj5CIaiINFsXTmLEbtTsZsiigGUvxtQIciNGzMC4HwgvzFrced0a/t3lV3Vcpp0pJwXaR81gF 4Lxff9ZYb6NPRsiNpWiFaBiSVpuKOjgFL2OUk8A6q57HWF0/9XenQS4KlOAsKCgxfApk4/q76LP3F j/K1vrki/WQigdlZL3LIpJvZGHDoLGHxYYXTAuzfJIHi6HpcgxmIDhA/FDkJa3lfThIQMtSaG8J3k FlbgrhPEW+VOmXiOTg5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olH3b-005NJw-CS; Wed, 19 Oct 2022 21:57:00 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olH3V-005NF2-Fg for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 21:56:54 +0000 Received: by mail-pl1-x62b.google.com with SMTP id o21so16113303ple.5 for ; Wed, 19 Oct 2022 14:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y2aRiLyWvRUlvRE5N2MJoq49Gk7v0uQF4nuK/XgZXeI=; b=j5cM3oTJaW15wbf1WDQR3SG+HiIfE1NeKieuBFlF7niQeo5PlkEIsOSBaAY03P6xZP ETODBU7scJhRAAluN542ojdhne1x/nh1U/HMr82A9r6wuZfSoRE3n+5RQ0yOG+/q8KEc 4NrTwpgxy1Ua18JHIzBXlJzTeWF8b2JARfIVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y2aRiLyWvRUlvRE5N2MJoq49Gk7v0uQF4nuK/XgZXeI=; b=DajUIiAB+SDZGwcBMmD6hBOdOCoaPWwJDq9wkTqGDqCHSbb5pU+MFYGtPD5B8/83AY WwPXAI0cnUoLPB8vcttaCtD3a+BPeosF1GW0BpHnSagjA7rUSsUDCtKpXZWOszl6RgwF vWUKW8/oH1yUZgtJ8RD0qZw3UCXoQmtGWHQSAtImCHQji0/q7HbeXJQ9afOSeKpkoLHV v5qHhjwr5xiT/9b4XYvkitzV0vWJTNRN6NMMI267oOvQZo0MrInY1EN1yMg6agfPa/KX ft4JjMI1B3/kn0mUKkhtCuL2AvzRIbgZUkcUQ4n3PlYCaV7Ci7/KO3XW0tpqb/xt4TKP NP8g== X-Gm-Message-State: ACrzQf1zgAwReqIcAyPFZTduOXvnE4U+AeVa/PegmfHaohXNEHZB2NTa 0O2X9zH72T1wjSv3fXQXiJUYyw== X-Google-Smtp-Source: AMsMyM6ZnXir4B36pdQVeqzQ6UMoGGdhfhXA7wKzmHS2lucDmHeECMGKp4r+5S3L3wGAnnQEh559Xw== X-Received: by 2002:a17:90a:aa8f:b0:210:bec0:bde with SMTP id l15-20020a17090aaa8f00b00210bec00bdemr2814613pjq.109.1666216611530; Wed, 19 Oct 2022 14:56:51 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:57b7:1f0e:44d1:f252]) by smtp.gmail.com with ESMTPSA id s6-20020a625e06000000b00562bc93f1c9sm11793504pfb.213.2022.10.19.14.56.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 14:56:51 -0700 (PDT) Date: Wed, 19 Oct 2022 14:56:48 -0700 From: Brian Norris To: Bough Chen Cc: Ulf Hansson , Shawn Lin , Adrian Hunter , Shawn Guo , Fabio Estevam , Faiz Abbas , dl-linux-imx , Al Cooper , "linux-mmc@vger.kernel.org" , Pengutronix Kernel Team , "linux-kernel@vger.kernel.org" , Florian Fainelli , Sascha Hauer , Thierry Reding , Michal Simek , Jonathan Hunter , Sowjanya Komatineni , "linux-arm-kernel@lists.infradead.org" , Broadcom internal kernel review list Subject: Re: [PATCH 3/5] mms: sdhci-esdhc-imx: Fix SDHCI_RESET_ALL for CQHCI Message-ID: References: <20221018035724.2061127-1-briannorris@chromium.org> <20221017205610.3.I7d01f9ad11bacdc9213dee61b7918982aea39115@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_145653_564125_8943EC1F X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Oct 18, 2022 at 07:22:04AM +0000, Bough Chen wrote: > > -----Original Message----- > > From: Brian Norris > > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > > @@ -1288,6 +1288,13 @@ static void esdhc_set_uhs_signaling(struct > > sdhci_host *host, unsigned timing) > > > > static void esdhc_reset(struct sdhci_host *host, u8 mask) { > > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > > + struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host); > > + > > + if ((host->mmc->caps2 & MMC_CAP2_CQE) && (mask & SDHCI_RESET_ALL) > > && > > + imx_data->socdata->flags & ESDHC_FLAG_CQHCI) > > I think we can remove the condition " imx_data->socdata->flags & ESDHC_FLAG_CQHCI" here. > According to code logic, host->mmc->caps2 & MMC_CAP2_CQE means it already contain imx_data->socdata->flags & ESDHC_FLAG_CQHCI I don't know why I had this in the first place. Maybe just to be double-sure that caps flags aren't getting set elsewhere (e.g., by the core)? But you're right, and I've dropped this in v2. Thanks, Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel