From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Cc: Kartik <kkartik@nvidia.com>,
jonathanh@nvidia.com, windhl@126.com, sumitg@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc/tegra: fuse: Export tegra_get_platform() & tegra_is_silicon()
Date: Thu, 20 Oct 2022 11:54:04 +0200 [thread overview]
Message-ID: <Y1EavIxVymPSfwJC@orome> (raw)
In-Reply-To: <1664186759-9821-1-git-send-email-kkartik@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]
On Mon, Sep 26, 2022 at 03:35:59PM +0530, Kartik wrote:
> Functions tegra_get_platform() and tegra_is_silicon() are required
> for pre-silicon development to correctly identify the platform on
> which the software is running.
>
> Export tegra_get_platform() and tegra_is_silicon(), so they can be
> used for pre-slicon development of device drivers and kernel space
> tests.
>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
> drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 ++
> 1 file changed, 2 insertions(+)
Hi Arnd, Olof,
can you take a quick look at this and provide some feedback regarding
acceptance? It's slightly unorthodox because the only in-tree users of
these functions are built-in drivers and early code, so they don't
technically need to be exported for strictly in-kernel users. However,
we do see these used quite frequently in pre-silicon development and
having these available upstream would help with internal kernel
transitions and so on. We may also see them used more commonly in
upstream drivers in the future.
Thierry
> diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> index 3351bd872ab2..904797f651a1 100644
> --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
> +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> @@ -56,6 +56,7 @@ u8 tegra_get_platform(void)
> {
> return (tegra_read_chipid() >> 20) & 0xf;
> }
> +EXPORT_SYMBOL(tegra_get_platform);
>
> bool tegra_is_silicon(void)
> {
> @@ -76,6 +77,7 @@ bool tegra_is_silicon(void)
> */
> return true;
> }
> +EXPORT_SYMBOL(tegra_is_silicon);
>
> u32 tegra_read_straps(void)
> {
> --
> 2.17.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-20 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 10:05 [PATCH] soc/tegra: fuse: Export tegra_get_platform() & tegra_is_silicon() Kartik
2022-10-20 9:54 ` Thierry Reding [this message]
2022-10-20 9:57 ` Arnd Bergmann
2022-10-20 14:06 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EavIxVymPSfwJC@orome \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sumitg@nvidia.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox