From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E588EC433FE for ; Thu, 20 Oct 2022 09:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L7B7xyGNMx4NZ0xaLOjbogYOGho9/wFtulZAQJtbguY=; b=d/MCQ9ItC7ZyZKK8dleh468I7l qh5N1yxTyqkSWqBQAsNO2pVuvbMAQTZsR9GNtvi24MNjrl5G6nGOEGo0ss2/3x4YfJk2B2ElW6kIm 9lR/XKMD/+4v8XVjd9zk+kHorEjcFCNZ0vocLMB3FUwIysJL8BFFc6hX+kpVs14S0HbjsK+fpFKd9 ry3aTyVIlcpRPJ1TABrVhAoyYr0EBKIskDJo6MTgbYLFsrfduueN2xDhFPV48pcIJVd4ig58rWeG0 PqCjK+HOmsq0HozPR12V2OL/5tomaGHZf6dlDBKqiKzkPlBRHwnEbczBVcqfQ686PTsxLO9mKakhT 31BoCYKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olSFh-00DCVE-Rz; Thu, 20 Oct 2022 09:54:13 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olSFf-00DCTO-63 for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 09:54:12 +0000 Received: by mail-ed1-x52e.google.com with SMTP id s30so29103655eds.1 for ; Thu, 20 Oct 2022 02:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qV+BhU4+eXmpbQ5EMlBERw33VBGYIV/n2IV6kgz4qs4=; b=Y8kY0+W7tAFL4p4oF9BMEabmjjxrUnQfhNH4j6smaKv2UddIFYLR5qktsADgmXJ7MX LcsMBoKIna5vbjZMNDZdralmG1EC6p3UxhEu02n2lB6KORlQNMQDotsTWQGG7DCGqzqL dH+qiPymZbq4LuiqJzeaAD7ljyjD1JQDNvwAaLi74caq05GUOwMuLYGQol5f9vdpxFHB JUPlzKQcmmlbD6RZ+vNPjH6o1wf5WBL+hvPAHruDrpkDNkJndXCNUtk0yQIUQzgRU3in 4fbVIxe5DpkF9eV/Y66JKt6rvkjJUcXxWU8HU8bIh9JI4RJbO0XLKnLDzQtMZwabrcAo fDSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qV+BhU4+eXmpbQ5EMlBERw33VBGYIV/n2IV6kgz4qs4=; b=RMHC6UQUsJYtI1YffwFYxPZY1FfC5fQvSPV5pYwlwrjGY8EVKOIHO067tSYTiANrrb yU11Ut9YLpMvGwv3e9q16TCswRiDVWFVKvVZ0+AjB+HFfQDX0iYpWZ+cQC63vzFKF6Qb eVZ/SBr2EdiUTsTER/ncuoPvaFIVb/J+aJ2QlSKhTo+AxArx3hYGH/t5nTCUEsQE3NBj 5wFUSmPVR661dsxk+1umeEtw5TyOLX10mVXHADn+H/xKLtKNHyYN7mvQ2cIJZSz7ajBZ kzWDCXGYe1SawkdDrTsBf4IISiagjnDN78vpx2VNXzP3X35cY9xj28Nk3iRmr12iyt6T eYdg== X-Gm-Message-State: ACrzQf2wPQjWfM1a1X473seZaMGgg075UE/WK/FzJdBjeqwNO1ig2we4 ulVt+xzGmn48eJyMgSh8y08= X-Google-Smtp-Source: AMsMyM6tvYDFR1I556ogk2L3YeWTWwy+Bi+Z3BcWJgPiTyUi6JHt++CVuVYZJleZyH9COy5I4Q3IFg== X-Received: by 2002:a05:6402:518b:b0:45d:9a19:66d2 with SMTP id q11-20020a056402518b00b0045d9a1966d2mr11272878edd.43.1666259647774; Thu, 20 Oct 2022 02:54:07 -0700 (PDT) Received: from orome (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id b6-20020a056402138600b00457b5ba968csm11835744edv.27.2022.10.20.02.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 02:54:06 -0700 (PDT) Date: Thu, 20 Oct 2022 11:54:04 +0200 From: Thierry Reding To: Arnd Bergmann , Olof Johansson Cc: Kartik , jonathanh@nvidia.com, windhl@126.com, sumitg@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] soc/tegra: fuse: Export tegra_get_platform() & tegra_is_silicon() Message-ID: References: <1664186759-9821-1-git-send-email-kkartik@nvidia.com> MIME-Version: 1.0 In-Reply-To: <1664186759-9821-1-git-send-email-kkartik@nvidia.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_025411_240086_6D5D8044 X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8434773907635350384==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8434773907635350384== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="csjkOe4a4bB5CbtM" Content-Disposition: inline --csjkOe4a4bB5CbtM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2022 at 03:35:59PM +0530, Kartik wrote: > Functions tegra_get_platform() and tegra_is_silicon() are required > for pre-silicon development to correctly identify the platform on > which the software is running. >=20 > Export tegra_get_platform() and tegra_is_silicon(), so they can be > used for pre-slicon development of device drivers and kernel space > tests. >=20 > Signed-off-by: Kartik > --- > drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 ++ > 1 file changed, 2 insertions(+) Hi Arnd, Olof, can you take a quick look at this and provide some feedback regarding acceptance? It's slightly unorthodox because the only in-tree users of these functions are built-in drivers and early code, so they don't technically need to be exported for strictly in-kernel users. However, we do see these used quite frequently in pre-silicon development and having these available upstream would help with internal kernel transitions and so on. We may also see them used more commonly in upstream drivers in the future. Thierry > diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/f= use/tegra-apbmisc.c > index 3351bd872ab2..904797f651a1 100644 > --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c > +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c > @@ -56,6 +56,7 @@ u8 tegra_get_platform(void) > { > return (tegra_read_chipid() >> 20) & 0xf; > } > +EXPORT_SYMBOL(tegra_get_platform); > =20 > bool tegra_is_silicon(void) > { > @@ -76,6 +77,7 @@ bool tegra_is_silicon(void) > */ > return true; > } > +EXPORT_SYMBOL(tegra_is_silicon); > =20 > u32 tegra_read_straps(void) > { > --=20 > 2.17.1 >=20 --csjkOe4a4bB5CbtM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNRGroACgkQ3SOs138+ s6FwXg//WryMEFn2nVhGG7yvCvBIuN0FbNxCLzcnvYvT5tvMc82WFe7CTMBIbhHv mBFCjYGq2McKAu9u3lyXkmVBrn8+9IeZhux7oNbABG1UYDBBcW9dFf1lfCi4B47/ IpQJHFggZo62o+wHGJa9+d+8I+18HN1CV/4veMCDetByllqRtXVEVaS/uFvwdbaE VSw2PbBUaVgk5EUMCE90TUn8iaxCkvdqL/zWVityx9ASPPZZQDhz5hmpCgLX5+Vb +C5/Vh6PwSEYV+Pb+bDzjS50ugtPVoLjGwYNr6gLw6n/LyEZdxEoMzqKWFtQDdsy cX8Qa5JC+1mslU1FO7FhjZbyOk7C5VFk+uYRsFhnQB+QBGCFTQCjsd1am9pnktAk Ocdo0wNCAW996RQkjHBwrK7fVMuRmDfAV4oMEzgC8k2233QfM8g7sD4DnaSzEt+I k6EJikmS0JX6um+UxTQicXg6Gkmauz+rj/6Nv8kPGDavQGZIUiZ9HSMunzRo9n5t /9CTtyzZT+XcAgCzODqw+kVA1WiVacPVG4zzV/xftrwo8RWeXEBQl3emS87VCrIS OHEkxSxp0uIYCwDz9x7uSfDU5Qy0EugWZy5rgGFGufmubknLw5YsV1GKLdpcxig3 THyk91RGltq+ysoMKRE2I/ebUjsPQXs5jClKEGFk/9klcOGhO8E= =AN8t -----END PGP SIGNATURE----- --csjkOe4a4bB5CbtM-- --===============8434773907635350384== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8434773907635350384==--