Re: [PATCH v8 net-next 02/12] net: bridge: add blackhole fdb entry flag

Jakub Kicinski
2022-10-24T17:09:14Z

On Sun, 23 Oct 2022 07:32:02 +0200 netdev@kapio-technology.com wrote:
> >> @@ -1140,7 +1148,7 @@ static int __br_fdb_add(struct ndmsg *ndm,
> >> struct net_bridge *br,
> >> err = br_fdb_external_learn_add(br, p, addr, vid, true);
> >> } else {
> >> spin_lock_bh(&br->hash_lock);
> >> - err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, nfea_tb);
> >> + err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, ext_flags,
> >> nfea_tb);
> >
> > I believe the preference is to wrap to 80 columns when possible.
>
> Very strange... since I ran checkpatch.pl from the net-next kernel
> itself and it did not
> give me any warnings about 80 columns, but rather said 'patch is ready
> for submission'.
>
> As this is silent, could it be some missing python plugins or something
> to do with perl?

I run:

./scripts/checkpatch.pl --strict --max-line-length=80