Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

From: Conor Dooley <conor.dooley@microchip.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "kernel test robot" <lkp@intel.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	linux-pci@vger.kernel.org,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	llvm@lists.linux.dev, "Minghuan Lian" <minghuan.Lian@nxp.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
	"Toan Le" <toan@os.amperecomputing.com>,
	linux-riscv@lists.infradead.org,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Joyce Ooi" <joyce.ooi@intel.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Ray Jui" <rjui@broadcom.com>,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
	"Michal Simek" <monstr@monstr.eu>,
	kbuild-all@lists.01.org, "Scott Branden" <sbranden@broadcom.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	linux-kernel@vger.kernel.org, "Tom Joseph" <tjoseph@cadence.com>,
	linuxppc-dev@lists.ozlabs.org, "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
Date: Thu, 20 Oct 2022 14:52:48 +0100	[thread overview]
Message-ID: <Y1FSsFKKJDzzrf8C@wendy> (raw)
In-Reply-To: <20221020134547.GA94120@bhelgaas>

On Thu, Oct 20, 2022 at 08:45:47AM -0500, Bjorn Helgaas wrote:
> [+cc Pali, heads-up for trivial addition of <linux/irqdomain.h> to
> pci-mvebu.c]
> 
> On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote:
> > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote:
> > > Hi Bjorn,
> > > 
> > > I love your patch! Yet something to improve:
> > > 
> > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain'
> > >            struct mc_pcie *port = domain->host_data;
> > 
> > That's what I get for only visually inspecting the patch before Acking
> > it.. Un-ack I suppose.
> 
> No problem!
> 
> I think what happened is the pcie-microchip-host.c uses
> irq_domain_add_linear() so it needs <linux/irqdomain.h>, but it
> currently gets it via <linux/of_irq.h>, which it doesn't otherwise
> need.
> 
> I added a preparatory patch to include <linux/irqdomain.h> explicitly,
> but I haven't been able to cross-build either riscv or ia64 to verify
> this fix.  I'll wait a few days and post an updated series for the
> 0-day bot to test.

I saw you saying you couldn't find the config from LKP, FWIW a build
using riscv defconfig w/ CONFIG_PCIE_MICROCHIP_HOST=y fails for me
in the same way as lkp reports.
Otherwise, dump the patch in response to this and I'll give it a shot
later if you like?

HTH,
Conor.

> 
> Same situation for pcie-altera-msi.c.
> 
> pci-mvebu.c also relies on getting <linux/irqdomain.h> via
> <linux/of_irq.h>, but it actually depends on of_irq.h, so I'll just
> add an irqdomain.h include there.
> 
> Bjorn
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel