From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A4C0C433FE for ; Fri, 21 Oct 2022 10:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ULTalOuYaMQj96CM3RxmFM145EBrxE8vUnl/ROKx82Q=; b=HkvGXXT4PSTd/D 9ufpy6SgJDOIxhW6069C8PyfvYY6Q2Fh4Ir125cBE/PgnSCvTawANgn8ZcxcdtzwULqim/a9hI9E8 8HyCFRdtgjOO4rvM1y6S4PLv2CnGnSy6RBxTz9w/lzi5sCnN7AuYDvm76CmTagZMrw6/GzMhP/9j6 h1/1GFWQyA+JJ6PrrkFu4JSD9/l1xjJSBx0mqJb7r2iwr4kok5qMEzh/y0dIKDm/gUEhC0Zf08BoR O6GhByRHR3dkBxlWKvID3uFF/yLSHNmmy8b1xHLJcQgyySyfwAGD/3PQbamCLidycUNMhZhTfjuTa u4PoLaeFmdIBBNlogblQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olpJJ-0075wi-TA; Fri, 21 Oct 2022 10:31:30 +0000 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olpJG-0075vK-4w for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2022 10:31:27 +0000 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29L7nHsv010688; Fri, 21 Oct 2022 10:31:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2022-7-12; bh=WDGEraxamDCmOrIGgvSkBQMXCkBzp9GsQG0cTZcK6Vc=; b=Z9HDgLeWw6IIEr4MkUJMuuYtdddEOM4rg/+dY7l2LDETm5zo6q7Dd3tPhIUDAIPSuul+ uc/7/C3Bnw9yJCT3+rDS+6OML1Vj2e/jkP0XlA1GBoKuA6aDVADd/HumQ4PBbu5kcnuU TTTj3WUjyfvz7usbNC7zxOddDXHUw/bSEVS8rlX0M2IpgG9w/gpNuR2pzW8P2XOmCfqJ 8hjKZJfKmn7XWkaRG799uKqFSCpwr6hmeAEfi7oIlVJRwL0WUEba9Qb2WKr8+odKH3Os lyEzjkapNkBernkXwVxWg0ZK8olysCKstWCOJN6Ioxb77teyM+gE+Uqw9Z66jGR4uOZv Mg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k99ntm50b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Oct 2022 10:31:20 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 29L8LrO5007262; Fri, 21 Oct 2022 10:31:18 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3k8hrdqtw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Oct 2022 10:31:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jt1kbHNaT5l5lS/8XA+9lWmmTsrbPvEqsE3wv9pOlI1DF3OoDaOafwNDr71ETJklUiu+g7VaPoOBrYXROqlGHl0+lzsMUbrFYo0/FgxBsF0rC3HvLOmQHlXAP2MiqyVeAlrz7Hxwr3OT8vyaERd+MApjQrC0sl3wbs8Qwshpt8igN4VO1/4nT7eq0sNN29cX25y4rTm93ai7cX0b3GXDuHRRj6n7BAn/t2k98Ukta/jWqCRQS/p5EbfvXNj8JCILB2gQpIU4Kvz0u9ULNBTydKcmzJVRlgApbl4TKdNElllhitM/VJbZOW64DhxjuW0R/R3U6dlZORLl6QkP5UaErw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WDGEraxamDCmOrIGgvSkBQMXCkBzp9GsQG0cTZcK6Vc=; b=Q50QHt1A2cFqZCUFrEQAO2MXGL6qBMPw25PqfCG+sO4nngJar+w5b6YsoDmNf44nq+8tPld2LdoNCnNExfSkeaTTeeC3RVtamYiSDnUflWv/C1M7cVeEnwe1cTwwAzoEK/8zwnChUs8XiSxCNrgRB8NqBtcpEGhlGhQ4aa3eZLrobSlAEfUR5y2DPhRabyafM2O+qjnms8aMk/ITIukNqYKsngABRbsGgB7OmdCMZFEyFb0n7JZo4xCUlZN/uEsIhwzg/frRN0IEw2wcyXXI2esiS/7TY3z4WlIAPYkZu22mr4fpY8dJOwxXomgkA89goXFLrQGB57lPa6Zt+u6pwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WDGEraxamDCmOrIGgvSkBQMXCkBzp9GsQG0cTZcK6Vc=; b=k6voec+RitVzzuXMAu8JALm/y+7bKat4xrzvk0vfGMPrGmfLcaReZwj+KeB4zzrLkFgwk7zI0frQty1Kx/9ND/dAWFfhYZBDoGLBHWWVBpNU8EEpJnPk9j0w5gWglaYvxDWaueRT2a+AStFRaabKQEAeB1aJVyt4ZEG+kP/M5TE= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BL3PR10MB6020.namprd10.prod.outlook.com (2603:10b6:208:3b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct 2022 10:31:16 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::1b8e:540e:10f0:9aec]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::1b8e:540e:10f0:9aec%4]) with mapi id 15.20.5676.031; Fri, 21 Oct 2022 10:31:16 +0000 Date: Fri, 21 Oct 2022 13:30:50 +0300 From: Dan Carpenter To: cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org Subject: [bug report] firmware: arm_scmi: Add atomic mode support to virtio transport Message-ID: Content-Disposition: inline X-ClientProxiedBy: ZR0P278CA0105.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::20) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2365:EE_|BL3PR10MB6020:EE_ X-MS-Office365-Filtering-Correlation-Id: 01f2ea99-205d-477d-901f-08dab34f60e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lTPLgc1w0XThb9Vvyl85YGmSlIgzaWqCt82xTZ+vm2vVhWRSdVAd2XHs5DU7DDC+xBGqEqUUUq/T6oCkUARRIL8cjnRxZMDANvVWvbMc3elnEE4BcpcRYgikfQGDHqifu3vGlmgU3Nce5SDLgiYbTwLU51jicdRMGMKpQemcS2FycrH870Phk034v2ZOVfqBzVw1BWUEhSZg4S88AZoKuQykDob9x+ZRL7vsOJYjgpHt+Nppm2w/P2u+4aMXcIwKJKgXYYU8YHHO4Gimf2Eot1nA2eimDxHrcpViH4JgW8nkfOn+jxGF7VofoXtVX+jVNw74hsfcD8upwaxcD+0QzMOleOcGjX3AvIQYNRED6uZgKlvGI1vozZ2bNDhk1iPVQD1ZtaMsmIxdcFVX+eCbrmGCmm3qKiz2nz1RpUXUUKPqkyeTBKyO7BJwtRVVLc+dIWq3bmjFo9xYAfmD91XPWQHaxXmTyDZ3j7MtSE8H4CUCmiNVZNevIR2Y6DxHA3lMDRzTgR/1+VdaicqNoVyJlGDCA2XsXOJH9wjhDEndrnzmE6XTdi7Hy1Ld0DWVyz8R07HHtQZXXtzLyq9JKXsn/p56nXDkJ6+W8drPC4Du2G56fd9qN7iZkUZDA0Qaphcb1AascKMTyYE0kUBl5aXVCCx2vfe2+VyvQL4abROQUJbERRsvqgg8qFU5DbEMJ0zzTSJW+/yF5cMZf98DVMHFzpk60PfQli7eDTFvIcAaV2/fmXinns/XvgQSWHaKH1px X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199015)(6666004)(6486002)(5660300002)(41300700001)(33716001)(8936002)(66556008)(4326008)(8676002)(316002)(6916009)(44832011)(478600001)(66946007)(66476007)(9686003)(6512007)(38100700002)(26005)(6506007)(83380400001)(186003)(2906002)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sfJiVXuPTGkSbWsjHyfY0bR7PhRpQfP39gbTtXeK/ySilKbxLU4VhHHsretx?= =?us-ascii?Q?1ZRprr6iogwxkA2BW0MZcdXBvkFSEsXUe5FbbRkhZbQEXpvHBXQ+lZUDG7XJ?= =?us-ascii?Q?yFqD3qyoGX+Y/uI7zrx30kAUik+bvI6ge+z9Jhie4awbbxlFyrU/yVjQAzCD?= =?us-ascii?Q?odOjOtPmhzJv4llF8ctJmOB8dYIxCSQakMQij9THbMFqv8D6bfZpWuE6v+wv?= =?us-ascii?Q?/2fFJ38a2UmXfn0vKnFOs/o/392JpTN/UzCsNU96K0RrKI1SpQfvwqEIcAuX?= =?us-ascii?Q?ffQVv5RefE1RjKtCRkGsChqVkBPPCBLpvexKmkHIYqcncE6k95N8bOMqjwh6?= =?us-ascii?Q?TVF5kuYLlcSbv0xRSr/Sm4B1/6ORMX8VpVSY534xI3gyv4+Fgxc8BZdeZ6lU?= =?us-ascii?Q?sWOFtQ6GEZ9CChsuKBDbpSxHDkzYMPiLeiQO4JLgc4SM058UXZKk9KPI6Cs2?= =?us-ascii?Q?NeXp11qo7f0B8Npm/q22AppmfsN/BBor6tuIGQtRjv+mPTiVQDJmuvgqg7yH?= =?us-ascii?Q?iqp24qBYXnj+vm9qX+ForlQ3KC9BFKK7hHRIto+aqRDyDy2Tpfz89foeD2yE?= =?us-ascii?Q?/QkT35y6IkFA2vyl9y7Ac1DdxnN3L7LdjQI+nNIr5PinFEI9zdMpT0hHntjV?= =?us-ascii?Q?rbMrF6DmCejYvI51LXbvLN3lwSMIRvngIjQvEvCJVKrpXTJbrGcfQ9icdgSS?= =?us-ascii?Q?ZQf3AmlYN4nSsjKvu5xjOqVc2qGMveylQnFhfEOUk6ie7wPPKDYHyzJ0MQEV?= =?us-ascii?Q?v28mI4YA0v98fntsfMFJ6U5u30MMoMMRVBxNEuLkLaNvyDiGkFIrgqRjCgI3?= =?us-ascii?Q?HsrClDgy6XDR22JJreVQyjiSR3H320mKlpu6rRNQYubK8RyDSd9eeFf4YV6s?= =?us-ascii?Q?AYpdQH/BZPnUxmzj+/nm7ghl8rjEnLdFW0ldwpU/2SDg/5LTd3rNbNK6Zxz+?= =?us-ascii?Q?ZIX0r2FPs6W4IpHskXhMl11cc2BZRzeuGRUpCWoUr25fsrRRumAQV7MHkRr6?= =?us-ascii?Q?xn+QBy5jWS0lRyl0XYyWjs/oiyZDwnI+Nh+Rf+OKeZm2JAubcMnknPXbCEsY?= =?us-ascii?Q?zE6N8ZLWQsxUwkU0Kh6HOraUUSF7J5q+5CY/1A8RR4wzp9QVPcO2EWYEpayJ?= =?us-ascii?Q?o26+jlhcmDcMEIvcJ5k66HXeHdtwtSI/+VsFg5KNcE1gkuU71cgU8moXJawr?= =?us-ascii?Q?sbEJZBH6pLCEwRgc3uLhTyJmnKe6SCMknfaEhdQfpSAL3sOzdK6vOLOyNhCB?= =?us-ascii?Q?aWZrhqv69mAMWaRhF7FUCNRlPD2X+Hb0OMZBUXt21hrfjF4lTEsr7Pghp51F?= =?us-ascii?Q?t9CYvumvnZZtJexm1zVDwNd+72pc+Dm4cDy0cEjSwqN1aqkuYdqhLbUuCgTX?= =?us-ascii?Q?8PIYVgmLXCsgOhos49mQoHkUM0r4Twd8GnPU+6SXwYWZ/KV7Ui+KSCgikHQ/?= =?us-ascii?Q?rSAJA9fUi3APDH20SD9yT2W1YKvYHDu3FrutKxacdohZTCzbnLeIVs1k26cF?= =?us-ascii?Q?SyFPgDOiOAfRL3VyHE4KUC5Bl9dfYbXjAiCNnS3rWMoXstqqxp/sNaaTzhVU?= =?us-ascii?Q?cqTaCzP/VTPqHaKOsHywjyUxTadB0c5QWAYFRFknfgW7vPlryd54yNxWPONk?= =?us-ascii?Q?Cg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01f2ea99-205d-477d-901f-08dab34f60e0 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 10:31:16.0774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hfJ+47B86+imk48NsILfAUU72KlnapDCY/exCC0yXf2jEMYLLtXJxf87Vf+lOmnSEkZKgvTOV9nFcMj03Int5l9Ijd5oJwlVlovO/Dur+Eg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6020 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210210060 X-Proofpoint-ORIG-GUID: _BuJkWL0RmABMRFlCzcYAAwpd3WlSlUy X-Proofpoint-GUID: _BuJkWL0RmABMRFlCzcYAAwpd3WlSlUy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_033126_425011_2F58536C X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Cristian Marussi, The patch 5a3b7185c47c: "firmware: arm_scmi: Add atomic mode support to virtio transport" from Feb 17, 2022, leads to the following Smatch static checker warning: drivers/firmware/arm_scmi/virtio.c:471 virtio_chan_setup() warn: 'vioch->deferred_tx_wq' from alloc_workqueue() not released on lines: 449,456,464. drivers/firmware/arm_scmi/virtio.c 419 static int virtio_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, 420 bool tx) 421 { 422 struct scmi_vio_channel *vioch; 423 int index = tx ? VIRTIO_SCMI_VQ_TX : VIRTIO_SCMI_VQ_RX; 424 int i; 425 426 if (!scmi_vdev) 427 return -EPROBE_DEFER; 428 429 vioch = &((struct scmi_vio_channel *)scmi_vdev->priv)[index]; 430 431 /* Setup a deferred worker for polling. */ 432 if (tx && !vioch->deferred_tx_wq) { 433 vioch->deferred_tx_wq = 434 alloc_workqueue(dev_name(&scmi_vdev->dev), 435 WQ_UNBOUND | WQ_FREEZABLE | WQ_SYSFS, 436 0); This workqueue is not freed on error paths. 437 if (!vioch->deferred_tx_wq) 438 return -ENOMEM; 439 440 INIT_WORK(&vioch->deferred_tx_work, 441 scmi_vio_deferred_tx_worker); 442 } 443 444 for (i = 0; i < vioch->max_msg; i++) { 445 struct scmi_vio_msg *msg; 446 447 msg = devm_kzalloc(cinfo->dev, sizeof(*msg), GFP_KERNEL); 448 if (!msg) 449 return -ENOMEM; Here etc. 450 451 if (tx) { 452 msg->request = devm_kzalloc(cinfo->dev, 453 VIRTIO_SCMI_MAX_PDU_SIZE, 454 GFP_KERNEL); 455 if (!msg->request) 456 return -ENOMEM; 457 spin_lock_init(&msg->poll_lock); 458 refcount_set(&msg->users, 1); 459 } 460 461 msg->input = devm_kzalloc(cinfo->dev, VIRTIO_SCMI_MAX_PDU_SIZE, 462 GFP_KERNEL); 463 if (!msg->input) 464 return -ENOMEM; 465 466 scmi_finalize_message(vioch, msg); 467 } 468 469 scmi_vio_channel_ready(vioch, cinfo); 470 --> 471 return 0; 472 } regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel