From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2BA7C433FE for ; Fri, 21 Oct 2022 09:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9HbO7Jkaj2p9Y6WUxCoI+pcIAQUToGX+lJFCAUsjLjM=; b=KZNGllMGDKFBZy z+nYl4ia4JpVUcWdzY12lhZnvaL4uYmHK/UEIoId7hrdQb14Ywiw8aocjB/kdDKRbFBAesXzi3yoA n3Su+cRqf2UElbU3CCM+gQvrESVDPttrdoj5znr+CRyOHE5GPlIaJ52QnpC5961gcOEq89c8J9676 K2AxJLhHMpYQ3UV5DhaUh4eD/y3OI6Ff1B2tFex9qr0cl/F+o7+ug1iKez2Hqy6eyQTYR22En7iNC OXbpRKXR7W+mBQUcC8Qcdbi+qkoyQKf6nrGVNxkbcUkx87Bk/huQMhiB4jT6ub0VStNxm/2UU5vJA ocHGEHvW3g93vFqUHr9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olnvU-006dIv-5Y; Fri, 21 Oct 2022 09:02:48 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olnvG-006bxK-W8; Fri, 21 Oct 2022 09:02:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4iMBphw13KTQLLQRfUG/2Q1TsUUh89Ar5EYrCCnD96k=; b=wh3/gEmC9mepUk1fTEqfrqlJEy 7LxX5iGvzCultd99ss4GAQLzu47Tznnc1PQKPA+dLeQQ1U/2J0eqEGdpKKoAMVIlGBtg41DJUL7cD kcASAQQfNiEmBACrIMYPnPdNwR1cusbIry2QS08ZHAZiCmSloL5Ym4v98A+J/P1nkT590E9zRlIua 25f64/PnDS4f9cbTgmeBIOoleCgTLQcVqfoLRA/XV0olSiogHasssrNWEnijciwmDoNXVvTVafw+/ lA7mEPSANpOChXuPjPHmwwrtNfqsNiOMwW05rDG0nm9rCzYooiOCisTqROtT2k8ckMA2rME1CHzYi 1ZAZ8JSw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34854) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1olnt7-0008PG-Jd; Fri, 21 Oct 2022 10:00:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1olnt2-000421-4a; Fri, 21 Oct 2022 10:00:16 +0100 Date: Fri, 21 Oct 2022 10:00:16 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <20221020144431.126124-1-linux@fw-web.de> <02A54E45-2084-440A-A643-772C0CC9F988@public-files.de> <9E91B812-8687-463D-8B98-3C4BF26CBE08@fw-web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9E91B812-8687-463D-8B98-3C4BF26CBE08@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_020235_100312_E75F69AE X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 21, 2022 at 10:41:22AM +0200, Frank Wunderlich wrote: > Am 21. Oktober 2022 09:24:02 MESZ schrieb "Russell King (Oracle)" : > >On Fri, Oct 21, 2022 at 08:04:51AM +0200, Frank Wunderlich wrote: > >> On my board (bpi-r3) we have no autoneg on the gmacs. We have a switch (mt7531) with fixed-link on the first and a sfp-cage on the other. Second mac gets speed-setting (1000base-X or 2500base-X) from sfp eeprom, but no advertisement from the "other end". Imho it is always full duplex. > > > >If it's a fixed link, then this function you're adding won't be called. > >It's only called for in-band mode which is exclusive with fixed-link > >mode. > > > >-- > >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > >FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > Right, i get this trace for the second mac which is without fixed-link because of in-band-managed for sfp (read speed settings from sfp eeprom). So, you need to set state->duplex to DUPLEX_FULL if this is what the hardware is actually doing. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel