From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFBAAC4332F for ; Fri, 21 Oct 2022 14:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/kGcYHgXfyvFfKapCOH4acXoR3zkiA0aSjuipUj+iA0=; b=aeOXYp/TVGhTsa sDy+fNJ+hOtly81QTL7qd8MseC52VO12kggwgC8wQsHfWMOxPgZV5ahGkTutZH+gBN6+qK5XfvQ2n wpt7RJ033iui8O2MgTuC1Ijm+Ak/x2ZOi2oWggqEhrLhwFg6+VQMNf8o2F/Do2lhlGh/KnP/ulNNn 4u6o93uiNhk4ewdVL1Wpd9x7II6djTlkuB2hhxngH1cBMIVS+SxzIFG8nulU/RfBbpgnFPmn4c9Fx 21iIEzwoAbfq+TTupbmA5zh5WBvGHUgM24yrrJvEaihsXIuRuNbKuF6eccjyIeN7BAWamkWtP6oqe /JO9NmzTrbs0EDJEeVgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oltBt-008VNT-5V; Fri, 21 Oct 2022 14:40:05 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oltBp-008VMA-TO for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2022 14:40:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=D9L9gWEpqVSBkoML8PsO+P3x7+AWH1EUh92SK7KY3pI=; b=49jIcLnMiwuJE4tD9XSbawbmB/ FlTXGg0PNbhAHZtw7MLLHh7r4VhO/o6+PWH/z73jgqoIE0pY4PhHvueaHneuKFtTddu3hl5oK5iar AgDV+G9JDLgWMxdCjOqupEEib4aZOPKg5M3/yKyrTZC1oZUnwag5TOHtsK4gVgvEeudc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oltBU-000F8B-6x; Fri, 21 Oct 2022 16:39:40 +0200 Date: Fri, 21 Oct 2022 16:39:40 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , Krzysztof Kozlowski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v5 2/5] net: ipqess: introduce the Qualcomm IPQESS driver Message-ID: References: <20221021124556.100445-1-maxime.chevallier@bootlin.com> <20221021124556.100445-3-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221021124556.100445-3-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_074001_974174_E40B5379 X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static int ipqess_axi_remove(struct platform_device *pdev) > +{ > + const struct net_device *netdev = platform_get_drvdata(pdev); > + struct ipqess *ess = netdev_priv(netdev); > + > + ipqess_hw_stop(ess); > + unregister_netdev(ess->netdev); Should the unregister come first? What happens if the network stack tries to use the interface during/after ipqess_hw_stop()? It just seems like it would be safer to first unregister the interface, and then stop it? > +struct ipqess_tx_desc { > + __le16 len; > + __le16 svlan_tag; > + __le32 word1; > + __le32 addr; > + __le32 word3; > +} __aligned(16) __packed; > + > +struct ipqess_rx_desc { > + u16 rrd0; > + u16 rrd1; > + u16 rrd2; > + u16 rrd3; > + u16 rrd4; > + u16 rrd5; > + u16 rrd6; > + u16 rrd7; > +} __aligned(16) __packed; The TX descriptor is little endian, but the RX descriptor is host endian? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel