From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C97CC04A95 for ; Tue, 25 Oct 2022 05:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BFns+YVr7R+cVQeWd3XBE/3PdxTY2x//RaEVliKktrE=; b=d7BJxb2UiMDHia PAXl/qtjqxY0MRjNBchbU8tyDmuSvKmCv0+cmcA1GRflu7QH/JQ/BE4UnjcclOMD28QhEaApVpV28 +I43TwwEC1TIoqC5xYRMkX6i/I0CRpx6N+6N9Xf2Ctom43NJSDZ7Wxw+pXa3HlXgzfO7mki8m2yDJ A/0LwuQNctdC6RxRgWVBj6iIZR/NizKvKibL2YzY6wNUS673ptTkgUvUlomzWfvY+93kLs0r/4AS3 HmYevi0a/RyIjeLF6MICHj6hucxMiShnLc1Wr3aQ2keEnKQ17aqAOw7purA0lH4bw6ztn+wjCBnxV THRZTW1verWM1N0UdnfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onCN5-003v90-58; Tue, 25 Oct 2022 05:21:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onCN2-003v8I-G1 for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 05:21:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C16F4B816AD; Tue, 25 Oct 2022 05:20:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FC67C433C1; Tue, 25 Oct 2022 05:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666675255; bh=5cFmToZnfHJ3wdZXZsGCXvTpJ5G1Crrf87o/qATJxsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p0fCnGGFpHgVFPayes/UIyVNcy6BtBRFTD3Q9/wyqG2Y5xH1mZr2r2sKRSiBWhuDh ztXeBQj+aAYuaZH0FmKdh0ijkr9ui60lO7QqMz+DnvlJM7CiwFy1tao33M4GHL5A0B k39c3haPGpF0sTuDVeEtZ39lNQqvX1Fz7mnKxSa2yhST/m2Z4A4UQwdc7vy7WBQPZc fuqh9cvdkNsODKS+tDbsj2YYA9N93A/DSh0lORlRzKH9o0PDqx3dE/hBsDgp39Eo8g 9POJdiZ/00GHwRte+7FXXbAQTPh2qOETSQ24pfz47+tX9HEMjgoWkY1gH2yg/GkqX3 6pVtRZThPUc2Q== Date: Mon, 24 Oct 2022 22:20:53 -0700 From: Eric Biggers To: Tianjia Zhang Cc: Herbert Xu , "David S. Miller" , Jussi Kivilinna , Ard Biesheuvel , Mark Brown , Catalin Marinas , Will Deacon , Maxime Coquelin , Alexandre Torgue , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 12/15] crypto: arm64/sm4 - add CE implementation for ESSIV mode Message-ID: References: <20221018071006.5717-1-tianjia.zhang@linux.alibaba.com> <20221018071006.5717-13-tianjia.zhang@linux.alibaba.com> <6d2a98f4-c50d-d05b-4a24-08fdd3ee20fa@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d2a98f4-c50d-d05b-4a24-08fdd3ee20fa@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_222100_696853_0F5D891F X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 21, 2022 at 10:47:14AM +0800, Tianjia Zhang wrote: > Hi Eric, > > On 10/20/22 11:58 AM, Eric Biggers wrote: > > On Tue, Oct 18, 2022 at 03:10:03PM +0800, Tianjia Zhang wrote: > > > This patch is a CE-optimized assembly implementation for ESSIV mode. > > > The assembly part is realized by reusing the CBC mode. > > > > > > Signed-off-by: Tianjia Zhang > > > > Is there still a use case for CBC-ESSIV mode these days, now that everyone is > > using XTS instead? > > > > - Eric > > The mainstream is already using XTS, but CBC-ESSIV is still an optional > backup algorithm, especially in block crypto and fscrypto, I'm currently > working on supporting the SM4 algorithm for these subsystems. > The only reason that AES-CBC-ESSIV support was added to fs/crypto/ was because someone had a low-power embedded device with a hardware crypto accelerator that only supported AES-CBC. Nothing like that is relevant here, as this is just a software implementation. Please just don't include ESSIV. There's no need to implement random useless algorithms. It could always be added later if a use case actually arises. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel