From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E460C38A2D for ; Tue, 25 Oct 2022 15:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m733OiQdD74f1AHfUFq4FhYXdRdLVCIMtRFDSZmVdbc=; b=Gc7dccfVkbq/hglgBX/XEdwQ6A fAlQMCjOkStoBwnoFBPCx/xpqMhuvBhFcEKs0v0tcFgzMLdCeODPivt8QGvzpbEcEH4waUwoObvNt jHHHtwIjyGhn2trBOC2xsAT6415dbIH3rG/bpC0LNuSUYbgveaynI/Nf5uKGVhJsNLPBa5LGz6N+z LIf4G/RmEgKtUigo9JHRI0Tx6WbOwtCSrwnEUNDPaYEkmsj35a5aBKD3HBzUZnj5mROqy1o5fVWcw dHGHqsie9KpBgj8SIxZlPUm2eDvpWmdNFFlqM2UEICn97Bn4zrd6YkyZ8XfbRxA/aYeOIXy069Ax8 tdGek1gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onLUc-005yne-VK; Tue, 25 Oct 2022 15:05:27 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onLUY-005yl4-TE for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 15:05:24 +0000 Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 60DB16000C; Tue, 25 Oct 2022 15:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1666710319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pJw8Rlc47CepdpF/VUPGYP+SOmVKJurWX4ajQaE7REY=; b=grWlZpU8307qXCEDcJutgnVQSJwJRRphWXN8Z3ZsFVhHmFy3DpnBYnAP+xqX9NHXFjPxmX 9e3XIOA4t6xPQPwJuPxYvrHZIkL70Dv71yk9Fe1FD6tcaWFAQV7DP6itcLLuMPZdofaAs9 S3lTb2r91dhdbTVb0UkiRTazglsOuvcx0eQGbpGzijWjmqyQ2C4EY0pyGXEUTGonEQfO25 gLU2QvnHtKbaXKzAS3quf1isDVI30jZOoDXKLMiTSk8N5Kwq2vjRufAMocf9TSWI5qsDm5 o/wtEjz80htAYOBEYgfeiry6C4zQ2QufMr/fSc1FjaYdwL9wu/zJ9GaM+s+iFg== Date: Tue, 25 Oct 2022 17:05:16 +0200 From: Paul Kocialkowski To: Jernej Skrabec Cc: mripard@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] media: cedrus: prefer untiled capture format Message-ID: References: <20221024201515.34129-1-jernej.skrabec@gmail.com> <20221024201515.34129-9-jernej.skrabec@gmail.com> MIME-Version: 1.0 In-Reply-To: <20221024201515.34129-9-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_080523_245766_E1018010 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6998157961778317392==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6998157961778317392== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w+BAvZwxLTv8gd/o" Content-Disposition: inline --w+BAvZwxLTv8gd/o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jernej, On Mon 24 Oct 22, 22:15, Jernej Skrabec wrote: > While all generations of display engine on Allwinner SoCs support > untiled format, only first generation supports tiled format. Let's > move untiled format up, so it can be picked before tiled one. If > Cedrus variant doesn't support untiled format, tiled will still be > picked as default format. Makes sense to me. Of course the order shouldn't matter to smart-enough userspace but it doesn't hurt to serve the most generic case first. Acked-by: Paul Kocialkowski Cheers, Paul > Signed-off-by: Jernej Skrabec > --- > drivers/staging/media/sunxi/cedrus/cedrus_video.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/= staging/media/sunxi/cedrus/cedrus_video.c > index 3591bf9d7d9c..f9f723ea3f79 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -56,13 +56,13 @@ static struct cedrus_format cedrus_formats[] =3D { > .capabilities =3D CEDRUS_CAPABILITY_VP8_DEC, > }, > { > - .pixelformat =3D V4L2_PIX_FMT_NV12_32L32, > + .pixelformat =3D V4L2_PIX_FMT_NV12, > .directions =3D CEDRUS_DECODE_DST, > + .capabilities =3D CEDRUS_CAPABILITY_UNTILED, > }, > { > - .pixelformat =3D V4L2_PIX_FMT_NV12, > + .pixelformat =3D V4L2_PIX_FMT_NV12_32L32, > .directions =3D CEDRUS_DECODE_DST, > - .capabilities =3D CEDRUS_CAPABILITY_UNTILED, > }, > }; > =20 > --=20 > 2.38.1 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --w+BAvZwxLTv8gd/o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmNX+ywACgkQ3cLmz3+f v9FCUwf/V3Ng/xfoDLZGeEjzDHQU3ZtEXX1RMo0WULubg8BMamTlPR4tbDQTBW56 ipFZ0EtzlcdwnQHAhA+3HAu6CTfp+MwxLeeWEr4luVFSX+LuMU22Mclz9Ji7/vwh OMcQ5fcCJDrYZE0Lc6Y6EzQozjt9q/m7dNG2joUKQzm9Futr6RTUOjUvZ5RgrR3q 8HMZKxxnVxgirPAIMl1h0y57hKWx+C/0L/TGrDeEzjcNxoZYcBuXCUNhdl9lXMFY MNQq430Jsb4LYuu3bTjtDXYRBGGHOwyjrNsyhWtM8/djejO+FiP48NLQtbL72cIK CT9U2hRl24cMNSB5oe2ZTZ4pmnGoqw== =UyBL -----END PGP SIGNATURE----- --w+BAvZwxLTv8gd/o-- --===============6998157961778317392== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6998157961778317392==--