From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90EFC04A95 for ; Tue, 25 Oct 2022 12:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H/gnhf3bJwJTJerxDHPux5ciHy2ghPj+aUd6+4ydfPg=; b=zv/0pK4HoXE9JY r/Fk5+Sz5rP21CwDATAS7wHPy/sXJyQtFIzig5hZGuiZYeIxgVQPuJW4EW9iIeOnmmlwQL+GvHxzh 78jPkHxn9xuU/UqQdqt14lU1sHM/wZbX0oAwQcfBR6l8MGqya75Xr6fyzBw82hmPrRatArCBPvuFy MiuvjJgUYcWVU/QMjxueNNODCRJQu6Qrt/iBdZXLCpS9EtgrHLO/A+tWcyi09AR0wQGhLw7JLHYUj hkP63KgYbko7wOESPTUo2NQwzrEfBd2ievpUa4Nwz1021++PKH1hYJrJFXj6Vkx0zGy9gNIYcn1iJ jc3HoRxADLDLlpjDvcbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onInM-0057m4-HX; Tue, 25 Oct 2022 12:12:36 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onInI-0057lT-EO for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 12:12:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1GLLDI99fTLFVk7UHyLsLRMZqShPEgCumFtxPIsX+Wc=; b=O+DlVwkKqDxVFj9SutyvUOq/vH RwP08FVS4SER5XjmDApbsgbkufJNZrT8qqpbm9cW4Mf8yyi5wCnC56IViXb6e+3mVR9hiQvWc0XNR FsBbea57NNHwF+IeGrxEjbL+RgMxK18Vft6iQCSEWWLfA1ixt+FxxOO+cm09foJ+mSWn2+kAbutzG wsk5LXvRagU8cDBOYCphomgBn8O0Jp2PZqbZAZergWemCaHHB/tVV3QiT+tNmSP+bG0PIY9AbAPpU FrwxaMq9vE6BkP20I3syeqytDAexB22Z21ClAjFTK32iHA4zGxQhvdZnTgTg6S9qTOqRuU2uiJDiH YYhPGxvg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34946) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1onIn5-0004Sr-7S; Tue, 25 Oct 2022 13:12:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1onImw-00086k-St; Tue, 25 Oct 2022 13:12:10 +0100 Date: Tue, 25 Oct 2022 13:12:10 +0100 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Linus Walleij , Lubomir Rintel , "Rafael J . Wysocki" , Viresh Kumar , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 04/11] ARM: sa1100: make cpufreq driver build standalone Message-ID: References: <20221021155000.4108406-1-arnd@kernel.org> <20221021155000.4108406-5-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_051232_503690_4916CC39 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 25, 2022 at 12:14:19PM +0200, Arnd Bergmann wrote: > On Tue, Oct 25, 2022, at 10:28, Russell King (Oracle) wrote: > > On Fri, Oct 21, 2022 at 05:49:34PM +0200, Arnd Bergmann wrote: > >> From: Arnd Bergmann > >> > >> Commit 59a2e613d07f ("cpufreq: sa11x0: move cpufreq driver > >> to drivers/cpufreq") added an unnecessary reference to > >> mach/generic.h. Just remove it again after moving the code > >> into the corresponding driver. > > > > So how does arch/arm/mach-sa1100/clock.c get the MPLL rate with this > > change? > > You are right, that's broken. It works for the defconfigs that > enable the cpufreq driver, Umm. How? I think your testing must be seriously flawed! You add sa11x0_getspeed() to the sa1110 cpufreq driver as a static function, which means it won't be visible to clock.c - and clock.c is always built, and always references sa11x0_getspeed()... so you should be getting an unconditional build failure at link time and a compiler warning that sa11x0_getspeed() is not declared. Are you not seeing that? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel