From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 310B8C433FE for ; Wed, 26 Oct 2022 12:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8qRIGKZGF6zn5nk9OLzGJFNv7v3e1Jm5QWMdAmVrdao=; b=QMNJZymN/H4/KV x53L8JTKlL97jQ4FHv+DjkNiIIy54WPPc1ZI6VIanosFiXTcHgi/ujpZ8/mIldxvJALaLLaXAiciz BNIcO2TladVolx9+HtxS0zv5eKCiujzkALqlU8HcDZMxXlZwIVRaZr48Aixj5npCqD0nunq9GIbEj 2RuOeuBNJTHwhLBxSixARUJUpEmxkeyElqUgv0c2qULxMBYws9jK9Yt+X0pyQ6haPTTk7IJqTZJPv wqSxfKo7/+mpeailmfMFhkGBEcjn1aKGItaUhTdPVckzZ9+iHEQL3w5LPwJEGyBRKgx5+AxvTMCK1 P3PpIFjOylX2YLdl/K1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onfF1-0098qr-V3; Wed, 26 Oct 2022 12:10:40 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onfEy-0098pr-41 for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 12:10:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666786235; x=1698322235; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=w52UFWvClTdw7CwIPvtVZRysG8gCu2aRNukjc6c5mQ0=; b=VTaA2rJY/Y1qX1tofIY07foXEzOQc0zaqU8B/yJJpRroAas8+WKPuvbH Tj6ZjbHUZq1lmfQPYotPX7yJqLmZ3Agf/YbKlh0jhp5qAW2ht+NAhYBFB 0DXK8iseKew1FQhWe7QOYKTo55FUKHmdtLejlFZkqsx0jnS1TZKZPCbW3 hQ4WErLpc2GWN0BtLaL3DvO7n0Xkq4kM/riiRSWY9UwX724AISpkpl9o7 FE+mlQ6kEqA1Cluzhu3r3kJBeelY+18S26V5IVWN8AOmQXKDb0i8hznff iNwr2lis4odX31nHq7PxZtaBqCvg/y3f1fVRHe7A7UMFfj5HI3JfIFWB+ g==; X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="120425247" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 26 Oct 2022 05:10:29 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Wed, 26 Oct 2022 05:10:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Wed, 26 Oct 2022 05:10:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxN/q8ioJrNnGWYcMKPmxwPAPGnHxyagxpnQQPcy+c/Da3Z25e94EZJukucwExp9Oeh4Z/XVfUcQVqiTFua5akmzYJ885p/GkFUDvp1YdBWAiaXdKzJ52FlcdOmP3DSx7HbMEM4G9VT6rJgT9ZQVl6YjQEXU/5NhwDtJBxfoh5ZbY5xQ56ZuQBKs4u8IHE7oVNXp+DvEhYYhSIYSEkruarlYmqzCwZWwRYYJSd8J8gWn1NcrZWpyAG4n1tedYOO/hvSv7LG1H/kC0t7PqTb0D4Sg4GYw3vZdPtNpkrK4pCMxyWgkr+ccZkB87d4jeRRw0B4490UoEgvOHUIrZCe84w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9c8B8ZbPiwDv4vfOEBRsYPFF8GwOqJFhoWKg8MsAygc=; b=QZnMiZ1zN30uvg7jSdiz6Lw7lSGf5u9hx5pkuC3OcVW/dTA83eUIoNOLzAxo0YoldIt2Ib80d3F/fYzJP2lD8wWB0k5VAWolKgapkNolZyEnpOCk8v0TUuIlKRbxLuV9R6KTiAfCrImsK0abEXiZU12BOPdrgC7lOpj4xhImpcl9Ok0Q+AlsplrSZt53gOFMb4Cvrfda7yh68Q+TLwqon04LozpWy8/D9z3/QJV75y4OXSJr2gLxLalwxrKYIGGKywaiRxzgWNP9k6+PpR26TepiQDZ9tV0jvYyioSaGyCp7ttD192u50ry0wzIw4Md9Gka8zRrS6tYkev9jCmh4NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9c8B8ZbPiwDv4vfOEBRsYPFF8GwOqJFhoWKg8MsAygc=; b=cCDQIEQPcdH3YBSLT4A/o7ejXGHnqBpn4O+HESwfLLVaLkc49Ezh6G+HQYJHR6k3PoMgpqmFNQvo31pOHuU0dymn/a9/6Hg4o5/RWQlXiIDEM+7jb00LDyah3QAS67GvKpXYx+NmjcXMFO+S+Os4e07bM1nrcy2YlWmeWRCbnIc= Received: from CO6PR11MB5569.namprd11.prod.outlook.com (2603:10b6:303:139::20) by DS0PR11MB6495.namprd11.prod.outlook.com (2603:10b6:8:c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct 2022 12:10:24 +0000 Received: from CO6PR11MB5569.namprd11.prod.outlook.com ([fe80::a2ae:2047:6ef5:6a45]) by CO6PR11MB5569.namprd11.prod.outlook.com ([fe80::a2ae:2047:6ef5:6a45%5]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022 12:10:24 +0000 From: To: CC: , , , , , , , , , , , , , , , , Subject: Re: [net-next v3 2/6] net: dcb: add new apptrust attribute Thread-Topic: [net-next v3 2/6] net: dcb: add new apptrust attribute Thread-Index: AQHY54eplZCAOpJ79E+/+KGuQyJoL64ghtyAgAAUtQA= Date: Wed, 26 Oct 2022 12:10:23 +0000 Message-ID: References: <20221024091333.1048061-1-daniel.machon@microchip.com> <20221024091333.1048061-3-daniel.machon@microchip.com> <87zgdizvfq.fsf@nvidia.com> In-Reply-To: <87zgdizvfq.fsf@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5569:EE_|DS0PR11MB6495:EE_ x-ms-office365-filtering-correlation-id: 827e83db-abec-4fe3-9bbc-08dab74b0fb1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fA3BivyHaSQZuWb4iHUEeK9nrKxkmu0LzzaM/VsQ8zMsCNVj/fzheYL+SHhw41f2PDmAAULMgpgngZoHx83UQBidXSPOj0++/Vq77fV7ci7dV5bLDvvo0br2vc41SXmOkoTm8PO/OexeoagAo+92lSssa8CQIVhGm9tSmD8l0+nQUXX2bHy4nACrenmrvOqvUVkvDxrYlsAjyrfNd5af/gaO1oWMtVCOg8wCacg749qrbWpqBqjpGtUuMKDxgPE0M4y0l5fQgRhKQXqBzc6jNFDg+NaLm528v4EcIWzPoEthOLrM38pxgVrE488qy9WoaBCGclRZlgF8cbil8986L8m6HlUzJd1VFZ6F+JTlbnJKzyp8kphBfmlbskvIFi9A7wjyXru++s7mrtrdyR4fP2qajo8o8rU/LrUbJ+IxcNZmIHopvNrvvhMs9U54QexfmqK3VWVwdwtP9oHUcsYXo/ZDmNdQVwQhyTifAdwlXoNZbamhGle6pPduSCDw3UfxiU8D7kSzc1G4ezRI7JNV9jnivy+j5VhahliGYAGahVvHaGMNFNd6DGwlxYqq9qhEZWIIaLV3oS1f3tafPobtt8obiSGE5cmlo1hsHvzXSZqzYWZ8QBZxMVP7mP3jVcwwnRd2YsRwMUkXeo4IkEfGRSRJT+dOk+MMG12ZeZAyaoXTJ4eXL0w6hA2MF2M49+PVqB+6kqu74RbzVhQhp1zH7Dwh2p4sca7Pz18s3fMN7oCTEwHBq0wJ5ohEz9wYmx77LFt+cbbDGPKF26BrWcbHbg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5569.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199015)(33716001)(4744005)(4326008)(7416002)(91956017)(122000001)(66446008)(186003)(38100700002)(5660300002)(64756008)(66556008)(2906002)(66476007)(8676002)(76116006)(54906003)(8936002)(316002)(86362001)(41300700001)(6916009)(71200400001)(26005)(6512007)(66946007)(6506007)(9686003)(38070700005)(478600001)(6486002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F5NlBlF1gRoZo7RN8FsOBNwIR0ftd1DP+uYFoYeE1KNMH4lPCP+b7CPkjxbb?= =?us-ascii?Q?qcCeU5deT17HdqC4V9ezcmZlClZP7yNA8uMSMQdFzdPMEtds1mDLX+DJ6tL2?= =?us-ascii?Q?+DwnwqrNZMufgODi72YFO7Zc3HM0+qT1Hp2EbiIuM52eBvoWleu12XmrKf9X?= =?us-ascii?Q?CBOkb+TdQ0uVjjpDeO9YdKRqXI2xRNcRv2JUrjrFLQ/w4zGTQuAc3GadsP7K?= =?us-ascii?Q?SKRHbGL4Ye9hP6SxOD1Htr6tzw2qZFqjQX6sy6HPGIrwkV5Jl2SnpjWnMbiQ?= =?us-ascii?Q?KKX1W9ioPJL9IfBWvwZ9bQ8OZlzERDLj5woeXRlC39fP4IvniV1d0KwWryZb?= =?us-ascii?Q?ae9En298Usg6D/vzZAdHgZto12NJ4AJtvVRbWFJDMS3/w+lWl2UgxyZQk/Kg?= =?us-ascii?Q?j5Kv62MqeJmrtsmBzApBKvLj/N/smAjiCtGASbKwK4sSmYWgihasmFGaIxGz?= =?us-ascii?Q?A7TcYViqHCXh29Mbwp7C5U70JAkUxqlNDgDm+pTyUC6POs/SsZujgK5L+FJO?= =?us-ascii?Q?5VR1cVls8L+mvxeWCLaPOwIxjsfFZLZ9EWnpgqwPPjR9OcF3tuhqwGi0mD5j?= =?us-ascii?Q?53HXBk3TJmVj/h43ltOMxKBFJWvCU2AQ8ywKtROtLJETL5bIYP+uKUvWyPvL?= =?us-ascii?Q?HStfMuPJ7YFfYBcHOR0xJzxdTPVW7kJyyi3dqmVogocPqbwRWmcsRT62cP8F?= =?us-ascii?Q?htnTtJw/+czo6VebCmZ9DNjBN9keSz+KZaJV8sBNuMIqBZ18r1WPGU80kpcN?= =?us-ascii?Q?y54rBBQAjJYkiJw5S8RMBi/QVu+N4L52IQg4O/9sEawc6zetAc0rKcel4+fi?= =?us-ascii?Q?cZj3gl4+xZOJNX5adSDCripJnfZofANbGVnRoE1e+qVk9+z0ETQpUugNfZDM?= =?us-ascii?Q?0dShuv2pMsb4d46XYf7J0D3c52eYrUeq33DIW3NkKh+XontbITXg017/MAfB?= =?us-ascii?Q?nUFnuunKZ7Bph2Emc72y38DL10A04F1knu2RCDJ7+SW+MSupYI+0EziHoJTA?= =?us-ascii?Q?hobbYdcudVZiMvLZJuB42OJBKmuJlU1gygre/RG6SONNpcUzoRDP07xYcd//?= =?us-ascii?Q?5r6mDnsnk8bVTQvNI+scpQie86ABXjGWT0+P7VdzF+YMZU4ZSw8Fhl9I7nYR?= =?us-ascii?Q?PQYTZBPKI7h7uQE5CPbt0UowYFHFrcgwAIdDezTyVARJqILjq6zERosan5rs?= =?us-ascii?Q?23VCmHxMsEnUQoESoXuqXo1iy5SnEWCb7neO/3DV1QhAPxeEmkhVOQgWeTrd?= =?us-ascii?Q?NKLX2waRx/qvik3D7AUKjd0I1WlG9w8X73mSRSziPp9ssuvEY9ErhtpxPZ0B?= =?us-ascii?Q?P0BEvEQKa/MBO9XC7Hvo3khs8A9yoIeRr6CoxttN6FLqyH2BA1L8Z8Cr4Ddq?= =?us-ascii?Q?zKPrivr1EsA5V5HLFE7TMJkREHnSjTLQFOlAixweSO7mSXoQEU1LbVh4ed3r?= =?us-ascii?Q?khNlcCZAwuGx7kiJgp0Zr5TIgfVFwmlOamZsThstr1tUY5cCxRZCatCJ1mjG?= =?us-ascii?Q?0aQGyjIbnKALN+WrM9XZylrTuWbjqdrJokKzwkvLW8ZSLtFbSbZKSEZ1+hzE?= =?us-ascii?Q?KsF+YG0c9JhKciqGI4VPajZgQEVe71g1Ddoh2o67dfV3NQ0zwu/ZlQm7YDXr?= =?us-ascii?Q?ejhDY+qS5vnIxD5vknVgmTg=3D?= Content-ID: <43C2229516C31245BCF1DA520B6ED02B@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 827e83db-abec-4fe3-9bbc-08dab74b0fb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 12:10:23.9606 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0mAxMlDTa1m64XG8YaD2bb0kBG91b42eS8rkVKkr+o2hbG9L5pNKrmhvyq/kSshXvwlDCULOQjplsvtMfv8S48HDF2mztTDMw21ptpMePX0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6495 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_051036_477309_652B8AAF X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > + if (ops->dcbnl_getapptrust) { > > + u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0}; > > + int nselectors; > > + > > + apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE); > > + if (!app) > > + return -EMSGSIZE; > > + > > + err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors); > > + if (err) > > + return -EMSGSIZE; > > This should return the error coming from the driver instead of > -EMSGSIZE. Hmm. The question is whether we should return at all if dcbnl_getapptrust() fails, or just continue to fill whatever other ieee information is available? Seems to be like the rest of the code in ieee_fill() just ignore that error. > > Also, it should cancel the nest before returning. Ack. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel