* Re: [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages
2022-09-26 20:37 [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages Aurelien Jarno
@ 2022-10-26 6:02 ` Aurelien Jarno
2022-10-26 12:31 ` Dmitry Osipenko
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2022-10-26 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter,
Dmitry Osipenko, Sascha Hauer, open list:DRM DRIVERS FOR ROCKCHIP,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
Ping?
On 2022-09-26 22:37, Aurelien Jarno wrote:
> When the avdd-0v9 or avdd-1v8 supply are not yet available, EPROBE_DEFER
> is returned by rockchip_hdmi_parse_dt(). This causes the following error
> message to be printed multiple times:
>
> dwhdmi-rockchip fe0a0000.hdmi: [drm:dw_hdmi_rockchip_bind [rockchipdrm]] *ERROR* Unable to parse OF data
>
> Fix that by not printing the message when rockchip_hdmi_parse_dt()
> returns -EPROBE_DEFER.
>
> Fixes: ca80c4eb4b01 ("drm/rockchip: dw_hdmi: add regulator support")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> index c14f88893868..2f4b8f64cbad 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> @@ -565,7 +565,8 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
>
> ret = rockchip_hdmi_parse_dt(hdmi);
> if (ret) {
> - DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n");
> + if (ret != -EPROBE_DEFER)
> + DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n");
> return ret;
> }
>
> --
> 2.35.1
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages
2022-09-26 20:37 [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages Aurelien Jarno
2022-10-26 6:02 ` Aurelien Jarno
@ 2022-10-26 12:31 ` Dmitry Osipenko
2022-10-26 13:13 ` John Keeping
2022-10-29 13:00 ` Heiko Stuebner
3 siblings, 0 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2022-10-26 12:31 UTC (permalink / raw)
To: Aurelien Jarno, linux-kernel
Cc: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter,
Sascha Hauer, open list:DRM DRIVERS FOR ROCKCHIP,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
On 9/26/22 23:37, Aurelien Jarno wrote:
> When the avdd-0v9 or avdd-1v8 supply are not yet available, EPROBE_DEFER
> is returned by rockchip_hdmi_parse_dt(). This causes the following error
> message to be printed multiple times:
>
> dwhdmi-rockchip fe0a0000.hdmi: [drm:dw_hdmi_rockchip_bind [rockchipdrm]] *ERROR* Unable to parse OF data
>
> Fix that by not printing the message when rockchip_hdmi_parse_dt()
> returns -EPROBE_DEFER.
>
> Fixes: ca80c4eb4b01 ("drm/rockchip: dw_hdmi: add regulator support")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> index c14f88893868..2f4b8f64cbad 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> @@ -565,7 +565,8 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
>
> ret = rockchip_hdmi_parse_dt(hdmi);
> if (ret) {
> - DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n");
> + if (ret != -EPROBE_DEFER)
> + DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n");
> return ret;
> }
>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Nit: all the DRM_DEV_ERROR() usage in this function is inappropriate to
me. These errors should be converted to dev_err_probe(), IMO.
--
Best regards,
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages
2022-09-26 20:37 [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages Aurelien Jarno
2022-10-26 6:02 ` Aurelien Jarno
2022-10-26 12:31 ` Dmitry Osipenko
@ 2022-10-26 13:13 ` John Keeping
2022-10-29 13:00 ` Heiko Stuebner
3 siblings, 0 replies; 5+ messages in thread
From: John Keeping @ 2022-10-26 13:13 UTC (permalink / raw)
To: Aurelien Jarno
Cc: linux-kernel, Dmitry Osipenko, Sascha Hauer, Sandy Huang,
open list:DRM DRIVERS FOR ROCKCHIP,
open list:ARM/Rockchip SoC support,
moderated list:ARM/Rockchip SoC support
On Mon, Sep 26, 2022 at 10:37:52PM +0200, Aurelien Jarno wrote:
> When the avdd-0v9 or avdd-1v8 supply are not yet available, EPROBE_DEFER
> is returned by rockchip_hdmi_parse_dt(). This causes the following error
> message to be printed multiple times:
>
> dwhdmi-rockchip fe0a0000.hdmi: [drm:dw_hdmi_rockchip_bind [rockchipdrm]] *ERROR* Unable to parse OF data
>
> Fix that by not printing the message when rockchip_hdmi_parse_dt()
> returns -EPROBE_DEFER.
>
> Fixes: ca80c4eb4b01 ("drm/rockchip: dw_hdmi: add regulator support")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> index c14f88893868..2f4b8f64cbad 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> @@ -565,7 +565,8 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
>
> ret = rockchip_hdmi_parse_dt(hdmi);
> if (ret) {
> - DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n");
> + if (ret != -EPROBE_DEFER)
> + DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n");
Can we use dev_err_probe() here?
There's no DRM-specific variant, but that is already widely used across
the DRM subsystem.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages
2022-09-26 20:37 [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages Aurelien Jarno
` (2 preceding siblings ...)
2022-10-26 13:13 ` John Keeping
@ 2022-10-29 13:00 ` Heiko Stuebner
3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2022-10-29 13:00 UTC (permalink / raw)
To: Aurelien Jarno, linux-kernel
Cc: Heiko Stuebner, open list:DRM DRIVERS FOR ROCKCHIP,
Dmitry Osipenko, Sascha Hauer, Daniel Vetter, Sandy Huang,
open list:ARM/Rockchip SoC support,
moderated list:ARM/Rockchip SoC support, David Airlie
On Mon, 26 Sep 2022 22:37:52 +0200, Aurelien Jarno wrote:
> When the avdd-0v9 or avdd-1v8 supply are not yet available, EPROBE_DEFER
> is returned by rockchip_hdmi_parse_dt(). This causes the following error
> message to be printed multiple times:
>
> dwhdmi-rockchip fe0a0000.hdmi: [drm:dw_hdmi_rockchip_bind [rockchipdrm]] *ERROR* Unable to parse OF data
>
> Fix that by not printing the message when rockchip_hdmi_parse_dt()
> returns -EPROBE_DEFER.
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages
commit: bfab00b94bd8569cdb84a6511d6615e6a8104e9c
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread