From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5107ECAAA1 for ; Thu, 27 Oct 2022 12:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x1INxjAQ+70+M0RTpx++rj928H3DszxJOLZdHtuJL/8=; b=s6btpskLG6hLb/ /ukp2u17D91kkgqZeAJMszx3NJQeoUy43/AO0aBJKw/LPWr8h/wCoXF5vc3jHkeReF84JOcTltS6H QTT7LvLILOPEktRJ0rpGTD7WzJSy6kWi1dY0p+WqwOzmlOdd4U2Re+YtTP/1ii/24pLVSGg/RYhNJ 0cUmO8XywTRFDwqi7Hrya3UC2rtrq8KomN6Ic6WyqVGt3MRF9f6dB4AmHd8Q1rsig6QrXv+3FMzlp Rx93b3713ek5fOJEOQB/ohkuIyMLe7sB01kVcQsqGmui1rl+Ft8W+2zgauLFce6N82MOS1Y4y2E/o O4Z1j28fZmg4bU63tO1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo1nt-00D9db-4N; Thu, 27 Oct 2022 12:16:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo1np-00D9ct-O4 for linux-arm-kernel@lists.infradead.org; Thu, 27 Oct 2022 12:16:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B80D023A; Thu, 27 Oct 2022 05:16:09 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.1.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07EE03F7B4; Thu, 27 Oct 2022 05:16:01 -0700 (PDT) Date: Thu, 27 Oct 2022 13:15:59 +0100 From: Mark Rutland To: Johan Hovold , Sudeep Holla Cc: Lorenzo Pieralisi , Ulf Hansson , Dmitry Baryshkov , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] firmware/psci: demote suspend-mode warning to info level Message-ID: References: <20221026135445.8004-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221026135445.8004-1-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_051605_856951_230129C6 X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 26, 2022 at 03:54:45PM +0200, Johan Hovold wrote: > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to info level and clearly mark it as a firmware bug: > > psci: [Firmware Bug]: failed to set PC mode: -3 > > Signed-off-by: Johan Hovold On the assumption that we don't have any latent issues in this case, this looks ok to me, so: Acked-by: Mark Rutland Sudeep, does this reasonable to you? Are there any latent issues that mean we should keep this as a pr_warn()? Thanks, Mark. > --- > drivers/firmware/psci/psci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index e7bcfca4159f..f8fa32f0a130 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -165,7 +165,8 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_info(FW_BUG "failed to set %s mode: %d\n", > + enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > } > > -- > 2.37.3 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel