From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5046C67871 for ; Thu, 27 Oct 2022 09:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yRKM+qsfMdSL6NT5Wywo6gfEbbhlFYNE3BcQxOGlId0=; b=ABfdYCONYZ1+oH KSJHOSoCvFmN27yVM5DnMWZn0qssFlrcAVVtAorEZ+cgycB5lVOFwsO3E8opXhkdmk17i12SE+rDn WSK+TuPJONPytBPL3bGum9F5hpcAR32gx4Aden2zmxdRHBQH2pXnue6UstmRzyBi66M2xF4EJUEpn e/Aa5Ta+MnGVB5A3cPHpjTWPEzGo9OQe7fibzDuZAcICGcMWzLD5GsxxKon/RSaLkoQlx56TlAHA8 SCgLwJWevJz5531Jaarz6x5BRKEX6xDAgpFa0ld0/fpdmD3hXeftguJHHxigsqCH13vtXfmpCWc11 4xWgzZrZhxTpdBrA5+sQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onz60-00Ca3R-TW; Thu, 27 Oct 2022 09:22:41 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onz5x-00Ca20-Bh for linux-arm-kernel@lists.infradead.org; Thu, 27 Oct 2022 09:22:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666862557; x=1698398557; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=B2DWWDfUsiKyktfanKjjzgcDXjdREy8+Y3UB+FVi+Io=; b=KM50D+Mw0zhU1t8J6M+hkpA0Xvh58h+DHFjjlG1+0zim+KfKvWL5Xwzh 5Qrz2MNqBjhJbbabIFGic0JbdATnVVfocSx3CT/IlEtU3AYyBa9N+prY4 MUhzUg8u7v0h/j5blcFid0W0JkoGWSKHZOoBjXfC6Ot26YISHXm/gdQNs LGtBeSyNsd5yvUmPaYQ9TDso1HvoIIYfYbdbFAzYWY/de9RsUKAKihIlW sw8gAuEdLLD+Q3ii5/Lw8nKTJSyjEgSvr8v+J69Pmyb958It7sIGag9m8 hh1Skb4EhinXkYk3Afur+Q1jPiWrLpQbZ481aBZCBgrRu3h47C9KvV1jw A==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="309870946" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="309870946" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 02:22:33 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="737607691" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="737607691" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 02:22:28 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 5C07D2026C; Thu, 27 Oct 2022 12:22:26 +0300 (EEST) Date: Thu, 27 Oct 2022 09:22:26 +0000 From: Sakari Ailus To: Prabhakar Cc: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , Shawn Tu , Jacopo Mondi , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Biju Das , Lad Prabhakar Subject: Re: [PATCH v3 6/9] media: i2c: ov5645: Use runtime PM Message-ID: References: <20221026130658.45601-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20221026130658.45601-7-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221026130658.45601-7-prabhakar.mahadev-lad.rj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_022237_466856_83AF1278 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, Thanks for the update. On Wed, Oct 26, 2022 at 02:06:55PM +0100, Prabhakar wrote: > From: Lad Prabhakar > > Switch to using runtime PM for power management. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Laurent Pinchart > --- > v2->v3 > * Jumped to err_pm_runtime label in case of sd register failure > * Now calling pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend() > call > * Now calling pm_runtime_put_sync() in case s_stream(1) fails > * In s_stream(0) no calling pm_runtime_mark_last_busy() and > pm_runtime_put_autosuspend() > * Included RB tag from Laurent. > > v1->v2 > * Moved pm_runtime_*_autosuspend() calls after registering the subdev. > --- > drivers/media/i2c/Kconfig | 2 +- > drivers/media/i2c/ov5645.c | 141 +++++++++++++++++++------------------ > 2 files changed, 73 insertions(+), 70 deletions(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 7806d4b81716..c0edd1017fe8 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -459,7 +459,7 @@ config VIDEO_OV5640 > config VIDEO_OV5645 > tristate "OmniVision OV5645 sensor support" > depends on OF > - depends on I2C && VIDEO_DEV > + depends on I2C && PM && VIDEO_DEV I think you can drop the PM dependency --- the driver will work fine without CONFIG_PM. Although one could question why do we have CONFIG_PM. Some systems won't boot without it and who would want to consume more power than necessary? Could this be removed altogether? Or perhaps we could add CONFIG_PM dependency to V4L2 and DVB? :-) Certainly out of scope of this set though. -- Kind regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel