From: Peter Zijlstra <peterz@infradead.org>
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, broonie@kernel.org,
acme@kernel.org, Andrew Kilroy <andrew.kilroy@arm.com>,
Vince Weaver <vincent.weaver@maine.edu>,
Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
kristina.martsenko@arm.com
Subject: Re: [PATCH v2 1/1] perf arm64: Send pointer auth masks to ring buffer
Date: Thu, 27 Oct 2022 19:25:04 +0200 [thread overview]
Message-ID: <Y1q+8JF7uYlcvasM@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <8eb174c0-c785-c092-96f5-3a4fa3441287@arm.com>
On Thu, Oct 27, 2022 at 03:11:47PM +0100, James Clark wrote:
> Sorry for flip flopping, but I've read those threads that I linked and
> spoke with Kristina and we would like to stick with the per sample
> implementation after all.
>
> The reason is that in the future there may also be a prctrl for 48/52
> bit userspace addressing which would change the mask dynamically in the
> same way as the enabled keys. Although this isn't possible now it makes
> sense to do it this way in case of that, and also for consistency with
> the ptrace feature.
>
> I also think that repeating the mask in this case has a very low impact
> because if you are doing dwarf unwinding, then the whole stack is saved
> anyway, so a few extra u64s wouldn't be noticeable.
>
> Are you ok with that and for me to resubmit with the expanded commit
> message?
But you can send a side-band thing around if/when it changes. Same as
all the other stuff. We don't include MMAP data with each event either.
Yes, the DWARF thing is slow as anything. but imagine needing this for
something else as well, and then you're stuck with it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-27 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 10:19 [PATCH v2 0/1] Perf stack unwinding with pointer authentication James Clark
2022-10-20 10:19 ` [PATCH v2 1/1] perf arm64: Send pointer auth masks to ring buffer James Clark
2022-10-20 16:49 ` Peter Zijlstra
2022-10-20 17:00 ` Peter Zijlstra
2022-10-25 15:28 ` James Clark
2022-10-27 14:11 ` James Clark
2022-10-27 17:25 ` Peter Zijlstra [this message]
2022-10-27 17:20 ` Peter Zijlstra
2022-10-31 13:48 ` James Clark
2026-03-02 16:33 ` Jakub Brnak
2026-03-03 10:38 ` James Clark
2026-03-03 15:26 ` Jakub Brnak
2026-03-04 9:10 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1q+8JF7uYlcvasM@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.kilroy@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=vincent.weaver@maine.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox