From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BFBDC38A02 for ; Fri, 28 Oct 2022 16:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZgHYOlI+zI1mq7g4qFwb5S87mRnlksxAX9kffVXechI=; b=MX7WjcWWhw5QI3 Pm2SH5GyyULftCkyJgkuFQxmqFZKfHcKjW0OSzEouKmVC2KYf5WRe/iZeeNxBaMkyXNOABoY7FbC2 6OrLGHwDMULGKZle0MNRggb8jatjMdcrwLWXHjxyX/9pJo1m6JnnRRudefN/lRPjfij2UKSfKf6iu AdZeS9EEcw2dyQnwDwv9sC7NN60cAb+0MSifY40U9pnlkoSs+9JS21r8zIfgD6m9NgfzLKsZjmypI 53y9UKGY/UAiJHq1D+qjzXLvG6U9S9jJ5OZjHlr171dX+luAtePBjndZUPIlcUADi8NAD3ciPAx9p 8PLblo6HJWhfG2QNVRzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooS1N-000qGO-Sp; Fri, 28 Oct 2022 16:15:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooS1L-000qEl-2A for linux-arm-kernel@lists.infradead.org; Fri, 28 Oct 2022 16:15:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A53FA1FB; Fri, 28 Oct 2022 09:15:50 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 706363F534; Fri, 28 Oct 2022 09:15:43 -0700 (PDT) Date: Fri, 28 Oct 2022 17:15:41 +0100 From: Cristian Marussi To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, Daniel Lezcano , linux-hwmon@vger.kernel.org Subject: Re: [PATCH 7/8] hwmon: (scmi) Register explicitly with Thermal Framework Message-ID: References: <20221028140833.280091-1-cristian.marussi@arm.com> <20221028140833.280091-7-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_091547_171452_50746B9F X-CRM114-Status: GOOD ( 27.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 28, 2022 at 08:58:58AM -0700, Guenter Roeck wrote: > On 10/28/22 08:35, Cristian Marussi wrote: > [ ... ] > > > > + /* > > > > + * Try to register a temperature sensor with the Thermal Framework: > > > > + * skip sensors not defined as part of any thermal zone (-ENODEV) but > > > > + * report any other errors related to misconfigured zones/sensors. > > > > + */ > > > > + tzd = devm_thermal_of_zone_register(dev, th_sensor->info->id, th_sensor, > > > > + &scmi_hwmon_thermal_ops); > > > > + if (IS_ERR(tzd)) { > > > > + devm_kfree(dev, th_sensor); > > > > + > > > > + if (PTR_ERR(tzd) != -ENODEV) > > > > + return PTR_ERR(tzd); > > > > + > > > > + dev_info(dev, "Sensor '%s' not attached to any thermal zone.\n", > > > > + sensor->name); > > > > > > There were complaints about this message as it is noisy. If you send > > > another version, please drop it unless attaching each sensor to a thermal > > > zone is strongly expected. If you don't send another version, I'll drop it > > > while applying. > > > > > > > Ok fine for me. I am waiting to have some feedback from Sudeep too, but > > I do not have plan for another version as of now. > > > > As a side note, though, I understand the 'noisiness' argument, but, > > sincerely this same message in the original HWMON code was the only > > reason why I spotted that something was wrong with the SCMI/HWMON > > interactions and discovered the indexes/ids mismatch...if not for > > that it would have gone un-noticed that a perfectly configured > > ThermalZone/Sensor was not working properly... > > (un-noticed at least until something would have been burnt to fire > > in my house .. joking :P) > > > > Good point. > > Did you ever check the returned error code ? Maybe we could use it to > distinguish "it is not attached to a thermal zone because it is not > associated with one" from "attaching to a thermal zone failed because > its configuration is bad/incomplete". > Yes, it is what I do already indeed, in this regards I mimicked what the hwmon-thermal bridge was doing. In scmi_thermal_sensor_register() this message is printed out only if Thermal registration returned -ENODEV and no err is reported (which means teh specified sensor was not found attached to any TZ), while in the caller of scmi_thermal_sensor_register() for any error returned but -ENOMEM I print: "Thermal zone misconfigured for %s. err=%d\n", since any error reported by Thermal other than ENODEV and ENOMEM means the DT parsing unveiled some configuration anomaly. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel