From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 252D9C4332F for ; Thu, 10 Nov 2022 15:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yl9ZXpNm/U0BY+AIowRiaJh9rHcaVmX2VrSvhmx8VtI=; b=igT3f8GJiaUqqf S4M6e+iAATDSUi3YoZMA5IfMIXbkcjQnv0G9DcZT/+ZpOQvWXQ2jkq+SuoBet6484amiN/t7rGcby VD2hUk6meDbjnsLZP1zIB+DDcjLOW85WSP3HQ3uTJEby9hF+4iMvIr/MtTKoacKjfqlelu2v1wPv7 ajV6nF+2+84Z9HpzxDT3x414p38V3irmY4APLTw9VIY/ydcWyE4R5I8F3A2L0ZOmkd90K8UBs68VM VXML40XmZDLZaQI+hBEu6VlIWAwWffYyJfqvSmBDcPB4ixCZ8eJGjLePCAeDOjt28ou4UeS8Ed8HE g0CETMHmAZFmJzi5a9Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ot9lB-006rRY-58; Thu, 10 Nov 2022 15:46:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ot9l8-006rON-1w for linux-arm-kernel@lists.infradead.org; Thu, 10 Nov 2022 15:46:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C5CE619EB; Thu, 10 Nov 2022 15:46:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E36AC433D6; Thu, 10 Nov 2022 15:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668095186; bh=8+ybaYZAUyINGuNsj7DH9SA7OaDsVF3+kjAbxxrzbwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oFObpICzgxHrbiI23QIbQIxFbcwkqzzf+460dzMmU7oKyit2Zoy3yQWsvKeYBW8vL ybdco3UZaSFPxq+dleMn4rgk9GbwfQ0QjGazOlphdoIfgDewCYfb1uQs3xbNh0Kujk eDLl+FVX/22WM9qxdlToCDDm7Xz5wBInCLTfdXD5+Q8qQUlxZoMqqd86yu/yq3Beia VJgBDqh4GPTUEt7ff0+9sUICM1+CanCKfePnv/73SMqK4v4AWrGExzw2F9giAIC8Bx zIZHNmxTCt0Jyhjc6dfOqppHLlceyZzYaUX5gcbamHGVQ5K/sG0eovd8Qoi2tcsdZV qevBGuGVi++FQ== Date: Thu, 10 Nov 2022 16:46:21 +0100 From: Lorenzo Pieralisi To: Matt Ranostay Cc: vigneshr@ti.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 1/4] PCI: j721e: Add per platform maximum lane settings Message-ID: References: <20221109082556.29265-1-mranostay@ti.com> <20221109082556.29265-2-mranostay@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221109082556.29265-2-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221110_074630_210238_4DDD1BC8 X-CRM114-Status: GOOD ( 20.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 12:25:53AM -0800, Matt Ranostay wrote: > Various platforms have different maximum amount of lanes that > can be selected. Add max_lanes to struct j721e_pcie to allow > for error checking on num-lanes selection from device tree. https://lore.kernel.org/linux-pci/CAL_JsqJ5cOLXhD-73esmhVwMEWGT+w3SJC14Z0jY4tQJQRA7iw@mail.gmail.com Why have you reposted this patch ? Lorenzo > Signed-off-by: Matt Ranostay > Signed-off-by: Vignesh Raghavendra > --- > drivers/pci/controller/cadence/pci-j721e.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c > index a82f845cc4b5..875224d34958 100644 > --- a/drivers/pci/controller/cadence/pci-j721e.c > +++ b/drivers/pci/controller/cadence/pci-j721e.c > @@ -48,8 +48,6 @@ enum link_status { > > #define GENERATION_SEL_MASK GENMASK(1, 0) > > -#define MAX_LANES 2 > - > struct j721e_pcie { > struct cdns_pcie *cdns_pcie; > struct clk *refclk; > @@ -72,6 +70,7 @@ struct j721e_pcie_data { > unsigned int quirk_disable_flr:1; > u32 linkdown_irq_regfield; > unsigned int byte_access_allowed:1; > + unsigned int max_lanes; > }; > > static inline u32 j721e_pcie_user_readl(struct j721e_pcie *pcie, u32 offset) > @@ -291,11 +290,13 @@ static const struct j721e_pcie_data j721e_pcie_rc_data = { > .quirk_retrain_flag = true, > .byte_access_allowed = false, > .linkdown_irq_regfield = LINK_DOWN, > + .max_lanes = 2, > }; > > static const struct j721e_pcie_data j721e_pcie_ep_data = { > .mode = PCI_MODE_EP, > .linkdown_irq_regfield = LINK_DOWN, > + .max_lanes = 2, > }; > > static const struct j721e_pcie_data j7200_pcie_rc_data = { > @@ -303,23 +304,27 @@ static const struct j721e_pcie_data j7200_pcie_rc_data = { > .quirk_detect_quiet_flag = true, > .linkdown_irq_regfield = J7200_LINK_DOWN, > .byte_access_allowed = true, > + .max_lanes = 2, > }; > > static const struct j721e_pcie_data j7200_pcie_ep_data = { > .mode = PCI_MODE_EP, > .quirk_detect_quiet_flag = true, > .quirk_disable_flr = true, > + .max_lanes = 2, > }; > > static const struct j721e_pcie_data am64_pcie_rc_data = { > .mode = PCI_MODE_RC, > .linkdown_irq_regfield = J7200_LINK_DOWN, > .byte_access_allowed = true, > + .max_lanes = 1, > }; > > static const struct j721e_pcie_data am64_pcie_ep_data = { > .mode = PCI_MODE_EP, > .linkdown_irq_regfield = J7200_LINK_DOWN, > + .max_lanes = 1, > }; > > static const struct of_device_id of_j721e_pcie_match[] = { > @@ -433,7 +438,7 @@ static int j721e_pcie_probe(struct platform_device *pdev) > pcie->user_cfg_base = base; > > ret = of_property_read_u32(node, "num-lanes", &num_lanes); > - if (ret || num_lanes > MAX_LANES) > + if (ret || num_lanes > data->max_lanes) > num_lanes = 1; > pcie->num_lanes = num_lanes; > > -- > 2.38.GIT > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel