From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDFC4C433FE for ; Thu, 10 Nov 2022 22:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JhwypBjXaSwqlwpmx+I0k6+i79KdpVFlOWYsqBDMJf8=; b=b2RimuqJdrzfZL gs/HSiltDsO1fjItSycFQ8fycHkV4X3dhXHmABKpS1hvr4HyaBBSAEQYA3xpehL5g0auUD/03OiuU m2HTfZSBjuKKQggF/hlmeaMMihV2JHa40mRN7sL3iINmFZRxa8UnSSzyXgbydHmOEEUWuvqdvENd6 BjMoKbBDHE7Te8m9GrhZauriI1iEDiTUj4VKZXzx8/Nh9IdxpIr/KRWUTHrB2QbXIChUf8Z97m/qR N5R5anzEvOSdUGR52tfAz5rxbiqnn18psG/rTJU/JyNWeHG011jP+lqXwcUeMexC6M66Aje+nJeT/ lklu5+Wak+aDe+GMtHzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otG6o-00Ajm3-3k; Thu, 10 Nov 2022 22:33:18 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otG6k-00Ajjm-Mn for linux-arm-kernel@lists.infradead.org; Thu, 10 Nov 2022 22:33:15 +0000 Received: by mail-pj1-x102d.google.com with SMTP id r61-20020a17090a43c300b00212f4e9cccdso6176604pjg.5 for ; Thu, 10 Nov 2022 14:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8gY/OzJoPnw06nvF/ax1dzsyttFIg/d8ctj7MuL258E=; b=M+4u4lcZ0g8mC7ch0OT4x5PLDybVoticZj3bC8HjO0tdR+1iL639F8CnsHSzkCO75v xq+TTSX9X81HBms18pplxiyp73xjplqMJyC8NOu2cLnB+Pv1TUaLwYu92VpnUs1lta57 +TKvsOynQ7nkn3rHnIAm08/WyKt7pjRXcLsbA2pWt6xXpSEOX4/1uLNz7Wm6CXiKhBkP Q1kBOIwCb5EEKVJsYP/jf2GoNVtIfEk3aiwiZ/RMufstZm3QXYX5POHepKlBZQ8O25yN ifLSDAFG1y3pzyqP+q0ANwOqz7EBlx2rvM9koKUZAD5x934+tzva5HcE4lZvf0Q5eIQ+ mjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8gY/OzJoPnw06nvF/ax1dzsyttFIg/d8ctj7MuL258E=; b=a9V++yrGqzsBbcwDqej9QR+r3czymRoo2CiBNBavGeBDfL1lN7cL+qhObKEfaQcRDZ 9rF2jGObVm+wwpUrWh1tjEVnwcdMNNYz+gCLY2znAP9ORLaG8yQSpJdHMouBVteb5b39 4gcF43v6QOMrsjv8+tvAtsMtN80HsHCWeAx7GzGi2/IYyHgYcjwDeeN77XiiAvCkFWaY kA2iIYNba8KHIoJQEIg8xVEV38Mi/yaicocie5T1k82LLsKxzRfdWeGummBxNt3cjIhg k48NHz2JA7RQ4MMmYdOqbPsgzrL8ZbEimEHIiBgn1rm3fx1JolmY4cVUnQpNy3BiJIWS qWbA== X-Gm-Message-State: ACrzQf258M8SvsKppJykRLx/nt4oPdX245uHQhOfsplIW4fvmc8Y8/d+ xQdtd+5jnNGhIB4O5kOiJHg= X-Google-Smtp-Source: AMsMyM4uxqy0CAq22wSngxYpEuQrP/za0C3jljiPdLH6FvdkUTfDrtGBxiG84ErK0aCiPHpUkUU35g== X-Received: by 2002:a17:90a:8503:b0:212:9b3f:dee5 with SMTP id l3-20020a17090a850300b002129b3fdee5mr2317401pjn.62.1668119590803; Thu, 10 Nov 2022 14:33:10 -0800 (PST) Received: from google.com ([2620:15c:9d:2:2eb5:1c59:61e8:a36d]) by smtp.gmail.com with ESMTPSA id l5-20020a170903120500b00186727e5f5csm164375plh.248.2022.11.10.14.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 14:33:09 -0800 (PST) Date: Thu, 10 Nov 2022 14:33:06 -0800 From: Dmitry Torokhov To: Linus Walleij Subject: Re: [PATCH] mmc: atmel-mci: Convert to gpio descriptors Message-ID: References: <20221109043845.16617-1-balamanikandan.gunasundar@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221110_143314_768949_C7D84814 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-kernel@vger.kernel.org, Balamanikandan Gunasundar , linux-atm-general@lists.sourceforge.net, linux-mmc@vger.kernel.org, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, 3chas3@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Nov 09, 2022 at 03:48:32PM +0100, Linus Walleij wrote: > On Wed, Nov 9, 2022 at 1:39 PM Ulf Hansson wrote: > > On Wed, 9 Nov 2022 at 05:39, Balamanikandan Gunasundar > (...) > > > --- a/drivers/mmc/host/atmel-mci.c > > > +++ b/drivers/mmc/host/atmel-mci.c > > > @@ -19,7 +19,8 @@ > > > #include > > > #include > > > #include > > > -#include > > > +#include > > > +#include > > This is nice, but higher up the driver also #include > so delete that line too, should be enough. > > > > - of_get_named_gpio(cnp, "cd-gpios", 0); > > > + devm_gpiod_get_from_of_node(&pdev->dev, cnp, > > > + "cd-gpios", > > > + 0, GPIOD_IN, "cd-gpios"); > (...) > > > pdata->slot[slot_id].wp_pin = > > > - of_get_named_gpio(cnp, "wp-gpios", 0); > > > + devm_gpiod_get_from_of_node(&pdev->dev, cnp, > > > + "wp-gpios", > > > + 0, GPIOD_IN, "wp-gpios"); > > Hm. Dmitry is trying to get rid of of_get_named_gpio() I think. > > But I suppose we can migrate to fwnode later. I'd much rather we changed this right away to devm_fwnode_gpiod_get(&pdev->dev, of_fwnode_handle(cnp), "wp", GPIOD_IN, "wp-gpios"); and not added new users of devm_gpiod_get_from_of_node() which is there only 2 left. Thanks! -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel