From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C0E3C4332F for ; Fri, 11 Nov 2022 12:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lKUAx95UDW3X23PXVTxz/fhcM8h3CoQQCeXOMyP6TaY=; b=A9qhvG2NkBXln8 6fEw4yQzCeaLaAQR2kFlb/vz4JhljpFtyCj4Vs/BUtOEzj7y/ICqDf5gN9fVfE+VWC4/c6g+FJL2F RU3Jg5DsJxnplzADOavtygwGCGAbCoaJsdNTu8TvTwOIATrSvfDzEWmbYs72fGVQAcSLi2KA6waQ+ aKfFPQYI86cN3dSIcRA8h4U8phv2zpPT5GvjXc9JKT4hdRAcfKWis3OAD8807q2Yexuef/0ATJfT3 /xvvYC+ZPo9agl1j5BxAUQAes5gRyPV1rvAsfsze2dHi3TLlaLawUrJFGQ1gah0YD1oTvkZuT1/D0 1Y9xqZe/s5uEwkfCqgTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otTU5-00FhIs-1m; Fri, 11 Nov 2022 12:50:13 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otTU2-00FhHZ-7V for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 12:50:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EF81AB825CB; Fri, 11 Nov 2022 12:50:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8B4AC433C1; Fri, 11 Nov 2022 12:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668171006; bh=GAavfGouJoMBVmmtszykMzzVERLoQ9KGrTioGqlEo8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OM9OSe8MtUORc6Uan7a1ovFGnIWezcdmGPYI9W9j9WARVvGd+8ipo8JwUW62XG39E ieO7NMK3bc6TYXks/QFOo8Nc7VhrmH7nG6IhRq938xZ4PnAH4C1vVd8GadMV+7s0Eh HG6fYLWfakJw+jRoNZgr4XbMpbHwdrBq3onnB2rAecCuuuhvP5R7r6hdN8da1gp14A gXUX4esWTRMnRZVyFeeOWZksKtATh2XRBa6YyxWoFiq6Qw/s/7UQVQygb3l8fGSPZr AgfLIxXMBfk1joSeAYfbyNxI5Z0Y0uvCV6la+5gj2ZtQ6L0QFuPwMpC7ExCEfYVkqZ SvQr/HZZ38a2g== Date: Fri, 11 Nov 2022 13:49:57 +0100 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/7] PCI: mvebu: add support for orion soc Message-ID: References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220905192310.22786-1-pali@kernel.org> <20221106232824.du4uou6pf77rqu45@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221106232824.du4uou6pf77rqu45@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_045010_603584_0480634B X-CRM114-Status: GOOD ( 34.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 07, 2022 at 12:28:24AM +0100, Pali Roh=E1r wrote: > On Thursday 27 October 2022 16:10:48 Lorenzo Pieralisi wrote: > > On Mon, Sep 05, 2022 at 09:23:03PM +0200, Pali Roh=E1r wrote: > > > Hello! This patch series add support for Orion PCIe controller into > > > pci-mvebu.c driver. V3 version has completely rewritten pci-mvebu.c c= ode > > > to parse all physical addresses from device tree files according to > > > mvebu-pci.txt documentation, allow access to all extended PCIe config > > > space registers and use modern kernel API pci_remap_cfgspace() and > > > mvebu_mbus_add_window_by_id() fir mapping PCIe config space. > > > = > > > Most of Marvell device tree code in pci-mvebu.c is giant magic, but i= t was > > > there because this change and it is de-facto API between dts files and > > > kernel used for a long time. Note that it is misused according to PCI > > > device tree bindings, but we have to follow this Marvell bindings to = do > > > not introduce backward incompatibility issues for other non-Orion > > > platforms. > > > = > > > Mauri tested these changes on DNS323 board with both DT and non-DT bu= ilds. > > > PCIe AER is working too (one of the feature which proved that access = to > > > extended PCIe config registers is working fine). > > > = > > > After this patch is accepted we are planning to look at existing Orion > > > arch specific code and covert it to use this new DT based pci-mvebu.c > > > code. Later this would allow to kill arch specific Orion PCIe code, > > > which is in arch/arm/plat-orion/pcie.c and parts also in file > > > arch/arm/mach-orion5x/pci.c (shared with old-PCI bus code). > > > = > > > This patch series depends on another patches: > > > https://lore.kernel.org/linux-pci/20220524122817.7199-1-pali@kernel.o= rg/ > > > https://lore.kernel.org/linux-pci/20220817230036.817-3-pali@kernel.or= g/ > > = > > Can this series be rebased please on top of v6.1-rc1 so that we can mer= ge it ? > = > IIRC above two dependent patches still applies on master branch and this > patch series applies on above two dependent patches. Which I can't merge for reasons you are aware of already. So, does this series _really_ depend on the two patches above ? I don't think so but let me ask again. Lorenzo > > Thanks, > > Lorenzo > > = > > > Mauri Sandberg (2): > > > bus: mvebu-mbus: add configuration space aperture > > > dt-bindings: PCI: mvebu: Add orion5x compatible > > > = > > > Pali Roh=E1r (5): > > > ARM: orion: Move PCIe mbus window mapping from orion5x_setup_wins()= to > > > pcie_setup() > > > PCI: mvebu: Remove unused busn member > > > PCI: mvebu: Cleanup error handling in mvebu_pcie_probe() > > > PCI: mvebu: Add support for Orion PCIe controller > > > ARM: dts: orion5x: Add PCIe node > > > = > > > .../devicetree/bindings/pci/mvebu-pci.txt | 4 +- > > > arch/arm/boot/dts/orion5x.dtsi | 51 +++++ > > > arch/arm/mach-orion5x/common.c | 13 -- > > > arch/arm/mach-orion5x/pci.c | 14 ++ > > > drivers/bus/mvebu-mbus.c | 26 ++- > > > drivers/pci/controller/Kconfig | 4 +- > > > drivers/pci/controller/pci-mvebu.c | 202 ++++++++++++++--= -- > > > include/linux/mbus.h | 1 + > > > 8 files changed, 256 insertions(+), 59 deletions(-) > > > = > > > -- = > > > 2.20.1 > > > = > > > = > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > = > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel