From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50D92FA3741 for ; Mon, 31 Oct 2022 21:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VTpvlvXTcxBbQBwkC5JmWmBhN1V39bZSFmM89Wgdf2I=; b=oXs3XFOKcUe+Ve l5KBTZQqmDyeXG2gUyApEezYdZ/zbq/++pwP1KrEz/4h9YoLO4KQxw745qRuuZfZhmOor5ekB/Yqe SX8Vu0Ek7kFV7Y/Z47uT+2DyLkBUHD3YsvGtD8BSWuQaemDAtgRbpmuvl3xqFtqkpUaW8QnlkAx64 WO7RtcsYTdXYYgKRm6yggFambjVmYCFd6LKMSq8d7BRyjDPF8lILTSO75W0QOgrEHPeDMMmU33Jbk qiwmIsa4nHUpPx2g/1GHVh1VLW70U3E9Z1wUhOjAgzMMiE4+vwG+vYHeeQEM18YMVsgQQd795FZN6 tBYtMKMHreuF5GRfizhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opcZR-00Fign-U8; Mon, 31 Oct 2022 21:43:50 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opcZO-00Fifx-MV for linux-arm-kernel@lists.infradead.org; Mon, 31 Oct 2022 21:43:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 022326126D; Mon, 31 Oct 2022 21:43:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C637C433D6; Mon, 31 Oct 2022 21:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667252625; bh=OV+Emfko/aFFz96PUD3FSyolO7/BrZKHPhq8GdChW9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W0spE6FALWLJtsYHwaHO7/Yws6RX4KlSswjZatRmnm29lrHDh4/6AYgE4jGwnUeLW kBbKOaUFcy+XddKd7sPxBP9DxS/8bVPsD5aplkdPm+U6gDOgAxZDSs0KznjFoCauW8 2z6gLOoyIolq6X0Tq95hHVl1L3P19FaDKVevToISvq0zA2E+e2IFUtCpFNqLUV/l5Q k11Jwzy4As3PhzHpep2HtaLhdqVytLKwPFtkEYaj/KWkRLn2rmWanLZugwZgz+VJFn UOCUGau53ESCwDqORoMiBKsxr+ZCSQK/9FKPutr/9HVQI5sxYQ3r7O+6sp2oQXN/MS PwPqd93L95xmQ== Date: Mon, 31 Oct 2022 14:43:42 -0700 From: Nathan Chancellor To: Nathan Huckleberry Cc: Dan Carpenter , llvm@lists.linux.dev, Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Nick Desaulniers , Tom Rix , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid Message-ID: References: <20220913205544.155106-1-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220913205544.155106-1-nhuck@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_144346_832142_2864A897 X-CRM114-Status: GOOD ( 20.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 01:55:44PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); > > The mismatched return type breaks forward edge kCFI since the underlying > function definition does not match the function hook definition. > > The return type of imx_tve_connector_mode_valid should be changed from > int to enum drm_mode_status. > > Reported-by: Dan Carpenter > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > Cc: llvm@lists.linux.dev > Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Can someone pick this up? It resolves a new work-in-progress clang warning that we would like to turn on for the kernel: drivers/gpu/drm/imx/imx-tve.c:320:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict] .mode_valid = imx_tve_connector_mode_valid, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. > --- > drivers/gpu/drm/imx/imx-tve.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c > index 6b34fac3f73a..ab4d1c878fda 100644 > --- a/drivers/gpu/drm/imx/imx-tve.c > +++ b/drivers/gpu/drm/imx/imx-tve.c > @@ -218,8 +218,9 @@ static int imx_tve_connector_get_modes(struct drm_connector *connector) > return ret; > } > > -static int imx_tve_connector_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > +static enum drm_mode_status > +imx_tve_connector_mode_valid(struct drm_connector *connector, > + struct drm_display_mode *mode) > { > struct imx_tve *tve = con_to_tve(connector); > unsigned long rate; > -- > 2.37.2.789.g6183377224-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel