From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A18ECFA373D for ; Tue, 1 Nov 2022 09:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YV9/qdpKes2CGNyz2znYQgQR1e7UiXLg+E10KSyFdB8=; b=CA5YDgUcUXecFy zoSYEF9tFYcGBzU0J2V04OqOWtfpcAB77kgGM+HTBkc/dWECJzzKGZE549IM9hCtVN+7Y/31Fazc1 9/vx8vzGFwzM7gr6wGY3G+YR9oFu2SBv4HmgvvmL3YqB9ke9NA1s5yb+ugZWp9lWDZIacs2QX/gw4 QegXM9QjD19AELk0N4H7CMWrZ3y0PVYn2JCcb8iGbg9ozb9LkuA+Tryq1aFisxZZf+Mi6ejkQkNm6 cAAIseTQ9iQlvpSE4pIR1ptGYrS6WnKXunEoJf6AcIYTfQz10DUgKJD2WVOruLWCRMISEGMyPGcFi RIZvvwoX5bP3r5erlwdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opnJF-003VdA-2o; Tue, 01 Nov 2022 09:11:49 +0000 Received: from mail-eopbgr70087.outbound.protection.outlook.com ([40.107.7.87] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opnJA-003VSV-LH for linux-arm-kernel@lists.infradead.org; Tue, 01 Nov 2022 09:11:46 +0000 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TO1bhBRPaD5LFCdo+8CsfzxHeryVCYOtLY9ZXL0iv2yQGR3nCrqGKru6wzWFRTs93d83ClC+Jbveog97L1ktyDPV6ygnhnHk3i9+jLW9/aPtDYu5JL/ZYZbn7Wxlsa1IUu8RnfZYH2YssxoPF79xvlr2kyJiaaWqgkY3Onch575INHRCltdchVMrJfLcAgILoCw9n7G3eMrT6AZ39zFtMkHDTgOh7uxVo15YmmtEQHQNdzYrAKpLxuDO/YfHiLbop0g1h4nw9Le+Ou4iz1OUyDr5QAEIgY/CpoCdb6qttJbipL8cOeLjjnN04BSWZ36M0tqK6VW2CDrl5HJwxjh9oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuQOb0ZvNm5BeuwPc9IM5rK/+6Fi1bBnuKNi1TWMwFc=; b=fmobU6Bp59hPa0ivHHZazuMuz62+MLX8g3dfyaNYaqiHhkVixPJv+rKKW5cdU4NGP4dd8nYmKLv3/m0GaU5r0dft6TvVeLZ8eRSOqBxAoNw34/kE1IMxUVOYP2xQOmbIJAoHPszBNK2AegDU9JQ1q1SPEiWzm1AWK6Z/yREcLdHXCp43SCWIqV2N092G7jfHhYnQHKmo6Ce7l4kWyQZKrJQUcfBcNOVEfmIgzFh/jU3/4B08/9qncYElTS2ij7gAYJCTxqFnXPNSSdHAp3uSBe9IcxQ5pm/pfsm1jSojKPWMcYEKEvk2//6h/DmX3lk7EF8YMJaBmeAub3E8JvUwpA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuQOb0ZvNm5BeuwPc9IM5rK/+6Fi1bBnuKNi1TWMwFc=; b=Em0tDxqw2/KfWBWFw+4kEezK5gs2hcOBJBCktTWvcig4qpAreV3Q77CdZKHPAfAH+Dh7KDYJrsiWIMWGW3pssWTSfupf78Yld5Dr1qU5FxeRb8vfe/tInmfpzRHbTWV7C+BkkQf6EwUyxBn+I4lw8k42bc0UjgLMtjb7ybKKh7U= Received: from AM5PR04CA0025.eurprd04.prod.outlook.com (2603:10a6:206:1::38) by AS8PR08MB8707.eurprd08.prod.outlook.com (2603:10a6:20b:563::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Tue, 1 Nov 2022 09:11:38 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::3d) by AM5PR04CA0025.outlook.office365.com (2603:10a6:206:1::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16 via Frontend Transport; Tue, 1 Nov 2022 09:11:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Tue, 1 Nov 2022 09:11:38 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Tue, 01 Nov 2022 09:11:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1233362068768165 X-CR-MTA-TID: 64aa7808 Received: from 7ec27c160198.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1F03189D-A1F3-465F-B9EF-46E6490BDA66.1; Tue, 01 Nov 2022 09:11:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ec27c160198.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Nov 2022 09:11:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lidVBavqGjkac3AY+pluNrFOsQQmFcIvEhKF4vtX6khn+OX75yx3Qp2JvixDlkD2PEIWyjQ0lCNvXuZ94nHjAqZkvHjg2KEFs7O5HDelpmnNdcZ9Hz5m62o2mtdpYuDpJivSO/gZ01jD3Gt4aBbYI5qfsTVR0koXis804oDn4LHxz89lH1+HaE6MpH3rQd218gebw1OtLeBnsuPSfth2NkGKxUz2IfALoOODVVnUWSfvBeYz4V+RpC0oX0UwRQyf9S4gwXPQDWr67n1s6KOhXDnucXnuxUgztFzwdWvAjo4M6IygMPnM/C8owMMzdz9TFDBNKcLV8cKMCnNPPIJL8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuQOb0ZvNm5BeuwPc9IM5rK/+6Fi1bBnuKNi1TWMwFc=; b=XHteTLrWtb28JxCNIGjAmLrH0bdZLr6Pz4Ml5mOdOqwjdv70XOUOSQM5WBcFWtHjiPnnvy6DTZsPmc5ZvVqG5XpQwy8l0JwxW3hRdDcnPnEasIML4qpsVNvpb8KJbcdVE07HPE1PhhC4V9+C0U/sCcVXurVGJbVcxRQ6zBfnlOXwWIBKP6mokSDz/mLWR86cezbQWoxt1I3nmOeQz3FCTeX9vFXhPxLe2nFZ0mcNMPTkqdraS97M5TSw3NXmbGkNPPSsgYVKmFCY6vG6PbPMuX6i6x5p/KbXCtHzbSZxIpv9KzAegSeIzncJLpp7o6B7f5icZtaZY2BqqntYWDsgng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuQOb0ZvNm5BeuwPc9IM5rK/+6Fi1bBnuKNi1TWMwFc=; b=Em0tDxqw2/KfWBWFw+4kEezK5gs2hcOBJBCktTWvcig4qpAreV3Q77CdZKHPAfAH+Dh7KDYJrsiWIMWGW3pssWTSfupf78Yld5Dr1qU5FxeRb8vfe/tInmfpzRHbTWV7C+BkkQf6EwUyxBn+I4lw8k42bc0UjgLMtjb7ybKKh7U= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS1PR08MB7516.eurprd08.prod.outlook.com (2603:10a6:20b:483::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Tue, 1 Nov 2022 09:11:29 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8999:7c8d:d088:d198]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8999:7c8d:d088:d198%5]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 09:11:29 +0000 Date: Tue, 1 Nov 2022 09:11:15 +0000 From: Szabolcs Nagy To: "Theodore Ts'o" Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: linux interprets an fcntl int arg as long Message-ID: References: Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0404.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::13) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS1PR08MB7516:EE_|AM7EUR03FT022:EE_|AS8PR08MB8707:EE_ X-MS-Office365-Filtering-Correlation-Id: a28b0fe1-afe4-4008-e348-08dabbe9154a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: effhx6OoF12KPBoOLd3YiH/KUanAfqguc/6N+JRmGdyY9TMpqjleZnAmHe2jdDjTVhSvzmBJa63NFqqxoqCyFqSsLx6gz2yBuHI5qCUcsOtg+f4VA7gzWBVLrnGTnoLqRWGNc8JBRA65kv1sCOhEIaB8IWyAiCx/BF/vpMQ7LO0+yk+kqf56AATsovQJZ2xVHbmuAyB7F1zIw20JZpBIoO/JxRDpWClu/HPtlbuaBiIdtsAFtK9ctM97UdaaSiqCBlbCdN6OvIwG0s1NEOYUBzoi/SV9UGk5qPPM1D55a9g1HMOgXTCzJhrtEXXO3GKn8VkAW/POtkMU7uu3Xo1cvU55bhn6kyAj8FhYQTgHD+eq0l1+b79oZFJKt6j4TEjlNcWbTNyxPogp16unNAdzmheEdVDcefr2KaS9jRrAdDUl/gyBB74ik2VlfTipJc7g10AMnN91k+1S+IkqeCJ8njL9TInwRsYChfdgzA2umTwxo6qd0iS6NL/mxcr2WT7IRDWJ1I9LGtmLtMzo4rMHAw/CWIQUEjzE4HDYJsr+0D8YBN8/rwIfORZ92CbFNjURhAttxzf/Jm5Aw36VjhMt/9C7GBTFjxStRjdQ3fz1B5rIpE2dH9qjat9EEqs79Gea+lsrYqzpEnb/AxIzAKjEsFyqjfRVS/V7qotiryRFbViYcXVIxEWpgAqnUG46HclH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(451199015)(44832011)(5660300002)(2616005)(6666004)(6506007)(86362001)(66946007)(66556008)(6512007)(36756003)(26005)(478600001)(8936002)(2906002)(6486002)(66476007)(8676002)(4326008)(38100700002)(316002)(186003)(41300700001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7516 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3c8c53df-6323-4b32-ceff-08dabbe90fbd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tg/lEkD7882ICSKoaNbotBTJyZYSRl+cSMBtdWnxHkhTRD9o1AK1zfdtWXQ7FAS3o5cUaYXOrJWZTsPizL50cSypoCeEUrxxbbodYg7kpZtVahC9lAwCHDljjvoq3JLInezwcSd9/cQoaWKv4DjQt1N83Afo/P0BrIJFZgp6kWi4fepoWrEtrq2q5IHnTLk8yHvKR84EeM8vmE4hDC/tKhay3JRZJ9G2OoNFC8qokIh76mMpqLfhpFzWyHUlwifDLAzwXmbpEMC7A9lIKbasJ66JCVvhtvrMeZVIhKQwRzdXnGRG2zMFRHrgjltp2gVmYRnHd1vYE6aSgVbqHIcnFNW2hxPRJp1yUveuk+pUpxS6K54m/o2oUUxMLQnDlm/VIEy8yQ0QSAui6U7avwjQgJoy0MZ6Jwuw/KH/5zTDMQKz7gNLKcSevnKa+d/bWcw2yxEEjGnWm93bKIut3L7iycbQ88ilO9ICt8vOr17bkgY2Q9LuhEsepMwW1rwElqn/fueu2BEFSLMW+GSPgIjGtAMkqOED/csfZN4cLi5e8Yf/CMauIGxkzQlqErxVFOSnVbb4oxhZF1gWzDMJhf8LsRivwc/+FrmXwnvepE5eDJms3c90pXn+sAxK40j6ttYkhRAds8RxiTUbKF3ngv5NYJL4sFhTUtxvYwOhc6wzkJKCxd8eVEnQN8IXd5nCrvVRK3AS9ri8nXMlRNMU77ySsJuoVs/DzEkaA7NREjNOQ+jdCm57WQ67vYoEwF8TlqS/nEli4/ZZQVhnUxFvG3DkmA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(36756003)(36860700001)(356005)(2906002)(5660300002)(44832011)(86362001)(47076005)(81166007)(186003)(6512007)(478600001)(6486002)(2616005)(40460700003)(316002)(8936002)(82740400003)(336012)(70206006)(8676002)(70586007)(6666004)(26005)(6506007)(41300700001)(4326008)(6862004)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 09:11:38.4725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a28b0fe1-afe4-4008-e348-08dabbe9154a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8707 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221101_021144_733304_1D449D03 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 10/31/2022 21:46, Theodore Ts'o wrote: > On Mon, Oct 31, 2022 at 12:44:59PM +0000, Szabolcs Nagy wrote: > > and such fcntl call can happen with c code that just passes > > F_SEAL_WRITE since it is an int and e.g. with aarch64 pcs rules > > it is passed in a register where top bits can be non-zero > > (unlikely in practice but valid). > > In Linux's aarch64 ABI, an int is a 4-byte value. It is *not* an > 8-byte value. So passing in "F_SEAL_WRITE | 0xF00000000" as an int > (as in your example) is simply not valid thing for the userspace > program to do. > > Now, if there is a C program which has "int c = F_SEAL_WRITE", if the > PCS allows the compiler to pass a function paramter c --- for example > f(a, b, c) --- where the 4-byte paramter 'c' is placed in a 64-bit > register where the high bits of the 64-bit register contains non-zero > garbage values, I would argue that this is a bug in the PCS and/or the > compiler. the callee uses va_arg(ap, type) to get the argument, and if the type is wider than what was actually passed then anything can happen. in practice what happens is that the top bits can be non-zero. many pcs are affected (aarch64 is the one i know well, but at least x86_64, arm are affected too). and even if it was aarch64 pcs only, it is incompetent to say that the pcs is wrong: that's a constraint we are working with. the kernel must not read a wider type than what it documents as argument to variadic functions in the c api. (it does not make much sense to expect anything there anyway, but it can break userspace) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel