From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C414C433FE for ; Wed, 2 Nov 2022 05:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FXQYd1keY/rF/B1X4dsd+nLtRC8fm5z+0Sgeu3oeh40=; b=uoAOTi7rEu4oCx UhxFP7mR4NjuqWH+ZcuTHYq6xAwB5Fx1+NprRRhjKaGhKnIX4P++0jBYTwwtPDgaQHLeIhLkX0GTo /yPh9MlDnLT9Nwgw+5AtMmYMeyZQMXPQZ+jntkNsX4Ks8nDTQO5HuEMhVPVfPg6yxfslJFI9fdfhJ OTt2+bu1C3DcerIBEjeudvBcM/cNJ3qu5g7csjYIzZ1rYl+A8wmFfTwuBFBaVrAQ8epTVenxWPhgp xdEWf68nd2wNPd+xSi4L/n8mRsmO3gd/8nSYEEWw5W6rJePdJ7C/s4N0AxjsLGGS3VSYPvOjkTN/T Ib9q7nUEEBEou7j9RCKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oq644-008HZu-5I; Wed, 02 Nov 2022 05:13:24 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oq641-008HZN-MZ for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 05:13:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 06DD7B82065; Wed, 2 Nov 2022 05:13:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71C23C433C1; Wed, 2 Nov 2022 05:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667365997; bh=X5ownL5/SLGdv+si92x3oobTQIguLhc5vCym52Z20MY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HyxuQLit/4cmu7jRRg4Fdl0RP3BH8N7DjW1mWNS8QOmSNwnnHFn5CwDpKQ8MTnS3R HKjFlUAElj2+daojXwgjVtioze5al16rvPm3jpfeUD1QSgeQMLv4sVH6n1b55ozHCE 5iZVIvLfmc3kTSFzrTj9MuSs+ole19eoTiNESdjA= Date: Wed, 2 Nov 2022 06:14:10 +0100 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , Srinivas Kandagatla , Amol Maheshwari , Kalle Valo , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager Message-ID: References: <20221026185846.3983888-1-quic_eberman@quicinc.com> <20221026185846.3983888-14-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221026185846.3983888-14-quic_eberman@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221101_221321_903953_8B00A814 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote: > +#define GH_CREATE_VM _IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */ Why 0x40? Why not just use the same KVM ioctl numbers and names as you are doing the same thing as them, right? Normally your first ioctl is "0x01", not "0x40", so this feels really odd. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel