From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 785C7C4332F for ; Wed, 2 Nov 2022 01:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zsal0rGMFQZXGktAosR79CP4inVuMNCMy1tv+70VIh4=; b=H2BwBtXFyI1b30 Soijtvsdplf4gyr16CLFoJjhDks9GbWLvZMPH/0XwSIPDfCK7nXUGz+aSih9uOMjBepLBPqeCv3Uj gA3XWTz46oZD5od+2b6UVHnkYj3TaRJH5tFY2+byHAtiAVSJSF7iwcXnrSrGCN5OJZZhQKSaH08mg /UVFvMlhUqcToZ9r58bMKRMbGneOWcria2wXkhLqKkHAFGMph5roaTkF4qFp5OEaiL7uXkzgxiB+o Jz+Ht2l4tFjf7lFNUeFIPhbsCFxzE2bsR1mR42vQFjBOn9kXi9rzFvpEsvcVeq4aj/LkCTCBiN6Tj L2pdAqGVyVX319v/Ynrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oq2Wt-007tJQ-Pi; Wed, 02 Nov 2022 01:26:55 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oq2Wq-007tH2-4W; Wed, 02 Nov 2022 01:26:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ByeRLxikMYM3ac/zYAwjbHrnz6wxVOIg1IVLvVaHMRU=; b=VXXWehq9WzJBIX74BuCCaQ/2c3 qZ3Rzqevza6vojM2of3R/UGOD8gtT+DGPvDpHQ/BAPp754ld7gQqwkFYJj3UfGeA+uFDn0pF/b7Rk DnK9lNRCFD5SdpCxwkM1oxxf+YcLAWw5OBH+PzeuJYiz375yj2QHwVhWKV74VGn6TpKg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oq2WH-0019fw-Kb; Wed, 02 Nov 2022 02:26:17 +0100 Date: Wed, 2 Nov 2022 02:26:17 +0100 From: Andrew Lunn To: Daniel Golle Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net: ethernet: mediatek: ppe: add support for flow accounting Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221101_182652_199058_10321BE3 X-CRM114-Status: GOOD ( 20.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 02, 2022 at 01:03:08AM +0000, Daniel Golle wrote: > Hi Andrew, > > On Wed, Nov 02, 2022 at 01:51:21AM +0100, Andrew Lunn wrote: > > On Wed, Nov 02, 2022 at 12:42:40AM +0000, Daniel Golle wrote: > > > The PPE units found in MT7622 and newer support packet and byte > > > accounting of hw-offloaded flows. Add support for reading those > > > counters as found in MediaTek's SDK[1]. > > > > > > [1]: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/bc6a6a375c800dc2b80e1a325a2c732d1737df92 > > > Signed-off-by: Daniel Golle > > > > Sorry, but NACK. > > > > You have not explained why doing this correctly via ethtool -S cannot > > be done. debugfs is a vendor crap way of doing this. > > The debugfs interface is pre-existing and **in addition** to the > standard Linux interfaces which are also provided. It is true that > the debugfs interface in this case doesn't provide much additional > value apart from having the counter listed next to the hardware- > specific hashtable keys. As the debugfs interface for now aims to > be as complete as possible, naturally there is some redundance of > things which can also be accessed using other (standard) interfaces. debugfs is by definition unstable. It is not ABI. Anything using it is expected to break in the near future when it changes its layout. It is also totally option, you cannot expect it to be mounted. I hope you don't have any user space code using it. Maybe i should submit a patch which just for the fun of it rearranged the order in debugfs and change the file name? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel