From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Cc: stable@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] soc: ux500: do not directly dereference __iomem
Date: Wed, 2 Nov 2022 14:02:39 +0100 [thread overview]
Message-ID: <Y2Jqb9n1jmLZRkXN@zx2c4.com> (raw)
In-Reply-To: <CAHmME9pDrV1P7GVg74xHTbUaVT5Lq8urvyYCgbu=sJLApwHHNw@mail.gmail.com>
CC+ Arnd
On Sun, Oct 30, 2022 at 11:30:46PM +0100, Jason A. Donenfeld wrote:
> Hi Linus,
>
> On Sun, Oct 23, 2022 at 9:57 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >
> > Sparse reports that calling add_device_randomness() on `uid` is a
> > violation of address spaces. And indeed the next usage uses readl()
> > properly, but that was left out when passing it toadd_device_
> > randomness(). So instead copy the whole thing to the stack first.
> >
> > Fixes: 4040d10a3d44 ("ARM: ux500: add DB serial number to entropy pool")
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: stable@vger.kernel.org
> > Link: https://lore.kernel.org/all/202210230819.loF90KDh-lkp@intel.com/
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Just thought I'd follow up on this.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-11-02 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 19:57 [PATCH] soc: ux500: do not directly dereference __iomem Jason A. Donenfeld
2022-10-30 22:30 ` Jason A. Donenfeld
2022-11-02 13:02 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Jqb9n1jmLZRkXN@zx2c4.com \
--to=jason@zx2c4.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).