From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFD6CC4332F for ; Fri, 4 Nov 2022 13:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sqj6f4rKIO2BncA1TyBz+Ddrs7OXvY2YsVSmy82qg48=; b=EsraM0iKbld4MS IX9Npzy/oUBwbp7GfbwBFNGt9rccnW7bGZKclbNVHNMCeaoUv4HQeQ9i2omrAC4LMV6YbUoqy5D/M nWr7U57hD1YXRU4jYdKYHeks9/vbNndRZhyst/Xj/AoFrC8mILax51mCVu/Vg/Zgop9tv7Ja9JeMs 1Ft+DsRbNbCz2c+RM+43coOG2d38LNvqiKi25GLGx0mmUTLjbTZS91+gUdFRr6Lb50bdHNJm5r3QD 8KBS+X+XJWNa8rvkINTzhEKEg38ITnN+ESq6J8mQxeBEhWoxVoqBvIFtm+X5nGT2lAD3KRxwQDUQd v90Kd8se2NbUlvPXhgSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqweh-003feK-1k; Fri, 04 Nov 2022 13:22:43 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqwec-003fbo-UC for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 13:22:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 043A1B82C14; Fri, 4 Nov 2022 13:22:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCA70C433D6; Fri, 4 Nov 2022 13:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667568155; bh=1hK5ljR9yk+op2w1/4TNVZdI5xtxUhlyrb3pnwSfZZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rBjUUvJFW1YDZUEDqQe5gxd4NvZ4XGOlpm+123KUmXdUx7f/44XEShB9cdYuc7Khn vLo09PeNv0mXAo4yfLTZMLtkRUrLgAxqOGvLMn4/4YIC2dwgAcJWePV69gj12WJ5aq t1Urc0apTaZok13pJ8hhtqKpPEBrhjwcZMcdO6EYRJEv4H1yBBmgwtqIyZJcXPdDns dkgxuFVQ+iQX0wA5x0telfjMZ2HIVjOZEu3DOfm4kza5K8+7/P4o6WlyJ+Pbz7TZIt VvwMI1GNlfurJTPymQc3Sw3Eo+4lgnRUA3BRYvMlGJn/b6HyWwSAVUVykc09GF1UE7 dUIWE1QL54M7g== Date: Fri, 4 Nov 2022 18:52:31 +0530 From: Vinod Koul To: Tudor Ambarus Subject: Re: [PATCH v2 00/32] dmaengine: at_hdmac: Fix concurrency bugs and then convert to virt-dma Message-ID: References: <20221025090306.297886-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221025090306.297886-1-tudor.ambarus@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_062239_174940_AA41619F X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com, torfl6749@gmail.com, mripard@kernel.org, du@axentia.se, dmaengine@vger.kernel.org, peda@axentia.se, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25-10-22, 12:02, Tudor Ambarus wrote: > v2: > - reorder patches so that fixes come first -> easier to backport to > stable kernels. > - drop the devm_request_irq() patch as we had to disable the irq anyway > in remove() in order to avoid spurios IRQs. Using devm variant brings no > palpable benefit. > - reword pm_ptr commit message > > > at_hdmac driver had poor list handling and concurrency bugs. > We experienced calling of the completion call twice for the > same descriptor. Peter Rosin encountered the same while > reporting a different bug: > https://lore.kernel.org/lkml/13c6c9a2-6db5-c3bf-349b-4c127ad3496a@axentia.se/ > > Two sets of tests were performed: > 1/ tested just the fixes, to make sure everything is fine and the > concurrency bugs are squashed even without the conversion to virt-dma. > All went fine. > 2/ tested the entire series including the conversion the virt-dma > All went fine. > > I tested NAND (prep_dma_memcpy), MMC (prep_dma_slave_sg), > usart (cyclic mode), dmatest (memcpy, memset). > With the conversion to virt-dma I replaced the election of a new transfer > in the tasklet with the election of the new transfer in the interrupt > handler. We should have a shorter idle window as we remove the scheduling > latency of the tasklet. Using mtd_speedtest showed similar performances > when using NAND with DMA. That could be because of using a low timming > mode on NAND. This does not apply on dmaengine-fixes, can you please rebase and resend -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel