From: Andrew Lunn <andrew@lunn.ch>
To: Sriranjani P <sriranjani.p@samsung.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Chandrasekar R <rcsekar@samsung.com>,
Suresh Siddha <ssiddha@tesla.com>
Subject: Re: [PATCH 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
Date: Fri, 4 Nov 2022 16:25:11 +0100 [thread overview]
Message-ID: <Y2Uu16RSF9Py5AdC@lunn.ch> (raw)
In-Reply-To: <20221104120517.77980-3-sriranjani.p@samsung.com>
> +static int dwc_eqos_setup_rxclock(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> +
> + if (np && of_property_read_bool(np, "rx-clock-mux")) {
> + unsigned int reg, val;
> + struct regmap *syscon = syscon_regmap_lookup_by_phandle(np,
> + "rx-clock-mux");
> +
> + if (IS_ERR(syscon)) {
> + dev_err(&pdev->dev, "couldn't get the rx-clock-mux syscon!\n");
> + return PTR_ERR(syscon);
> + }
> +
> + if (of_property_read_u32_index(np, "rx-clock-mux", 1, ®)) {
> + dev_err(&pdev->dev, "couldn't get the rx-clock-mux reg. offset!\n");
> + return -EINVAL;
> + }
> +
> + if (of_property_read_u32_index(np, "rx-clock-mux", 2, &val)) {
> + dev_err(&pdev->dev, "couldn't get the rx-clock-mux reg. val!\n");
> + return -EINVAL;
> + }
> +
> + regmap_write(syscon, reg, val);
This appears to be one of those binds which allows any magic value to
be placed into any register. That is not how DT should be used.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-04 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221104115833epcas5p31f68ef0a192e0d6678d2e2a0b3b89c4e@epcas5p3.samsung.com>
2022-11-04 12:05 ` [PATCH 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
[not found] ` <CGME20221104115841epcas5p490b99811e257b8f3f965748df0a57be5@epcas5p4.samsung.com>
2022-11-04 12:05 ` [PATCH 1/4] dt-bindings: net: Add EQoS compatible for FSD SoC Sriranjani P
2022-11-04 12:48 ` Krzysztof Kozlowski
2022-11-16 6:21 ` Sriranjani P
[not found] ` <CGME20221104115854epcas5p4ca280f9c4cc4d1fa564d80016e9f0061@epcas5p4.samsung.com>
2022-11-04 12:05 ` [PATCH 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
2022-11-04 15:25 ` Andrew Lunn [this message]
2022-11-16 6:24 ` Sriranjani P
2022-11-04 15:32 ` Andrew Lunn
[not found] ` <CGME20221104115902epcas5p209442971ba9f4cb001a933bda3c50b25@epcas5p2.samsung.com>
2022-11-04 12:05 ` [PATCH 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Sriranjani P
2022-11-04 12:45 ` Krzysztof Kozlowski
2022-11-04 12:47 ` Krzysztof Kozlowski
2022-11-16 6:22 ` Sriranjani P
[not found] ` <CGME20221104115909epcas5p25a8a564cd18910ec2368341855c1a6a2@epcas5p2.samsung.com>
2022-11-04 12:05 ` [PATCH 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Sriranjani P
2022-11-04 12:46 ` Krzysztof Kozlowski
2022-11-16 6:17 ` Sriranjani P
2022-11-04 15:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Uu16RSF9Py5AdC@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=rcsekar@samsung.com \
--cc=richardcochran@gmail.com \
--cc=sriranjani.p@samsung.com \
--cc=ssiddha@tesla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).