From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70BF6C4332F for ; Fri, 4 Nov 2022 21:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yf1wvi7/vD5ptl3Z1wu7P9zsABSP7KQGmxIHIyHKDNk=; b=VsOsv1b7XkEJ5K 0srUnT6JmNKAztY1Pf4DfLCKvBEuEWSaD2HeGZfAdNG9g2aI57dcu/UjLzAUd+7i0692Xv4vf1bpn AmTBw+ZcPPZ5XekHmyrE8QbPKaaY5fyJnWZVfxuf9CM7Bb0y9X1VPTjnkJr2Fj3vLhaQsv7QTd86g viEXFkK7mEvxU2c/L/bV1pAUgK9QhgWEKTSsj+i50fxCHXGcDCMH6ATz1sd/OjfWyQTuz3TUpVA0d MC3l6FmMearBzs3wqU6UvUWKQMkO4RC4D+jaAL+Ei0uGnvL0Df5IfdOeu5EPLpWJgSwR4tbOVUzew 8CgAQtUFYKzqfqekjWTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1or47C-005Atr-R5; Fri, 04 Nov 2022 21:20:38 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1or479-005Aou-KO for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 21:20:37 +0000 Received: by mail-ed1-x531.google.com with SMTP id v17so9418361edc.8 for ; Fri, 04 Nov 2022 14:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3QTwUc+0ABT8lOPURWsE/s9ly5zaIlAKdIt/YceCmhQ=; b=sEnF3YX4EcoAUBMUyeDyVfLosYH3BYj7B6VqrIOMYXz8EDWozXHKPUwhMkPdBk7sS6 SOW41dYxcU89gzuun0Th6UTunJkmuKNMiqklptTO/0IPd1jX8WltBawz/ri4/mHtF9+/ YcA6DjPb0aMLnJCmwSnAcN9MXG81qbBlleSORP70HBCV7NVkmucWkPRO29REZpZqD7s5 BV0kWzq7zzHTXc8p/qnvwBnhuu+Zn/RQYJf0Kp5tYl2rYn62Lt57qK6R+vXYptvxQ7CF jO7+bYD6dnqWBfQZ9zRqlGuoVgt0eWEyhbOTPzwHSNnw7QMD6j64lTwwabJW+FRNoIhY A1lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3QTwUc+0ABT8lOPURWsE/s9ly5zaIlAKdIt/YceCmhQ=; b=AIAOVfREvu36wgRKa6kazLJ8MMekrs/ACrEe0E+vns8rDVLWyhsDdytsbq7O20OKMM McLDJ+KUpxsg5ncT7MicWGJXFhNqL152N1aUQWR94n78W9RUAViELptdSn11dZSwzVF/ Ov4Xu1b2ACHTIHS5/HJn/iMNagJcNbT8K1KJOapK0fjHUb4J7qKFtG5VcPVOozZJKEny 2V+vIze9pZWD94wH3g6BN4GA7hzyldxW5KtZpBGXVoZBCexQjG6vqEVb5bnjaCOx0ZMA p66b34CwMk9eAi+QWpYhSUfdzHrjYwYNGX75RoMk4S2+S1+kZvmBUUTWTpV43baNFqeS 4KvA== X-Gm-Message-State: ACrzQf0PhS34kw8smIrIS/J5TuuIsg4JHHtat7fexOWZtbGMQ3gGjFVG Jq5W4keGB+y2iRqIZdveZM/QYOgZwgoDqQ== X-Google-Smtp-Source: AMsMyM6knLELqNXPYiiLeFeRLblm3n6bNbMnYtHpkrvKA7sqvcELgfpIB6jE4Ca3nqc0lS90XIW87A== X-Received: by 2002:a05:6402:4505:b0:451:1551:7b14 with SMTP id ez5-20020a056402450500b0045115517b14mr16529382edb.300.1667596823030; Fri, 04 Nov 2022 14:20:23 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id ca12-20020a170906a3cc00b0079800b81709sm11533ejb.219.2022.11.04.14.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 14:20:22 -0700 (PDT) Date: Fri, 4 Nov 2022 23:20:21 +0200 From: Abel Vesa To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Peng Fan , Dan Carpenter Subject: Re: [PATCH 1/6] clk: imx93: unmap anatop base in error handling path Message-ID: References: <20221028095211.2598312-1-peng.fan@oss.nxp.com> <20221028095211.2598312-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221028095211.2598312-2-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_142035_703337_98F460EC X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-10-28 17:52:06, Peng Fan (OSS) wrote: > From: Peng Fan > > The anatop base is not unmapped during error handling path, fix it. > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk") > Reported-by: Dan Carpenter > Signed-off-by: Peng Fan Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-imx93.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index 99cff1fd108b..9ef3fcbdd951 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -258,7 +258,7 @@ static int imx93_clocks_probe(struct platform_device *pdev) > struct device_node *np = dev->of_node; > const struct imx93_clk_root *root; > const struct imx93_clk_ccgr *ccgr; > - void __iomem *base = NULL; > + void __iomem *base, *anatop_base; > int i, ret; > > clk_hw_data = kzalloc(struct_size(clk_hw_data, hws, > @@ -285,20 +285,22 @@ static int imx93_clocks_probe(struct platform_device *pdev) > "sys_pll_pfd2", 1, 2); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx93-anatop"); > - base = of_iomap(np, 0); > + anatop_base = of_iomap(np, 0); > of_node_put(np); > - if (WARN_ON(!base)) > + if (WARN_ON(!anatop_base)) > return -ENOMEM; > > - clks[IMX93_CLK_AUDIO_PLL] = imx_clk_fracn_gppll("audio_pll", "osc_24m", base + 0x1200, > + clks[IMX93_CLK_AUDIO_PLL] = imx_clk_fracn_gppll("audio_pll", "osc_24m", anatop_base + 0x1200, > &imx_fracn_gppll); > - clks[IMX93_CLK_VIDEO_PLL] = imx_clk_fracn_gppll("video_pll", "osc_24m", base + 0x1400, > + clks[IMX93_CLK_VIDEO_PLL] = imx_clk_fracn_gppll("video_pll", "osc_24m", anatop_base + 0x1400, > &imx_fracn_gppll); > > np = dev->of_node; > base = devm_platform_ioremap_resource(pdev, 0); > - if (WARN_ON(IS_ERR(base))) > + if (WARN_ON(IS_ERR(base))) { > + iounmap(anatop_base); > return PTR_ERR(base); > + } > > for (i = 0; i < ARRAY_SIZE(root_array); i++) { > root = &root_array[i]; > @@ -327,6 +329,7 @@ static int imx93_clocks_probe(struct platform_device *pdev) > > unregister_hws: > imx_unregister_hw_clocks(clks, IMX93_CLK_END); > + iounmap(anatop_base); > > return ret; > } > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel