From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13E51C4332F for ; Fri, 4 Nov 2022 21:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+SyQdl9rwIs29jqwgt0FmZgB/HQC2AcX2jFd91/dPK4=; b=yn8PEKaqHil3jW Ug8pwkepvOTh8aGSpWlVOHA1/cAXHukzTE9fskWbVhYjSYRd7zApEbeTL7y0rVfsGF13IW4VR9/lZ e5sRelJKxpLgi9Clf5Vu0//TN4MZx8DLI4bexejQKpMi5lPnunosWOLxqzp3mQI0IaFj06nCF1HzR s8fa3jFWBXmCnfewqV/JfpNFCBRqPrPiKWpHRTQs9Ewlso/MuukQyWMlJLojkDyHb/G9VjRTorqVJ QmLXKhGzHzfq6xiqLSejqsNPLkMQXaaBh4p5FZKT1FiNUTb4RD2MQl/RsJadaLf63hTcmh+h3y62g Ky7U0t+b49238hick6+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1or4KR-005Djq-8b; Fri, 04 Nov 2022 21:34:19 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1or4KO-005Dij-8d for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 21:34:17 +0000 Received: by mail-ej1-x631.google.com with SMTP id t25so16517423ejb.8 for ; Fri, 04 Nov 2022 14:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TZlIX8cuZeOQRSQTQbQX9cRSlkV364TcFG+GGAYF/Z8=; b=wD8sdK4C2h0XhONCEgetpPhAbLse9nzbZXp33TPCGfO4s/SBsMN8AFvXNRER6UQtTj ZRIUKTxt7xJ5xzyyBPN0wgOH0s1histmEabT7cNK4lDSUg+BLBxh4O/4Q0RVH4vv+Uo/ USqg7nZR2Jm//8DmUS9h58/zmo2Rt+u6DVC0iSH/15acXG4JUA2e6k5ntDoCfmpj2WWH jHgWRHW0cUQTcXIHCkfMGShWgRefu5eefqeHOxmrHcvVbrKXNc7vSqrsLjDUuZE6CIa/ vFndEY6r83SzbjTIKrnnCftZ7ArqtkC8DjJyYuifiajNcQpems9Pe0MBU8u9MAge9osc WcQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TZlIX8cuZeOQRSQTQbQX9cRSlkV364TcFG+GGAYF/Z8=; b=dMXhemDmZrYmq6KGeTa4+d6Pfsl6pyUfCEoLXOs7H7tjYzJA5JmKxtPdTPsaG7pEvh O00BfD49925KSet1S01b0fB6J2AsJ9JB4gX+rfU6m2K+HtvsrmWEHmK58j87Qypq9AdZ im4w4rKB64xGHJnDqnX4OGxs/bbUj0jXA5IOVolBV6v8UROwXMkmqOcn2aXjIHWygZ+k wAO7NjP6jB3ueTQvbBN4Ma/i4ww3i7rkmZwIAm5gWV/nyol33ZvYoMqhKzpTo2y2c6hp lo76wpxg+fwB/B4rGj0pxhn+9hjhk0Yy7ICqY3etPQ95qNXwA6/U+eeT1b88OVUxIRXd rwJg== X-Gm-Message-State: ACrzQf2S4XZ661BcfClbgjXr5S2ECcnwIZD6VHkao0f/V3HtE/5slmbc PoS7pOtv5EVPLJc3rsr/rMc9dQ== X-Google-Smtp-Source: AMsMyM52IVgyxrOzvYXBKOSHv/x6OVBfsWMnbzJEcL7xj0tR6Hp4938dpIhHCe6UutoQ06RqOST7Zg== X-Received: by 2002:a17:907:6d25:b0:7aa:f5a4:5f66 with SMTP id sa37-20020a1709076d2500b007aaf5a45f66mr35482545ejc.216.1667597651457; Fri, 04 Nov 2022 14:34:11 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id q19-20020a17090676d300b007030c97ae62sm29041ejn.191.2022.11.04.14.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 14:34:10 -0700 (PDT) Date: Fri, 4 Nov 2022 23:34:09 +0200 From: Abel Vesa To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jacky Bai , Peng Fan Subject: Re: [PATCH 5/6] clk: imx: keep hsio bus clock always on Message-ID: References: <20221028095211.2598312-1-peng.fan@oss.nxp.com> <20221028095211.2598312-6-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221028095211.2598312-6-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_143416_321136_F50E798B X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-10-28 17:52:10, Peng Fan (OSS) wrote: > From: Jacky Bai > > During Linux System suspend/resume stress test after System Sleep > enabled, system will stuck sometimes. It is because NICMIX is powered > down, which HSIOMIX(always on) is not powered down. When NICMIX > powering down, HSIOMIX will get a hardware handshake, without HSIO ROOT clk, > the handshake will lose. Then after NICMIX power on when system resume, > the access to HSIOMIX through NICMIX would be broken. So keep HSIO ROOT > always on. > > Reviewed-by: Peng Fan > Signed-off-by: Jacky Bai > [Peng Fan] rewrite commit message > Signed-off-by: Peng Fan Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-imx93.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index 422ad3c89845..7dace96f36df 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -109,7 +109,11 @@ static const struct imx93_clk_root { > { IMX93_CLK_CCM_CKO2, "ccm_cko2_root", 0x1d00, CKO2_SEL, }, > { IMX93_CLK_CCM_CKO3, "ccm_cko3_root", 0x1d80, CKO1_SEL, }, > { IMX93_CLK_CCM_CKO4, "ccm_cko4_root", 0x1e00, CKO2_SEL, }, > - { IMX93_CLK_HSIO, "hsio_root", 0x1e80, LOW_SPEED_IO_SEL, }, > + /* > + * Critical because clk is used for handshake between HSIOMIX and NICMIX when > + * NICMIX power down/on during system suspend/resume > + */ > + { IMX93_CLK_HSIO, "hsio_root", 0x1e80, LOW_SPEED_IO_SEL, CLK_IS_CRITICAL}, > { IMX93_CLK_HSIO_USB_TEST_60M, "hsio_usb_test_60m_root", 0x1f00, LOW_SPEED_IO_SEL, }, > { IMX93_CLK_HSIO_ACSCAN_80M, "hsio_acscan_80m_root", 0x1f80, LOW_SPEED_IO_SEL, }, > { IMX93_CLK_HSIO_ACSCAN_480M, "hsio_acscan_480m_root", 0x2000, MISC_SEL, }, > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel