From: Vinod Koul <vkoul@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA controller node names in example
Date: Sat, 5 Nov 2022 13:04:48 +0530 [thread overview]
Message-ID: <Y2YSGDOXpRQ8MIoR@matsya> (raw)
In-Reply-To: <07155116-2027-2916-5a39-e4dff8298b27@socionext.com>
On 02-11-22, 08:14, Kunihiko Hayashi wrote:
> On 2022/11/02 4:31, Rob Herring wrote:
> > On Tue, Nov 1, 2022 at 4:10 AM Kunihiko Hayashi
> > <hayashi.kunihiko@socionext.com> wrote:
> > >
> > > Hi Rob,
> > >
> > > On 2022/10/29 4:38, Rob Herring wrote:
> > > > On Thu, Oct 27, 2022 at 01:49:20PM +0900, Kunihiko Hayashi wrote:
> > > > > The word "glue" is ambiguous for the controller node name. Should put
> > > > > "sata-controller" instead of "ahci-glue" on the controller node.
> > > > > And rename a phy node to "sata-phy".
> > > > >
> > > > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> > > > > ---
> > > > > .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml | 4
> > > > > ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> > > > b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> > > > > index a3cd45acea28..89b8b133777a 100644
> > > > > ---
> > > > > a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.
> > > > yaml
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.
> > > > yaml
> > > > > @@ -117,14 +117,14 @@ additionalProperties: false
> > > > >
> > > > > examples:
> > > > > - |
> > > > > - ahci-glue@65700000 {
> > > > > + sata-controller@65700000 {
> > > >
> > > > But is this really the SATA controller aka AHCI?
> > > >
> > > > In cases where we don't have a standardized name, I don't think it makes
> > > > sense changing node names from one non-standard name to another.
> > >
> > > I see. This can't be named generic, so this change will drop.
> > > And "sata-phy" in the same way.
> >
> > I think sata-phy is fine. It may not be added, but usb3-phy or
> > pcie-phy are common already.
> I understand. But of cource "phy" is also common, so I defer the change
> from "phy" to "sata-phy".
Should it not be just phy@xxx does it really need to be foo-phy?
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-05 7:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 4:49 [PATCH 0/2] dt-bindings: phy: Fix UniPhier controller node names Kunihiko Hayashi
2022-10-27 4:49 ` [PATCH 1/2] dt-bindings: phy: Fix UniPhier USB3 controller node names in example Kunihiko Hayashi
2022-10-28 19:35 ` Rob Herring
2022-10-27 4:49 ` [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA " Kunihiko Hayashi
2022-10-28 19:38 ` Rob Herring
2022-11-01 9:10 ` Kunihiko Hayashi
2022-11-01 19:31 ` Rob Herring
2022-11-01 23:14 ` Kunihiko Hayashi
2022-11-05 7:34 ` Vinod Koul [this message]
2022-11-07 2:36 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2YSGDOXpRQ8MIoR@matsya \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mhiramat@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).