From: Bagas Sanjaya <bagasdotme@gmail.com>
To: nick.hawkins@hpe.com
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, verdun@hpe.com,
corbet@lwn.net, linux@armlinux.org.uk,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/6] hwmon: (gxp-fan-ctrl) Add GXP fan controller
Date: Mon, 7 Nov 2022 10:56:58 +0700 [thread overview]
Message-ID: <Y2iCCpKYRm0c7gvZ@debian.me> (raw)
In-Reply-To: <20221104193657.105130-2-nick.hawkins@hpe.com>
[-- Attachment #1.1: Type: text/plain, Size: 1840 bytes --]
On Fri, Nov 04, 2022 at 02:36:52PM -0500, nick.hawkins@hpe.com wrote:
> diff --git a/Documentation/hwmon/gxp-fan-ctrl.rst b/Documentation/hwmon/gxp-fan-ctrl.rst
> new file mode 100644
> index 000000000000..fc1709fb113b
> --- /dev/null
> +++ b/Documentation/hwmon/gxp-fan-ctrl.rst
> @@ -0,0 +1,36 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +Kernel driver gxp-fan-ctrl
> +==========================
> +
> +Supported chips:
> +
> + * HPE GXP SOC
> +
> +Author: Nick Hawkins <nick.hawkins@hpe.com>
> +
> +
> +Description
> +-----------
> +
> +gxp-fan-ctrl is a driver which provides fan control for the hpe gxp soc.
> +The driver allows the gathering of fan status and the use of fan
> +pwm control.
> +
> +
> +Usage Notes
> +-----------
> +
> +Traditionally fanY_input returns an RPM value, on HPE GXP systems it is
> +the pwm value [0-255] due to the fan speeds being reported as
> +percentages.
> +
> +
> +Sysfs attributes
> +----------------
> +
> +======================= =================================================
> +pwm[0-15] Fan 0 to 15 respective pwm value
> +fan[0-15]_input Fan 0 to 15 respective input value: pwm value
> +fan[0-15]_fault Fan 0 to 15 respective fault status: 1 fail, 0 ok
> +======================= =================================================
You need to add the documentation to toctree of hwmon documentation:
---- >8 ----
diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index ddff3c5713d74e..29ecef3ba4870b 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -73,6 +73,7 @@ Hardware Monitoring Kernel Drivers
g762
gsc-hwmon
gl518sm
+ gxp-fan-ctrl
hih6130
ibmaem
ibm-cffps
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-07 3:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 19:36 [PATCH v1 0/6] ARM: Add GXP Fan and SPI controllers nick.hawkins
2022-11-04 19:36 ` [PATCH v1 1/6] hwmon: (gxp-fan-ctrl) Add GXP fan controller nick.hawkins
2022-11-04 20:01 ` Guenter Roeck
2022-11-08 16:59 ` Hawkins, Nick
2022-11-08 17:07 ` Hawkins, Nick
2022-11-07 3:56 ` Bagas Sanjaya [this message]
2022-11-08 0:45 ` kernel test robot
2022-11-04 19:36 ` [PATCH v1 2/6] ABI: sysfs-class-hwmon: add a description for fanY_fault nick.hawkins
2022-11-04 19:36 ` [PATCH v1 3/6] dt-bindings: hwmon: Add hpe,gxp-fan-ctrl nick.hawkins
2022-11-06 10:38 ` Krzysztof Kozlowski
2022-11-07 22:36 ` Hawkins, Nick
2022-11-08 11:22 ` Krzysztof Kozlowski
2022-11-04 19:36 ` [PATCH v1 4/6] ARM: dts: add GXP Support for fans and SPI nick.hawkins
2022-11-04 19:36 ` [PATCH v1 5/6] ARM: multi_v7_defconfig: Add GXP Fan and SPI support nick.hawkins
2022-11-06 10:40 ` Krzysztof Kozlowski
2022-11-04 19:36 ` [PATCH v1 6/6] MAINTAINERS: add gxp fan controller and documents nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2iCCpKYRm0c7gvZ@debian.me \
--to=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).