From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79D57C4332F for ; Wed, 9 Nov 2022 10:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P2hOVP/C8hmlviOCbmDmWQXLDk2bqUTBLnZd4pQJo64=; b=oIcx7E0QF5r+fI DcKS1D/+htl08whevRMhSdrSF5eAVwUOitYOi4HtpsEqxM4TTzN6WWm9yvu6P+5OxTBJHQ9fSFfg5 sV41KR9GYm+BTmqgK3/SOeqOrWN8jkiS+JE8pKl75M3gWom3YqGQndBRde2ijQaZhNK5mnucgRPGd 5PvBoS9zVGMyrg/WZ4HxDa1x/kvFQGB47SjLhp9hOFrfLYGEZj6GgN/sdE9cJMPE7n63R4uexMWhd F9JAj703ZNuBfIfxBMaOUYba2tL9ul/aPZfSvSh2zJxnlkb5DnIpsQUrk7f/Kf24ueiSk5JD6eGn/ n1yQw178SaELU0exTD4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osi1C-00Ca4H-MA; Wed, 09 Nov 2022 10:09:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osi1A-00Ca2r-6a for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 10:09:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8EF7A1FB; Wed, 9 Nov 2022 02:09:13 -0800 (PST) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9BED83F534; Wed, 9 Nov 2022 02:09:05 -0800 (PST) Date: Wed, 9 Nov 2022 10:08:54 +0000 From: Alexandru Elisei To: Ard Biesheuvel Cc: catalin.marinas@arm.com, will@kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [Possible BUG] arm64: efi: efi_runtime_fixup_exception() and efi_call_virt_check_flags() both taint the kernel Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_020912_322510_D8A9E7AB X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Nov 09, 2022 at 10:07:00AM +0100, Ard Biesheuvel wrote: > On Tue, 8 Nov 2022 at 11:10, Alexandru Elisei wrote: > > > ... > > > > Speaking as an user, I think it would be nice to revert the commit, that's > > how I am running v6.1-rcX kernels on the machine, as updating the firmware > > is not feasible right now. But I realize that I'm not the one maintaining > > the code, so I don't have a strong opinion about it :) And it's better now > > than it was at rc3, when the kernel was panicing. > > > > I sent out a patch yesterday that tweaks the sync exception fixup > handler to only disable the runtime service that triggered the > exception. This means, of course, that you might hit it multiple times > if several runtime service implementations are buggy, but there are > only five or so that we actually use, so that shouldn't make a huge > difference. But it also means a) we don't trigger other code paths > that freak out when a runtime service that was available suddenly goes > away and b) the diagnostics are more useful because we will find out > which other runtime services are broken. > > Could you please test that patch? And for good measure, could you try > something like > > efibootmgr -t 3 > > (as root) to exercise the SetVariable() path as well? Tried booting with the patch applied yesterday, no regression as far as I could tell (still hitting the two add_taint() statements, but that's not what the patch does). I was trying to figure out how I could test that the other runtime services are still working correctly, your suggestion is exactly what I was looking for, thanks. The machine is a shared machine, will test when I get access to it (hopefully later today) and post my findings. Thanks, Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel