From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2439C3A59F for ; Wed, 23 Nov 2022 11:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yks7RVgrQ575rD+4Jhxf8Yodzw6MqT+1QyOn88aKj6s=; b=AB1a6X7MCU9TU5vC4a47Id1Nn3 LBucEe+iLcjHukx9Yu/KPM9/9dOS2DQlI0RXhb/1mVC7ftbl4o9MmF3RjZ6fbrGj2xH+8h9PVihDH GdeZbk/92KKtm/pyQUbqSE5Tb4Oz9WsKXDBUo4LxsELPtKZekTmC8pp1VutgRP6llYczGej1F2UbV oAzpI7zS6TmW+MVJgp19Vh8jj83ZGozQLkMCVcIhhXQFbbiXZ9OTwKPCvwbCj9xTu9n+HVUZGX2uq MnT4Me6Ml0/o3yw+32jTfjLVhSrVgHRRGjMgWV3c8RvgwDXsFQG1KC4N/aRAZSSk7YHVaTpTT5h3n cNMAxj3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxo0Y-00Gi3c-JR; Wed, 23 Nov 2022 11:33:38 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxo0V-00Gi0t-Ob for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 11:33:37 +0000 Received: by mail-ed1-x52d.google.com with SMTP id s12so24418590edd.5 for ; Wed, 23 Nov 2022 03:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SzLQWYzwDc/zuOXIznr0v/HidZjKEnivIgiwSqbSHmg=; b=TqD5t5T3SYYqxFldgxw3OvbO67Q1ZCe7qaGTPjfCXBNUg1Ha2lcx3wnczkBaXkhpFU nJdSMCHeSW6v9dgziC1yBPggPbOwtY0Sqbekuoke40Eoxxcta3f+0CEv9YFTUdiEr0sX P9VBZuyDzGd3kUJ91xOPVYUogT3tVXqJLAAyak+aWulagpm6U9EbmniI24U0jCA0O6RR 4d0WxCgmOjPLrkUZ1tPq/7vj+WjiJYqtnIsUf0TudXLCKzE3I30+muHfm8fX/nb1noax mWzBf4JdmF/anFSt++0ub4Xy8m72o7iT/ynntafg2iLm0yO5EkOr3BehLyUJKT/YAFKK sRSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SzLQWYzwDc/zuOXIznr0v/HidZjKEnivIgiwSqbSHmg=; b=hSbPAlxYK1/PEGdoNxiq1PTbnBlpslbm+hfshEY4BfogLLavRChfJJidDNMDuH+gqa NwhQMuri/qxEHmKnU3LsKh7D0KvzAo8wS+9/peUtTeUVI7JXhC3X1RdtngIvEXE3XBDL gEBNXeqrMgkieEKvhJVr9H4u4lx+pfFlzILTGYEvoVwjmz6eWm1U2vaqzmFVJNP9cfni pRvQUNefRsNvmWom/GcKgrSBIQBAgHJJ0GR3Pw9mlKJqsFiwgAc2mDmZ4l+uHjECqJfa ixXGwQLKqMSms6dv1j3pttmqlKVoy1krcyRXMnmb+gkkDBz55pgmsBiPQLfU6jCqmCur 4Y2A== X-Gm-Message-State: ANoB5pmt4jhTBl2sqeavmocYre8hJGVNItDC244hh4N2dbVY1JLuxiOo tLa7kDWBk9fPd1mY7nbXT1s= X-Google-Smtp-Source: AA0mqf5iSEROS3LcNnKM8IIN9i2M+PDi1fqpfIx2lAZF+uaiXeo4bQybwjsnfFKch9X0Hp75ZqHgzw== X-Received: by 2002:a05:6402:b1a:b0:469:15eb:71b5 with SMTP id bm26-20020a0564020b1a00b0046915eb71b5mr20061892edb.312.1669203211653; Wed, 23 Nov 2022 03:33:31 -0800 (PST) Received: from orome (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id fi17-20020a056402551100b00459012e5145sm7504132edb.70.2022.11.23.03.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 03:33:30 -0800 (PST) Date: Wed, 23 Nov 2022 12:33:29 +0100 From: Thierry Reding To: Arnd Bergmann Cc: arm@kernel.org, soc@kernel.org, Jon Hunter , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [GIT PULL v2 2/7] firmware: tegra: Changes for v6.2-rc1 Message-ID: References: <20221121171239.2041835-1-thierry.reding@gmail.com> <20221121171239.2041835-2-thierry.reding@gmail.com> <374ae4ef-2f57-4737-95af-b1bdfdb03740@app.fastmail.com> MIME-Version: 1.0 In-Reply-To: <374ae4ef-2f57-4737-95af-b1bdfdb03740@app.fastmail.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_033335_820666_1C7D401E X-CRM114-Status: GOOD ( 24.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3711748060275391364==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3711748060275391364== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6mgO8wWChS9M+MSI" Content-Disposition: inline --6mgO8wWChS9M+MSI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 22, 2022 at 10:25:50PM +0100, Arnd Bergmann wrote: > On Mon, Nov 21, 2022, at 18:12, Thierry Reding wrote: > > firmware: tegra: bpmp: Do not support big-endian >=20 > I pulled the branch, but I think this patch is inconsistent with > our normal approach: Since all ARMv7 and ARMv8 processors can > run with both big-endian and little-endian kernels, we normally > try to keep drivers portable between both ways, even though we > don't expect anyone to actually want a big-endian kernel any > more. Changing portable code to nonportable code doesn't seem > helpful here. The only reason I dropped this is because the driver is in itself inconsistent. Parts of it use byte-swapping for 32-bit values and other parts don't. I was originally going to fix big-endian support but it would've required changes to the BPMP ABI header to avoid sparse warnings in lots of places, then these ABI changes would've needed to trickle up to the canonical source, etc. All of that didn't seem worth the effort if we couldn't even test this in any way. So the easiest fix was to stop pretending and drop the partial support. > On the other hand, there are already examples of important > drivers that are fundamentally incompatible with big-endian > mode, notably drivers/efi/, which is required on a lot of > machines. >=20 > You don't have to revert this patch, but it would be helpful > to mark code that is explicitly unportable with a 'depends > on !CPU_BIG_ENDIAN' line in Kconfig. If you agree, I can > add that. Yes, feel free to add that. > Do you know of other tegra drivers that only work on > little-endian? I'm not aware of any that explicitly wouldn't work with big endian, but it's not something we've ever tested. I know that people have in the past done experiments with running emulated Tegra on QEMU in big endian mode, but it's probably not something that's very common. Thierry --6mgO8wWChS9M+MSI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmN+BQYACgkQ3SOs138+ s6GLBw/9HosNyKYV4SDWqIlX2onvjcjilJosiNzWnGWTLz1/pWb1321Y2BoH9R5J d8I6QCF/qd5KpmswOTYjPPpgQ1PAo/90TJFG+RvgFN5dXIkyjgGMMMpzj/drUJse bakxQ6N0fkMJ1w2vSamiwXG70ehO7iv+5AT4Npo8XGR4LSUwGXBtMcE5+NQA+iDr +IAdIkaY9GAWlErzz5NUWBxmO55XME/6AjIpsDgt+LzNneECb1WbtuYtldeFysyu la9aZ7rvTKNqCYaOjofqIQiv2S2w0PRdZjldwkOf4cGKUaitRrKthgLD6AI/5N+1 KkS55/kTtGmyqK66SAlyAeH+CyKImUvENLtADXnVT5wVnvrBrB9L9A/5Xf6o9Zhu WI9FVsBOAxeT1E7A+P3rAWdVK3/r0Zo7Y9q8iOJlqMKatMXSViwCVHYoKojBp5iv BKTVXSiBczGaAuP6+TrbSknN91z4MfGynSvj44Q3bZibmp1QstA5PgVTfVl22VTb 08bbdtQ184ULXj/E+Ut/SP3/wOacmY2ChcohPoVdZpA/j61T73j1pVjrJIErcQ/M 2CMucnqqv9BAVjxGR7N3trMdaZnhaSuINbcwH9qpYUF4R585FHANjbuqpZ3H9Lz/ ONWmFnAuhLCYHGHfm6BPh2DFMiQGfZb2PvFIsw418o/lf5jfpkw= =JPSy -----END PGP SIGNATURE----- --6mgO8wWChS9M+MSI-- --===============3711748060275391364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3711748060275391364==--