From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/2] arm64/asm: Remove unused assembler DAIF save/restore macros
Date: Thu, 24 Nov 2022 10:59:37 +0000 [thread overview]
Message-ID: <Y39OmahXwSo++1gi@FVFF77S0Q05N> (raw)
In-Reply-To: <20221123180209.634650-3-broonie@kernel.org>
On Wed, Nov 23, 2022 at 06:02:09PM +0000, Mark Brown wrote:
> There are no longer any users of the assembler macros for saving and
> restoring DAIF so remove them to prevent further users being added, there
> are C equivalents available.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Getting rid of these will make it easier to clean up DAIF / PMR manipulation
generally, so FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/include/asm/assembler.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index 88175551b401..d8d6627be0f6 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -34,11 +34,6 @@
> wx\n .req w\n
> .endr
>
> - .macro save_and_disable_daif, flags
> - mrs \flags, daif
> - msr daifset, #0xf
> - .endm
> -
> .macro disable_daif
> msr daifset, #0xf
> .endm
> @@ -47,10 +42,6 @@
> msr daifclr, #0xf
> .endm
>
> - .macro restore_daif, flags:req
> - msr daif, \flags
> - .endm
> -
> /*
> * Save/restore interrupts.
> */
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-24 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 18:02 [PATCH v1 0/2] arm64/asm: Remove DAIF save/restore macros Mark Brown
2022-11-23 18:02 ` [PATCH v1 1/2] arm64/kpti: Move DAIF masking to C code Mark Brown
2022-11-24 10:58 ` Mark Rutland
2022-11-23 18:02 ` [PATCH v1 2/2] arm64/asm: Remove unused assembler DAIF save/restore macros Mark Brown
2022-11-24 10:59 ` Mark Rutland [this message]
2022-11-25 13:24 ` [PATCH v1 0/2] arm64/asm: Remove " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y39OmahXwSo++1gi@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox