From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5EDDC4332F for ; Sat, 12 Nov 2022 20:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R9sjbkKaC3ZwwMtoMq5R1MrVIf+i7zXT/k3rY1J7fwo=; b=poVdC5N47XqHYv8XK8L6Wewib5 E4NKgElQUMtEL68PDQHSU1bpFVkI8gCVITE8u79qGTLp+BP4NGlzLJOmpWwolbUkUSbauI7AfEg92 NbJGGZUCe89MJ29JFgDgsTK6rVinYZbCJPtfKUEVGQ76p+AKqKsGfsFtWzfL+aS0rKEktrNKIOVEA axzpi34+l1i9B64Dii+F2V66efgCQNKYunQcZ7JpehjcL+uRA96Lqptnlx8MriLH1SYk0Dxfmp1Za gtrOPBAhmjreyRDzIf3Pkga38h2UeiixQBsfTWVzkUC62dd2hmWF9lgNGdNtqAVz1b4Pmp9iLyRBs el3TGfkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otxCA-007gJh-Ef; Sat, 12 Nov 2022 20:33:42 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otxC4-007gHt-H4 for linux-arm-kernel@lists.infradead.org; Sat, 12 Nov 2022 20:33:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7D4460769; Sat, 12 Nov 2022 20:33:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EA5FC433D6; Sat, 12 Nov 2022 20:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668285212; bh=x9mkEkI4TNpYNRcWCN2Z41iUCjKp0CTsuCucKloZ/Qc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MIE7fKaLooueyS7ffe/2vtQLMHa+T0yPMNEZlPv7hRikkO5Gj71D7xgU0S4qoGot5 jG1+9Zgqh3kwbLEIW/xLCttX+laPnX8fB99qrwEFuvp5IN9K8ZkK4Sww563so3lNKU DfivKvyBM6y5YPb1CrMA/w18YrPWYeZnJsA9yl9Gf6ste8unff7Cyd8sGbdl3rbFQX JL703DAxE9X/3EXH1yjNqI7yrySlUXshgpcelDzXgD148p/9li33qpOYZYfaeS1F6g OSUX71HTTi/QIP8oQfV6Ct2qhiP3/fKq5quyhFSRWk5tgxIYvFjNPex3wNfAouPCMP IiteRznpkjhgw== Date: Sat, 12 Nov 2022 21:33:28 +0100 From: Wolfram Sang To: Arminder Singh Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Paul Mackerras , Benjamin Herrenschmidt , Michael Ellerman , Alyssa Rosenzweig , Sven Peter , Hector Martin , Christophe Leroy , asahi@lists.linux.dev Subject: Re: [PATCH v4] i2c/pasemi: PASemi I2C controller IRQ enablement Message-ID: Mail-Followup-To: Wolfram Sang , Arminder Singh , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Paul Mackerras , Benjamin Herrenschmidt , Michael Ellerman , Alyssa Rosenzweig , Sven Peter , Hector Martin , Christophe Leroy , asahi@lists.linux.dev References: MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221112_123336_665193_BC5654C3 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3574006199203457055==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3574006199203457055== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mPWs60l+c46WSwEa" Content-Disposition: inline --mPWs60l+c46WSwEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 05, 2022 at 07:56:49AM -0400, Arminder Singh wrote: > This patch adds IRQ support to the PASemi I2C controller driver to > increase the performace of I2C transactions on platforms with PASemi I2C > controllers. While primarily intended for Apple silicon platforms, this > patch should also help in enabling IRQ support for older PASemi hardware > as well should the need arise. >=20 > This version of the patch has been tested on an M1 Ultra Mac Studio, > as well as an M1 MacBook Pro, and userspace launches successfully > while using the IRQ path for I2C transactions. >=20 > Signed-off-by: Arminder Singh Applied to for-next, thanks! One thing, though: > + while (!(status & SMSTA_XEN) && timeout--) { > + msleep(1); Checkpatch complained about this one: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/t= imers-howto.rst Not your issue because you were just moving this code around. But this might be a candidate for future improvements, thiugh. > + status =3D reg_read(smbus, REG_SMSTA); > + } --mPWs60l+c46WSwEa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmNwAxgACgkQFA3kzBSg KbZOVw//f61IwAT3+7pj46mSdeCMBH7jTcgwvVsjRoNpCQYTRVCwnNjdlYvK8ELR YNm1MwWGBSxVyEzo3Aveyv37A0JGL03Ebk254NaMLM1Uo0NNXazxu7986Uw/e8xw NhlzbFoSyH3/z0RjeolsfsTapWIHDG3URJwXCVFhBavB7pECzX4J9EW2a9f5la3s /I/82rlp5XMQ2DGQBg74V7DOikuyg9C8zjobV4ZS6bNSeR6z/NwOgPuUFigQ95W6 RuoAcQvc+5L2chm9DTOygBapALqxzTU0UD+PYjWAOtEaUzfkJiktulRN6S2kqiET uP/hUmONrylPox+Uj2Cuzs4iu/NBSwM6tlVQmlSpsSGcZWIuv+Yk0/ZYZJqtrmGe jVM75X0IqaT2cmL4cjkmtjn5MZAV85RK0rknrvnoFan34+DzDo7k50spmotIhTql WuRrp6l7id8VH0I43BULUyGiQJo2rxUiaPb/dY/BFlPPXjd3AwCkxPY4/uwSqOn+ /hOMjquEXb6kOoW18OD13MiiN0y4dcfDVPwccBp4uVEdC54VMEHFyMGwQwtYjadx IQHY0iSbMO33hLAQ5JLo6svDW1/DssP20QZU1r4tq0l3iVGZwuDm/ojAKsJ/jeaF Pqt1AqSxcJ4DCThgcLnmufmYy5xBiEV3Cb4YltmVmLJQ4g5YFUg= =b5o0 -----END PGP SIGNATURE----- --mPWs60l+c46WSwEa-- --===============3574006199203457055== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3574006199203457055==--