From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9092CC4332F for ; Mon, 14 Nov 2022 10:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Md0xwV2wdxWb7M77kThd4x6YO3XFgYh0l6sJqxJPnvk=; b=ZRbQZNRHVRpfmT VHVhrue/usdqQ2uRZZVjBByPKfiGM+uk1Xe0Y2PKhWDYSPUKmiVVl+/gEyM625P52beQ6eyI4hojm A9SyYUyVluOuTi560IF1+vfneasnhLLDxuOLfRlKEYEGybl0rFX7H6082Yk7uBfzT+G1ukACqz5Tl Z52RburfEbQYe2oqZ4wsFbeXANC9Ejd+s0uGdlTd31PUUDIbBOEv7LpFvqFAHPvwQfsjku6m28qtg G/Oy//IrumWXu/NuZ/4Ofau5CK+Qi87OFjIH7TaDeSMe5q8Z+5LumjBTqGDbA4Sh6n4JjvT9esjiZ VHer8EM1fwAdXWLKUiiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouWmm-00HZcy-KV; Mon, 14 Nov 2022 10:33:52 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouWmi-00HZad-AB for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 10:33:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 245CACE0E76; Mon, 14 Nov 2022 10:33:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36CEDC433D6; Mon, 14 Nov 2022 10:33:38 +0000 (UTC) Date: Mon, 14 Nov 2022 10:33:34 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Zhang Lei , James Morse , Alexandru Elisei , Andre Przywara , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 8/8] arm64/fp: Use a struct to pass data to fpsimd_bind_state_to_cpu() Message-ID: References: <20221021230321.1159287-1-broonie@kernel.org> <20221021230321.1159287-9-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221021230321.1159287-9-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_023348_898301_22B9FF23 X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 22, 2022 at 12:03:21AM +0100, Mark Brown wrote: > For reasons that are unclear to this reader fpsimd_bind_state_to_cpu() > populates the struct fpsimd_last_state_struct that it uses to store the > active floating point state for KVM guests by passing an argument for > each member of the structure. As the richness of the architecture increases > this is resulting in a function with a rather large number of arguments > which isn't ideal. > > Simplify the interface by using the struct directly as the single argument > for the function, renaming it as we lift the definition into the header. > This could be built on further to reduce the work we do adding storage for > new FP state in various places but for now it just simplifies this one > interface. > > Signed-off-by: Mark Brown I think this looks cleaner. Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel