From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFF90C43219 for ; Tue, 15 Nov 2022 11:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9orbMvd9Wa0Hm26xHpk9Blj9vyF1oxf6PQoXmMqP/mw=; b=32VwiclvA+hmLX dnTiHUuOxiGdmV8LkqTUNMx3Gbd9EDSHhdt7GkzNGGH8TkPIbETVUz3WBb+cYlLsiX+jWJ01UOATd Uj+87scvbcHpTYfWzXfdsnFuB5JF0qFlQWYgKxAmWusjKnGW12XjRnXn8e/dziorA82EFK1YSnm30 KUP4MbtkXTS7p9CL/NqsPpWJaalY8afCYdcle2T60y09Pm0YkdjKFCWjlHDRrLCbAjHvC/3bKruM3 2yIEj56C0hWwb9md5laOyugD1/uVdFrzNhFiip/rCRErZoxWFwKk/J3D5h1MY9MjwVcfYLKSsYJsj HQQ5CAOaLLvQtTLVeNzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouu8K-00Abl3-G1; Tue, 15 Nov 2022 11:29:40 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouu8F-00Abjj-CG for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 11:29:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668511775; x=1700047775; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FvdD9kceN5CwXDRlw8ICmZuMX9S+bhG3igZvZo2D/Ig=; b=Q2U4ZNu14WnVP1S6Our0rKsE7ZQsaBESCJIWkfcY0m6a8TAnlRs29f/G CWQRHt37Hbr1cAya69a/Cct7CMmxqrfA7Vd2UNlWdhurNIKnryCWGR178 20w3avaPhBnnYn3UMIZCqDe6hkqfms0DluCegztzfQRt7Ns6i668ktPGP uTgb/LsMJtndvJ5lSKcTV1w+KsSkGoUBAE+jhZdjw2LeMTlk+vPbE7bBN JSXmOMkITiW1i5eF5vqRh3jN3u4CxjgaVtV0icjhXwF0uxK/2ZdxHSpUL s7hJXiXNV98RTJveHJq1butt5piAALjUav4rGTgZuBZQOK6NKC8etCPCK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295593367" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="295593367" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 03:29:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="589759250" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="589759250" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 15 Nov 2022 03:29:05 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ouu7i-00Caqh-2J; Tue, 15 Nov 2022 13:29:02 +0200 Date: Tue, 15 Nov 2022 13:29:02 +0200 From: Andy Shevchenko To: Andrew Davis Cc: Rob Herring , Shawn Guo , Li Yang , Sascha Hauer , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Masahiro Yamada , Michal Marek , Nick Desaulniers , Geert Uytterhoeven , Frank Rowand , devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] Rename DTB overlay source files Message-ID: References: <20221024173434.32518-1-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_032935_518918_C062F7D8 X-CRM114-Status: GOOD ( 48.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 14, 2022 at 02:43:51PM -0600, Andrew Davis wrote: > On 11/14/22 10:06 AM, Andy Shevchenko wrote: > > On Sun, Nov 13, 2022 at 02:36:33PM +0200, Andy Shevchenko wrote: > > > On Sun, Nov 13, 2022 at 02:20:48PM +0200, Andy Shevchenko wrote: > > > > On Fri, Nov 11, 2022 at 03:05:20PM -0600, Andrew Davis wrote: > > > > > On 11/11/22 1:39 PM, Andy Shevchenko wrote: > > > > > > On Wed, Oct 26, 2022 at 09:11:21AM -0500, Rob Herring wrote: > > > > > > > On Mon, Oct 24, 2022 at 12:34 PM Andrew Davis wrote: > > > > > > > > > > > > > > > > Hello all, > > > > > > > > > > > > > > > > This is a series based on my patch here[0]. As suggested by Rob > > > > > > > > I've resurrected Frank's patch and appended it to mine as a series. > > > > > > > > > > > > > > > > First patch here is my original patch, 3rd is Frank's patch but with > > > > > > > > the unittest changes pulled out into the 2nd patch. That was re-worked > > > > > > > > moving the source building macro into scripts/Makefile.lib. > > > > > > > > > > > > > > > > Patches 4, 5, and 6 are an attempt at renaming all the existing DTB > > > > > > > > overlays. Split out by platform so they could be taken by platform > > > > > > > > maintainers or if easier ACK'd here and taken all together. > > > > > > > > > > > > > > > > This should cover all the DTB overlays so we can remove the old .dts > > > > > > > > rule for overlays and make .dtso the only supported way, let me know > > > > > > > > if we want that this cycle and I can post that too. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Andrew > > > > > > > > > > > > > > > > Changes from v1[1]: > > > > > > > > - Added patch to rename pi433 overlay. > > > > > > > > - Cleaned wording on patch 4-6. > > > > > > > > - Collected some ACKs > > > > > > > > > > > > > > > > [0] https://www.spinics.net/lists/kernel/msg4548509.html > > > > > > > > [1] https://www.spinics.net/lists/arm-kernel/msg1020165.html > > > > > > > > > > > > > > > > Andrew Davis (6): > > > > > > > > kbuild: Allow DTB overlays to built from .dtso named source files > > > > > > > > kbuild: Allow DTB overlays to built into .dtso.S files > > > > > > > > arm64: dts: freescale: Rename DTB overlay source files from .dts to > > > > > > > > .dtso > > > > > > > > arm64: dts: renesas: Rename DTB overlay source files from .dts to > > > > > > > > .dtso > > > > > > > > arm64: dts: xilinx: Rename DTB overlay source files from .dts to .dtso > > > > > > > > staging: pi433: overlay: Rename overlay source file from .dts to .dtso > > > > > > > > > > > > > > > > Frank Rowand (1): > > > > > > > > of: overlay: rename overlay source files from .dts to .dtso > > > > > > > > > > > > > > I've applied patches 1-3 and 7. I'll send a PR for the branch to the > > > > > > > platform maintainers after a few days in linux-next. > > > > > > > > > > > > The patch > > > > > > > > > > > > commit 941214a512d8c80d47e720c17ec17e8539175e93 > > > > > > Author: Andrew Davis > > > > > > Date: Mon Oct 24 12:34:29 2022 -0500 > > > > > > > > > > > > kbuild: Allow DTB overlays to built into .dtbo.S files > > > > > > > > > > > > broke the build reproducibility / no-op builds. > > > > > > > > > > > > Before: > > > > > > 2+ execution of `make` on non-changed tree did nothing > > > > > > > > > > > > Now: > > > > > > Each run of `make` (even without a single bit changed) restarts vmlinux > > > > > > rebuild. > > > > > > > > > > > > Please, revert or fix. > > > > > > > > > > > > > > > > I do not see this behavior. What config are you using? > > > > > > > > > > Not sure how this patch could be the root cause, it only adds > > > > > a build target/rule, but doesn't actually use it anywhere yet.. > > > > > > > > For your reference I started with this one [1]. > > > > > > > > When I bisected, I just answered with defaults on whatever `make` told me at > > > > the configuration stage. > > > > > > > > The actual `make` command I used: > > > > > > > > make O=/path/to/the/result W=1 C=1 CF=-D__CHECK_ENDIAN__ -j64 > > > > > > > > But there is nothing that can affect the described issue. > > > > > > Actually, O= might affect which Makefile is used and how. > > > The C=, CF= are sparse flags, W= is just warning level. > > > > As far as I can tell right now it's the OF_UNITTEST on x86_64 that makes the > > above mentioned patch to be a culprit. Not sure if on ARM / ARM64 you can > > reproduce that. And it's really strange nobody reported this for a week+. > > > > Whatever, I'm open for the suggestions and material to test. > > I think I found the issue, we forgot to add the new dtbo.S/o files > to the list of preserved intermediate targets, so Make was > removing them after build. > > Sending the fix now. I'll test it ASAP and reply there. Thank you. > > > > [1]: https://p.defau.lt/?ZSOdGnNxF9v9AQtrfDo_KQ -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel