From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E3FBC4332F for ; Tue, 15 Nov 2022 20:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z5Yl1Vtgiy6Pm677UEdSDvmTJ1x3ENEqW2yNYkQaMhY=; b=p4D0c5TFd9liB1 EH2xH+DlL8okgtOVnpYH1fm52lmJnN0iAXImj1fycJ8JvwpiNS0q5jQU4pQpjh8uNGVZl51ecKCnc h4T0wEot3ykKQsUMu4wKkYzZDqHQ8ANLcmokEGH7TxBQhtRejXj2SiuH94ATn+VVLmBqhmgQfuLK3 GCYWrwVwMv5VNCsq/KbLJMQS4XtrFshl7pDLR2aUVgrlWeenaH8IzFXiSLwOMAL1u3paTF6jlXzx8 WXzFQLZDlBZO6ipuj/47ZGyzmNHP51BoGPLCbFBtTNRSWRacBoIH2HNd+e9hscTia3GMvoneITnVn 7aZ86nVNsRLvGUGuLK9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov2jL-00EeE4-J3; Tue, 15 Nov 2022 20:40:27 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov2jI-00EeBG-Kl for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 20:40:25 +0000 Received: by mail-qk1-x731.google.com with SMTP id 8so10368066qka.1 for ; Tue, 15 Nov 2022 12:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7iYGXPjCmD+hOJN/hkZTaijhi0DrfdkinZFcCdyRXH8=; b=CwW9FhNKOaob37FQNRtH3IIpJJVYfCXdcm7NLENGdMxI2xxBXN6UNxxUcIkzynTxRo hEC4O6/Til1SAoNo0oxicCs4PwnePNgu023EFWUwVHTRfqtU3ZTJGA+g7PHjP83IcpBf pcVAB36gt92psfUNxZGQLABAYO0yihlXbtsKmfgztmNvidCUF7/T4lScA/xqUNz1nqby OGLw06kWxaR+2D8kJFCiA7PHjIx2Hc/49se95miUisA09qZELk4NJ/jhSIF7RX7EtvSY iNHt5UdqUawk/uLQy6AWdnLh7KUq7IU1Rs77JQpC80X+tcmsPPU0HvcPjyh+PfrpL4PL CEnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7iYGXPjCmD+hOJN/hkZTaijhi0DrfdkinZFcCdyRXH8=; b=6UrMZRzdy7DP7/svqUAv7l3cdMQJHDtAJwztx8p+p2bMivc7YmpMCnlAKJ2gBLDHIO 2Vgqv4uuZJ6a56RobTMUKE1NYmitgMclTgJA6o3qpx2cYMybrHD6h5GnOoXSR3Brw80l YolsXtMAwoujjds2vAygwzj9fSSUrh2TPPFRcGWqQ+mSOFTRGMuGEsdumTt1yZJwGdWc B4Mja7x9jEHKek+EXqTyzGKR0VSUbIudrDUFfijay6i7rcDMc7NRLD9sBv9eYrNu7mo0 p21WEHyJM0CrLDVjPxddSeBUgyU2UQu4VQHNTtzxEL9KEQITB8S+ZW9OJNU39gEq4DnD z87w== X-Gm-Message-State: ANoB5pkFpy+aryUANl6EqvDzS46GCX+IPSAso7uwMkNaAYDwfs7uFDAy /Bfe4QegKvJz56AzNyTLCi9m2w== X-Google-Smtp-Source: AA0mqf6zvK1xRL3Tl3X3Az/h3DyNifOOA6ALfwSSuf97W778gOs/xLwq0pgU+qMVs85p3UoBcFP0jQ== X-Received: by 2002:a37:2c03:0:b0:6fa:2cb5:8b4b with SMTP id s3-20020a372c03000000b006fa2cb58b4bmr16273452qkh.348.1668544822672; Tue, 15 Nov 2022 12:40:22 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id i15-20020a05620a248f00b006fb3884e10bsm8883738qkn.24.2022.11.15.12.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 12:40:21 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ov2jF-004k62-6h; Tue, 15 Nov 2022 16:40:21 -0400 Date: Tue, 15 Nov 2022 16:40:21 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Dennis Dalessandro , Mauro Carvalho Chehab , Alexandra Winter , Wenjia Zhang , Marek Szyprowski , Jaroslav Kysela , Takashi Iwai , Russell King , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 3/7] RDMA/qib: don't pass bogus GFP_ flags to dma_alloc_coherent Message-ID: References: <20221113163535.884299-1-hch@lst.de> <20221113163535.884299-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221113163535.884299-4-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_124024_702395_E809464C X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 13, 2022 at 05:35:31PM +0100, Christoph Hellwig wrote: > dma_alloc_coherent is an opaque allocator that only uses the GFP_ flags > for allocation context control. Don't pass GFP_USER which doesn't make > sense for a kernel DMA allocation or __GFP_COMP which makes no sense > for an allocation that can't in any way be converted to a page pointer. > > Signed-off-by: Christoph Hellwig > --- > drivers/infiniband/hw/qib/qib_iba6120.c | 2 +- > drivers/infiniband/hw/qib/qib_init.c | 21 ++++----------------- > 2 files changed, 5 insertions(+), 18 deletions(-) Same same Acked-by: Jason Gunthorpe Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel