From: Mark Brown <broonie@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] arm64/signal: Include TPIDR2 in the signal context
Date: Tue, 15 Nov 2022 17:13:39 +0000 [thread overview]
Message-ID: <Y3PIw0sAR+NgvGd0@sirena.org.uk> (raw)
In-Reply-To: <20221114161005.GB31141@willie-the-truck>
[-- Attachment #1.1: Type: text/plain, Size: 649 bytes --]
On Mon, Nov 14, 2022 at 04:10:06PM +0000, Will Deacon wrote:
> On Mon, Oct 31, 2022 at 08:17:34PM +0000, Mark Brown wrote:
> > + __get_user_error(tpidr2_el0, &user->tpidr2->tpidr2, err);
> > + if (!err)
> > + current->thread.tpidr2_el0 = tpidr2_el0;
> What guarantees this makes its way into the hardware register before we
> return to userspace, context switch or deliver another signal?
Context switch is handled, part of context switch is to restore
the value from the task struct, but other cases aren't AFAICT.
This is in general an oversight in our signal testing framework,
it does not have a pattern of validating values set in signals.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-15 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 20:17 [PATCH v2 0/4] arm64/signal: Support TPIDR2 Mark Brown
2022-10-31 20:17 ` [PATCH v2 1/4] arm64/sme: Document ABI for TPIDR2 signal information Mark Brown
2022-10-31 20:17 ` [PATCH v2 2/4] arm64/signal: Include TPIDR2 in the signal context Mark Brown
2022-11-14 16:10 ` Will Deacon
2022-11-15 12:08 ` Mark Brown
2022-11-15 12:22 ` Will Deacon
2022-11-15 16:42 ` Mark Brown
2022-11-18 13:55 ` Will Deacon
2022-11-18 15:10 ` Mark Brown
2022-11-18 19:10 ` Catalin Marinas
2022-11-23 16:53 ` Mark Brown
2022-11-15 17:13 ` Mark Brown [this message]
2022-11-18 13:53 ` Will Deacon
2022-11-18 14:04 ` Mark Brown
2022-10-31 20:17 ` [PATCH v2 3/4] kselftest/arm64: Add TPIDR2 to the set of known signal context records Mark Brown
2022-10-31 20:17 ` [PATCH v2 4/4] kselftest/arm64: Add test case for TPIDR2 signal frame records Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3PIw0sAR+NgvGd0@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=szabolcs.nagy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).