From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06261C4332F for ; Wed, 16 Nov 2022 07:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EkeZihnl1MYxfvt3L1VLdCX96FoDTSdNbs5zyBnRqIg=; b=OhLX3vw9vqWLDv UcUARBzgrpxc8QlepoJFRSS83n1RlY0vdFQNfPgj6HeyPMeYXPkW9zlZiC3qME2bOAcu5X6iCWroa Di8nV9YRKPu7QBQ3n+2hh3q9dheYPUiqprQj8aIonkqmx2qPQenkl1p2H8VnS1/VXUR/7JawxgHNf AxmCE8l5VR6rzqL8lKw+F9jUsoohsZegQmMSv+BBTMZFDYzb92+V0oZHuFMG8pT/IxnXi9AmACOm8 nNmBx8Ott6vDHzilVjsiB/IKJ8E3rp2xCtGNwMEUeWWCzQ90eM4jYrxfjJw6tnUpiqTAeCt2stjtA n1BxJKZ4Wu296nZ8zM0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovCZu-000TBd-Dw; Wed, 16 Nov 2022 07:11:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovCZr-000T3L-0D for linux-arm-kernel@lists.infradead.org; Wed, 16 Nov 2022 07:11:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A2E16185F; Wed, 16 Nov 2022 07:11:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCAD1C433D6; Wed, 16 Nov 2022 07:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668582674; bh=zJUKF6B5wFDQpbk6RK2X5F8SYhcjLUE/tEWHlFSY8dU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BMV2L/XVq3E4FzYxRA5sBJZqAKYUQbu9BdO1dXl0c8ZCElt4lSimYTB4GO7Z24qjm kI0FzTBs+IIAUJeAW6mROyWAOFLoPpc1EIMgx5OGMPTyVsTC4USEQkNBgtLwdrFdaY sxe718Vn7b8WWwyaxHU5mxH0JZFk/KczdyXRdpq/0ptjUJoPryOmoT5HXcz76B5iIS +yzicr64Ss0txe2dkw+Ikpts9er6Je7q68fj/Yijarx/ht/FBhpzVbeNGbZeRspYFf RG6kEQESaVupz3EzjRbND7MDxqS/BBnsO4R/4VvV5O+ihHPe1O4qjcLA4IhhRN74HA s4kd5LzGpAgew== Date: Wed, 16 Nov 2022 09:11:09 +0200 From: Leon Romanovsky To: Christoph Hellwig Cc: Dennis Dalessandro , Mauro Carvalho Chehab , Alexandra Winter , Wenjia Zhang , Marek Szyprowski , Jaroslav Kysela , Takashi Iwai , Russell King , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 7/7] dma-mapping: reject __GFP_COMP in dma_alloc_attrs Message-ID: References: <20221113163535.884299-1-hch@lst.de> <20221113163535.884299-8-hch@lst.de> <20221116061106.GA19118@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221116061106.GA19118@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_231119_117259_0EDFE2CC X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 16, 2022 at 07:11:06AM +0100, Christoph Hellwig wrote: > On Mon, Nov 14, 2022 at 10:11:50AM +0200, Leon Romanovsky wrote: > > In RDMA patches, you wrote that GFP_USER is not legal flag either. So it > > is better to WARN here for everything that is not allowed. > > So __GFP_COMP is actually problematic and changes behavior, and I plan > to lift an optimization from the arm code to the generic one that > only rounds up allocations to the next page size instead of the next > power of two, so I need this check now. Other flags including > GFP_USER are pretty bogus to, but I actually need to do a full audit > before rejecting them, which I've only done for GFP_COMP so far. ok, let's do it later. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel