From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A21AAC433FE for ; Thu, 17 Nov 2022 13:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dodjD54QB+aW3ZAfNuVI/uoST2pI/Me781mVgL1qd5A=; b=gHLtsOwAw5GzUk tnlY4kNKUEafBLGPRp9CPV6OEo2tsfdhMLcs4yhiHgnMtt0+z2NAcyfXSG7rfTFvG8qldYeQp+qp0 6eo4WI1wdUoVy0MnC1sllVq0BbNDROowJjPylHoCJ9b1FtyqJpFYsPbUekWEdGj8pYSGtIJsRwRcq adB7UO7S+OfKgc5KObeSKSB01hkPQf/ly9fd0gDwozvmenDQwaUKEuI5xLgHw7R719qjzyvHIOBQ3 pqX6QDkjqLg0vgMa6jXB+5G+dnVyb2PdUf1sveYhjZiMhYFWaP7VfCpGmgI60xthO7KrIb86YcC6/ dJTxdElfFPVMQYIRj/9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovfHt-00Ebee-Tu; Thu, 17 Nov 2022 13:50:43 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovfHl-00Ebbx-4l; Thu, 17 Nov 2022 13:50:34 +0000 Received: by mail-wm1-x32d.google.com with SMTP id i186-20020a1c3bc3000000b003cfe29a5733so5149901wma.3; Thu, 17 Nov 2022 05:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bkweVlMZ0g0+u7fAZmYu/Pqe+/vJOvCRgkDADGgIA2s=; b=iJErqAPL10YQES5nboDu00n0QHsr9m4pN7t6xt4KI04Mz+DP7wuasgAh2j2ltzCP7P fbniCxcdL0NkfwMQoE99Pj9zmUXLDPDT3R6K6p13KyhzVYaKQwJpMWrpG3yn0nxVIsPO hICRLxHlr/hxX/h9x9nxYuVzsZI+aUqWWOhIem0U/TeB8i7xrljLnMRdnsxMVn+rAC+6 i2QyMpIte+Tdfes76l9WVet1zrSFBmN+ibKexVtjOdfBhthB5FtSSHDD2t4+OFCMJNr7 27HUbFg9xFyyN7mlaz0e39o+8rNa/0vDhU9BgUsDllr+H49glFZ+Jx4zyZWdz7d2e/gB zaoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bkweVlMZ0g0+u7fAZmYu/Pqe+/vJOvCRgkDADGgIA2s=; b=uVts1JD6fAHOBj8rVZNwiqPiGI6wIJp0VhP0q/HWHQApWZNwX21K7au/EzcRyGRzIF aI/CZJ0sY0FHNgQ+Vg4NHLEm7SAus8IM9KkKTPg1VU0Dl7/LZtrYUiMRc6S/Lfa9OEyb g8JCJ+UVa/lIH3CylDEXeTSApezKSmPKTyFH+Aj4dI8Z2avbEoeu/M3Lph8dpc5PPhDn 91YB6mRJJgwNyDtr3bN/3WCXsXvtppFCcOSpejAPMovofEUmOQEWHYJLSN3AQMotshB8 cAQKBFUBMcymdRLbD0nQWoPgZyjonspZ9E/winutCWxvqBva2nGKeD0AFNh80aexZvWQ T8Ig== X-Gm-Message-State: ANoB5plmpHfF1Pq1ugUL7sU05UZjGUPF8EbF3IocwrPcIzy8kzsdB4Jb lF5r1jRnXLvmMWO8IZtfrZ8= X-Google-Smtp-Source: AA0mqf7iBPPgpyhI2Y14QqG2ZA1qB6Du3tc53khekXZEK+mYE7Ut5oqgY1wpI9Q2tux1n5o87QHlkA== X-Received: by 2002:a05:600c:188a:b0:3cf:8e62:f769 with SMTP id x10-20020a05600c188a00b003cf8e62f769mr5426381wmp.52.1668693029460; Thu, 17 Nov 2022 05:50:29 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p11-20020a05600c468b00b003c65c9a36dfsm1369329wmo.48.2022.11.17.05.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 05:50:29 -0800 (PST) Date: Thu, 17 Nov 2022 16:50:24 +0300 From: Dan Carpenter To: Umang Jain Cc: Greg Kroah-Hartman , Florian Fainelli , Broadcom internal kernel review list , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH 1/2] staging: vc04_services: mmal-vchiq: Do not assign bool to u32 Message-ID: References: <20221117125953.88441-1-umang.jain@ideasonboard.com> <20221117125953.88441-2-umang.jain@ideasonboard.com> <5f139eeb-24cc-85c1-34b6-f1334313839f@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5f139eeb-24cc-85c1-34b6-f1334313839f@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_055033_257408_A5469E1E X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 06:57:07PM +0530, Umang Jain wrote: > Hi Greg, > > Thanks for the comment, > > On 11/17/22 6:43 PM, Greg Kroah-Hartman wrote: > > On Thu, Nov 17, 2022 at 06:29:52PM +0530, Umang Jain wrote: > > > From: Dave Stevenson > > > > > > struct vchiq_mmal_component.enabled is a u32 type. Do not assign > > > it a bool. > > > > > > Fixes: 640e77466e69 ("staging: mmal-vchiq: Avoid use of bool in structures") > > > Signed-off-by: Dave Stevenson > > > Signed-off-by: Umang Jain > > > --- > > > drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > > > index cb921c94996a..17f8ceda87ca 100644 > > > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > > > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > > > @@ -1773,7 +1773,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance, > > > ret = enable_component(instance, component); > > > if (ret == 0) > > > - component->enabled = true; > > > + component->enabled = 1; > > Why not make enabled a bool instead? > > Makes sense. It would probably require reverting the 640e77466e69 ("staging: > mmal-vchiq: Avoid use of bool in structures") > Reverting that patch seems like a good idea. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel