From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D91B5C4332F for ; Thu, 17 Nov 2022 13:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CY4K8zumFaAYDJMmLby29CUAGaMSA9M085D5/hr3Qyo=; b=NJSn+74V8Bp3YO 09kd+F5kWxajUbeyZygVhL4ZdXzzbMuUYF568YapGuaK+1lwVpVpZ3Gaz78lmWgIFmFUYbv0PsSeP oXfEiW0H57g7A9dUxlfHZrWOV8UCbZ6DEpk7TeQN8fhtskcO9p/9fQ4crf0KVPU3ywoiOpDDY0Vw4 gMnBrEJxNKqFYXaDKRJlcMwofv4cehLtxIzOPmetwlGc0ksq6AMTpMiOjKMw0Eatwhed8RJ5Fs6fG 2D6+dcLav3+Kqt1G6eeD9DZWFwadM06PGty+e7xp2rZFyzgV91w8lowwyR2S3HYdgZyjPOLcdFGr4 M0mVpW2TglR2NN3PdIFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oveiH-00E7C3-H6; Thu, 17 Nov 2022 13:13:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovehn-00E6w5-SY; Thu, 17 Nov 2022 13:13:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A80BE61DF9; Thu, 17 Nov 2022 13:13:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DC6CC433C1; Thu, 17 Nov 2022 13:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668690802; bh=ON/iJ0r7mmy13poBgds2rLmOC5PP54ve7q6KT0jbzSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bqVOtAv4TQxFMxivBSRUniWjd0JGJpLCFwLl154hjTRz27wSQ/k8+XSPHf9WGb8aI iJOJQlqqU5fSXmTcm+QFptaqcq1U4CiTKmNL4eqzWF78hOLP9Syfxq8ZQNp8kHMP7g ZcgOwpMK6xdKo2fj3E3fBiS5h+oURr8YQ4LPvbWA= Date: Thu, 17 Nov 2022 14:13:17 +0100 From: Greg Kroah-Hartman To: Umang Jain Cc: Florian Fainelli , Broadcom internal kernel review list , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH 2/2] staging: vc04_services: mmal-common: Do not use bool in structures Message-ID: References: <20221117125953.88441-1-umang.jain@ideasonboard.com> <20221117125953.88441-3-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117125953.88441-3-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_051323_998144_27ACD07C X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 06:29:53PM +0530, Umang Jain wrote: > Do not use bool in structures, it already gets flagged by checkpatch: > > "Avoid using bool structure members because of possible alignment issues" > > Hence, modify struct mmal_fmt.remove_padding to use u32. No change in > assignments as 0/1 are already being used with mmal_fmt.remove_padding. > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/vchiq-mmal/mmal-common.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h > index b33129403a30..fd02440f41b2 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h > @@ -32,9 +32,9 @@ struct mmal_fmt { > int depth; > u32 mmal_component; /* MMAL component index to be used to encode */ > u32 ybbp; /* depth of first Y plane for planar formats */ > - bool remove_padding; /* Does the GPU have to remove padding, > - * or can we do hide padding via bytesperline. > - */ > + u32 remove_padding; /* Does the GPU have to remove padding, > + * or can we do hide padding via bytesperline. > + */ checkpatch is wrong here, bool is correct to use and is just fine. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel